mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 11:13:28 +01:00
77abaecf43
Summary: EraseInst didn't report that it made IR changes through MadeChange. It is essential that changes to the IR are reported correctly, since for example ReassociatePass::run() will indicate that all analyses are preserved otherwise. And the CGPassManager determines if the CallGraph is up-to-date based on status from InstructionCombiningPass::runOnFunction(). Reviewers: craig.topper, rnk, davide Reviewed By: rnk, davide Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D34616 llvm-svn: 306368
30 lines
799 B
LLVM
30 lines
799 B
LLVM
; RUN: opt < %s -inline -reassociate -S | FileCheck %s
|
|
|
|
; This test case exposed a bug in reassociate where EraseInst's
|
|
; removal of a dead call wasn't recognized as changing the IR.
|
|
; So when runOnFunction propagated the "made changes" upwards
|
|
; to the CallGraphSCCPass it signalled that no changes had been
|
|
; made, so CallGraphSCCPass assumed that the old CallGraph,
|
|
; as known by that pass manager, still was up-to-date.
|
|
;
|
|
; This was detected as an assert when trying to remove the
|
|
; no longer used function 'bar' (due to incorrect reference
|
|
; count in the CallGraph).
|
|
|
|
define void @foo() {
|
|
; CHECK-LABEL: @foo(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: ret void
|
|
entry:
|
|
call void @bar()
|
|
ret void
|
|
}
|
|
|
|
define internal void @bar() noinline nounwind readnone {
|
|
; CHECK-NOT: bar
|
|
entry:
|
|
ret void
|
|
}
|
|
|
|
|