mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 03:33:20 +01:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
30 lines
1.6 KiB
LLVM
30 lines
1.6 KiB
LLVM
; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | FileCheck %s
|
|
; RUN: verify-uselistorder %s
|
|
|
|
declare void @_Z3foov()
|
|
|
|
; CHECK: !named = !{!0, !1, !2, !3, !4, !5, !6, !7, !8, !9}
|
|
!named = !{!0, !1, !2, !3, !4, !5, !6, !7, !8, !9}
|
|
|
|
!0 = !{null}
|
|
!1 = distinct !DICompositeType(tag: DW_TAG_structure_type)
|
|
!2 = !DIFile(filename: "path/to/file", directory: "/path/to/dir")
|
|
!3 = !DISubroutineType(types: !0)
|
|
!4 = distinct !DICompositeType(tag: DW_TAG_structure_type)
|
|
!5 = distinct !{}
|
|
!6 = distinct !{}
|
|
|
|
; CHECK: !7 = distinct !DISubprogram(scope: null, isLocal: false, isDefinition: true, isOptimized: false)
|
|
!7 = distinct !DISubprogram()
|
|
|
|
; CHECK: !8 = !DISubprogram(scope: null, isLocal: false, isDefinition: false, isOptimized: false)
|
|
!8 = !DISubprogram(isDefinition: false)
|
|
|
|
; CHECK: !9 = distinct !DISubprogram(name: "foo", linkageName: "_Zfoov", scope: !1, file: !2, line: 7, type: !3, isLocal: true, isDefinition: true, scopeLine: 8, containingType: !4, virtuality: DW_VIRTUALITY_pure_virtual, virtualIndex: 10, flags: DIFlagPrototyped, isOptimized: true, function: void ()* @_Z3foov, templateParams: !5, declaration: !8, variables: !6)
|
|
!9 = distinct !DISubprogram(name: "foo", linkageName: "_Zfoov", scope: !1,
|
|
file: !2, line: 7, type: !3, isLocal: true,
|
|
isDefinition: true, scopeLine: 8, containingType: !4,
|
|
virtuality: DW_VIRTUALITY_pure_virtual, virtualIndex: 10,
|
|
flags: DIFlagPrototyped, isOptimized: true, function: void ()* @_Z3foov,
|
|
templateParams: !5, declaration: !8, variables: !6)
|