mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
65e3562960
This reverts commit r238350, effectively reapplying r238349 after fixing
(all?) the problems, all somehow related to how I was using
`AlignedArrayCharUnion<>` inside `DIEValue`:
- MSVC can only handle `sizeof()` on types, not values. Change the
assert.
- GCC doesn't know the `is_trivially_copyable` type trait. Instead of
asserting it, add destructors.
- Call placement new even when constructing POD (i.e., the pointers).
- Instead of copying the char buffer, copy the casted classes.
I've left in a couple of `static_assert`s that I think both MSVC and GCC
know how to handle. If the bots disagree with me, I'll remove them.
- Check that the constructed type is either standard layout or a
pointer. This protects against a programming error: we really want
the "small" `DIEValue`s to be small and simple, so don't
accidentally change them not to be.
- Similarly, check that the size of the buffer is no bigger than a
`uint64_t` or a pointer. (I thought checking against
`sizeof(uint64_t)` would be good enough, but Chandler suggested that
pointers might sometimes be bigger than that in the context of
sanitizers.)
I've also committed r238359 in the meantime, which introduces a
DIEValue.def to simplify dispatching between the various types (thanks
to a review comment by David Blaikie). Without that, this commit would
be almost unintelligible.
Here's the original commit message:
--
Change `DIEValue` to be stored/passed/etc. by value, instead of
reference. It's now a discriminated union, with a `Val` field storing
the actual type. The classes that used to inherit from `DIEValue` no
longer do. There are two categories of these:
- Small values fit in a single pointer and are stored by value.
- Large values require auxiliary storage, and are stored by reference.
The only non-mechanical change is to tools/dsymutil/DwarfLinker.cpp. It
was relying on `DIEInteger`s being passed around by reference, so I
replaced that assumption with a `PatchLocation` type that stores a safe
reference to where the `DIEInteger` lives instead.
This commit causes a temporary regression in memory usage, since I've
left merging `DIEAbbrevData` into `DIEValue` for a follow-up commit. I
measured an increase from 845 MB to 879 MB, around 3.9%. The follow-up
drops it lower than the starting point, and I've only recently brought
the memory this low anyway, so I'm committing these changes separately
to keep them incremental. (I also considered swapping the commits, but
the other one first would cause a lot more code churn.)
(I'm looking at `llc` memory usage on `verify-uselistorder.lto.opt.bc`;
see r236629 for details.)
--
llvm-svn: 238362
|
||
|---|---|---|
| .. | ||
| bugpoint | ||
| bugpoint-passes | ||
| dsymutil | ||
| gold | ||
| llc | ||
| lli | ||
| llvm-ar | ||
| llvm-as | ||
| llvm-bcanalyzer | ||
| llvm-c-test | ||
| llvm-config | ||
| llvm-cov | ||
| llvm-cxxdump | ||
| llvm-diff | ||
| llvm-dis | ||
| llvm-dwarfdump | ||
| llvm-extract | ||
| llvm-go | ||
| llvm-jitlistener | ||
| llvm-link | ||
| llvm-lto | ||
| llvm-mc | ||
| llvm-mcmarkup | ||
| llvm-nm | ||
| llvm-objdump | ||
| llvm-pdbdump | ||
| llvm-profdata | ||
| llvm-readobj | ||
| llvm-rtdyld | ||
| llvm-shlib | ||
| llvm-size | ||
| llvm-stress | ||
| llvm-symbolizer | ||
| lto | ||
| macho-dump | ||
| msbuild | ||
| obj2yaml | ||
| opt | ||
| verify-uselistorder | ||
| yaml2obj | ||
| CMakeLists.txt | ||
| LLVMBuild.txt | ||
| Makefile | ||