mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 03:33:20 +01:00
66886e6d12
The existing sorting order in defined CompareSCEVComplexity sorts AddRecExprs
by loop depth, but does not pay attention to dominance of loops. This can
lead us to the following buggy situation:
for (...) { // loop1
op1 = {A,+,B}
}
for (...) { // loop2
op2 = {A,+,B}
S = add op1, op2
}
In this case there is no guarantee that in operand list of S the op2 comes
before op1 (loop depth is the same, so they will be sorted just
lexicographically), so we can incorrectly treat S as a recurrence of loop1,
which is wrong.
This patch changes the sorting logic so that it places the dominated recs
before the dominating recs. This ensures that when we pick the first recurrency
in the operands order, it will be the bottom-most in terms of domination tree.
The attached test set includes some tests that produce incorrect SCEV
estimations and crashes with oldlogic.
Reviewers: sanjoy, reames, apilipenko, anna
Reviewed By: sanjoy
Subscribers: llvm-commits, mzolotukhin
Differential Revision: https://reviews.llvm.org/D33121
llvm-svn: 303148
|
||
|---|---|---|
| .. | ||
| AliasSet | ||
| AssumptionCache | ||
| BasicAA | ||
| BlockFrequencyInfo | ||
| BranchProbabilityInfo | ||
| CallGraph | ||
| CFLAliasAnalysis | ||
| ConstantFolding | ||
| CostModel | ||
| Delinearization | ||
| DemandedBits | ||
| DependenceAnalysis | ||
| DivergenceAnalysis | ||
| DominanceFrontier | ||
| Dominators | ||
| GlobalsModRef | ||
| IVUsers | ||
| LazyCallGraph | ||
| LazyValueAnalysis | ||
| Lint | ||
| LoopAccessAnalysis | ||
| LoopInfo | ||
| MemoryDependenceAnalysis | ||
| MemorySSA | ||
| PostDominators | ||
| ProfileSummary | ||
| RegionInfo | ||
| ScalarEvolution | ||
| ScopedNoAliasAA | ||
| TypeBasedAliasAnalysis | ||
| ValueTracking | ||
| alias-analysis-uses.ll | ||