mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 19:52:54 +01:00
13db1247c9
Summary: LowerSwitch crashed with the attached test case after deleting the default block. This happened because the current implementation of deleting dead blocks is wrong. After the default block being deleted, it contains no instruction or terminator, and it should no be traversed anymore. However, since the iterator is advanced before processSwitchInst() function is executed, the block advanced to could be deleted inside processSwitchInst(). The deleted block would then be visited next and crash dyn_cast<SwitchInst>(Cur->getTerminator()) because Cur->getTerminator() returns a nullptr. This patch fixes this problem by recording dead default blocks into a list, and delete them after all processSwitchInst() has been done. It still possible to visit dead default blocks and waste time process them. But it is a compile time issue, and I plan to have another patch to add support to skip dead blocks. Reviewers: kariddi, resistor, hans, reames Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D11852 llvm-svn: 244642
28 lines
490 B
LLVM
28 lines
490 B
LLVM
; RUN: opt < %s -lowerswitch -disable-output
|
|
|
|
; This test verify -lowerswitch does not crash after deleting the default block.
|
|
|
|
declare i32 @f(i32)
|
|
|
|
define i32 @unreachable(i32 %x) {
|
|
|
|
entry:
|
|
switch i32 %x, label %unreachable [
|
|
i32 5, label %a
|
|
i32 6, label %a
|
|
i32 7, label %a
|
|
i32 10, label %b
|
|
i32 20, label %b
|
|
i32 30, label %b
|
|
i32 40, label %b
|
|
]
|
|
unreachable:
|
|
unreachable
|
|
a:
|
|
%0 = call i32 @f(i32 0)
|
|
ret i32 %0
|
|
b:
|
|
%1 = call i32 @f(i32 1)
|
|
ret i32 %1
|
|
}
|