mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 11:13:28 +01:00
9243b281e0
The reference implementation uses a case-insensitive string comparison for strings of equal length. This will cause the string "tEo" to compare less than "VUo". However we were using a case sensitive comparison, which would generate the opposite outcome. Switch to a case insensitive comparison. Also, when one of the strings contains non-ascii characters, fallback to a straight memcmp. The only way to really test this is with a DIA test. Before this patch, the test will fail (but succeed if link.exe is used instead of lld-link). After the patch, it succeeds even with lld-link. llvm-svn: 336464
43 lines
1.3 KiB
C++
43 lines
1.3 KiB
C++
//===- PrettyExternalSymbolDumper.cpp -------------------------- *- C++ *-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "PrettyExternalSymbolDumper.h"
|
|
#include "LinePrinter.h"
|
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolExe.h"
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolPublicSymbol.h"
|
|
#include "llvm/Support/Format.h"
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::pdb;
|
|
|
|
ExternalSymbolDumper::ExternalSymbolDumper(LinePrinter &P)
|
|
: PDBSymDumper(true), Printer(P) {}
|
|
|
|
void ExternalSymbolDumper::start(const PDBSymbolExe &Symbol) {
|
|
if (auto Vars = Symbol.findAllChildren<PDBSymbolPublicSymbol>()) {
|
|
while (auto Var = Vars->getNext())
|
|
Var->dump(*this);
|
|
}
|
|
}
|
|
|
|
void ExternalSymbolDumper::dump(const PDBSymbolPublicSymbol &Symbol) {
|
|
std::string LinkageName = Symbol.getName();
|
|
if (Printer.IsSymbolExcluded(LinkageName))
|
|
return;
|
|
|
|
Printer.NewLine();
|
|
uint64_t Addr = Symbol.getVirtualAddress();
|
|
|
|
Printer << "public [";
|
|
WithColor(Printer, PDB_ColorItem::Address).get() << format_hex(Addr, 10);
|
|
Printer << "] ";
|
|
WithColor(Printer, PDB_ColorItem::Identifier).get() << LinkageName;
|
|
}
|