mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
b83eae9454
As part of making ScalarEvolution's handling of pointers consistent, we want to forbid multiplying a pointer by -1 (or any other value). This means we can't blindly subtract pointers. There are a few ways we could deal with this: 1. We could completely forbid subtracting pointers in getMinusSCEV() 2. We could forbid subracting pointers with different pointer bases (this patch). 3. We could try to ptrtoint pointer operands. The option in this patch is more friendly to non-integral pointers: code that works with normal pointers will also work with non-integral pointers. And it seems like there are very few places that actually benefit from the third option. As a minimal patch, the ScalarEvolution implementation of getMinusSCEV still ends up subtracting pointers if they have the same base. This should eliminate the shared pointer base, but eventually we'll need to rewrite it to avoid negating the pointer base. I plan to do this as a separate step to allow measuring the compile-time impact. This doesn't cause obvious functional changes in most cases; the one case that is significantly affected is ICmpZero handling in LSR (which is the source of almost all the test changes). The resulting changes seem okay to me, but suggestions welcome. As an alternative, I tried explicitly ptrtoint'ing the operands, but the result doesn't seem obviously better. I deleted the test lsr-undef-in-binop.ll becuase I couldn't figure out how to repair it to test what it was actually trying to test. Recommitting with fix to MemoryDepChecker::isDependent. Differential Revision: https://reviews.llvm.org/D104806 |
||
|---|---|---|
| .. | ||
| models | ||
| AliasAnalysis.cpp | ||
| AliasAnalysisEvaluator.cpp | ||
| AliasAnalysisSummary.cpp | ||
| AliasAnalysisSummary.h | ||
| AliasSetTracker.cpp | ||
| Analysis.cpp | ||
| AssumeBundleQueries.cpp | ||
| AssumptionCache.cpp | ||
| BasicAliasAnalysis.cpp | ||
| BlockFrequencyInfo.cpp | ||
| BlockFrequencyInfoImpl.cpp | ||
| BranchProbabilityInfo.cpp | ||
| CallGraph.cpp | ||
| CallGraphSCCPass.cpp | ||
| CallPrinter.cpp | ||
| CaptureTracking.cpp | ||
| CFG.cpp | ||
| CFGPrinter.cpp | ||
| CFLAndersAliasAnalysis.cpp | ||
| CFLGraph.h | ||
| CFLSteensAliasAnalysis.cpp | ||
| CGSCCPassManager.cpp | ||
| CMakeLists.txt | ||
| CmpInstAnalysis.cpp | ||
| CodeMetrics.cpp | ||
| ConstantFolding.cpp | ||
| ConstraintSystem.cpp | ||
| CostModel.cpp | ||
| DDG.cpp | ||
| DDGPrinter.cpp | ||
| Delinearization.cpp | ||
| DemandedBits.cpp | ||
| DependenceAnalysis.cpp | ||
| DependenceGraphBuilder.cpp | ||
| DevelopmentModeInlineAdvisor.cpp | ||
| DivergenceAnalysis.cpp | ||
| DominanceFrontier.cpp | ||
| DomPrinter.cpp | ||
| DomTreeUpdater.cpp | ||
| EHPersonalities.cpp | ||
| FunctionPropertiesAnalysis.cpp | ||
| GlobalsModRef.cpp | ||
| GuardUtils.cpp | ||
| HeatUtils.cpp | ||
| ImportedFunctionsInliningStatistics.cpp | ||
| IndirectCallPromotionAnalysis.cpp | ||
| InlineAdvisor.cpp | ||
| InlineCost.cpp | ||
| InlineSizeEstimatorAnalysis.cpp | ||
| InstCount.cpp | ||
| InstructionPrecedenceTracking.cpp | ||
| InstructionSimplify.cpp | ||
| Interval.cpp | ||
| IntervalPartition.cpp | ||
| IRSimilarityIdentifier.cpp | ||
| IVDescriptors.cpp | ||
| IVUsers.cpp | ||
| LazyBlockFrequencyInfo.cpp | ||
| LazyBranchProbabilityInfo.cpp | ||
| LazyCallGraph.cpp | ||
| LazyValueInfo.cpp | ||
| LegacyDivergenceAnalysis.cpp | ||
| Lint.cpp | ||
| Loads.cpp | ||
| LoopAccessAnalysis.cpp | ||
| LoopAnalysisManager.cpp | ||
| LoopCacheAnalysis.cpp | ||
| LoopInfo.cpp | ||
| LoopNestAnalysis.cpp | ||
| LoopPass.cpp | ||
| LoopUnrollAnalyzer.cpp | ||
| MemDepPrinter.cpp | ||
| MemDerefPrinter.cpp | ||
| MemoryBuiltins.cpp | ||
| MemoryDependenceAnalysis.cpp | ||
| MemoryLocation.cpp | ||
| MemorySSA.cpp | ||
| MemorySSAUpdater.cpp | ||
| MLInlineAdvisor.cpp | ||
| ModuleDebugInfoPrinter.cpp | ||
| ModuleSummaryAnalysis.cpp | ||
| MustExecute.cpp | ||
| ObjCARCAliasAnalysis.cpp | ||
| ObjCARCAnalysisUtils.cpp | ||
| ObjCARCInstKind.cpp | ||
| OptimizationRemarkEmitter.cpp | ||
| OverflowInstAnalysis.cpp | ||
| PHITransAddr.cpp | ||
| PhiValues.cpp | ||
| PostDominators.cpp | ||
| ProfileSummaryInfo.cpp | ||
| PtrUseVisitor.cpp | ||
| README.txt | ||
| RegionInfo.cpp | ||
| RegionPass.cpp | ||
| RegionPrinter.cpp | ||
| ReleaseModeModelRunner.cpp | ||
| ReplayInlineAdvisor.cpp | ||
| ScalarEvolution.cpp | ||
| ScalarEvolutionAliasAnalysis.cpp | ||
| ScalarEvolutionDivision.cpp | ||
| ScalarEvolutionNormalization.cpp | ||
| ScopedNoAliasAA.cpp | ||
| StackLifetime.cpp | ||
| StackSafetyAnalysis.cpp | ||
| StratifiedSets.h | ||
| SyncDependenceAnalysis.cpp | ||
| SyntheticCountsUtils.cpp | ||
| TargetLibraryInfo.cpp | ||
| TargetTransformInfo.cpp | ||
| TFUtils.cpp | ||
| Trace.cpp | ||
| TypeBasedAliasAnalysis.cpp | ||
| TypeMetadataUtils.cpp | ||
| ValueLattice.cpp | ||
| ValueLatticeUtils.cpp | ||
| ValueTracking.cpp | ||
| VectorUtils.cpp | ||
| VFABIDemangling.cpp | ||
Analysis Opportunities:
//===---------------------------------------------------------------------===//
In test/Transforms/LoopStrengthReduce/quadradic-exit-value.ll, the
ScalarEvolution expression for %r is this:
{1,+,3,+,2}<loop>
Outside the loop, this could be evaluated simply as (%n * %n), however
ScalarEvolution currently evaluates it as
(-2 + (2 * (trunc i65 (((zext i64 (-2 + %n) to i65) * (zext i64 (-1 + %n) to i65)) /u 2) to i64)) + (3 * %n))
In addition to being much more complicated, it involves i65 arithmetic,
which is very inefficient when expanded into code.
//===---------------------------------------------------------------------===//
In formatValue in test/CodeGen/X86/lsr-delayed-fold.ll,
ScalarEvolution is forming this expression:
((trunc i64 (-1 * %arg5) to i32) + (trunc i64 %arg5 to i32) + (-1 * (trunc i64 undef to i32)))
This could be folded to
(-1 * (trunc i64 undef to i32))
//===---------------------------------------------------------------------===//