mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-26 14:33:02 +02:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
44 lines
2.0 KiB
LLVM
44 lines
2.0 KiB
LLVM
; RUN: llc %s -mtriple=x86_64-pc-linux-gnu -O0 -filetype=obj -o %t
|
|
; RUN: llvm-dwarfdump -debug-dump=info %t | FileCheck %s
|
|
|
|
; If stack is realigned, we shouldn't describe locations of local
|
|
; variables by giving offset from the frame pointer (%rbp):
|
|
; push %rpb
|
|
; mov %rsp,%rbp
|
|
; and ALIGNMENT,%rsp ; (%rsp and %rbp are different now)
|
|
; It's better to use offset from %rsp instead.
|
|
|
|
; DW_AT_location of variable "x" shouldn't be equal to
|
|
; (DW_OP_fbreg: .*): DW_OP_fbreg has code 0x91
|
|
|
|
; CHECK: {{0x.* DW_TAG_variable}}
|
|
; CHECK-NOT: {{DW_AT_location.*DW_FORM_block1.*0x.*91}}
|
|
; CHECK: NULL
|
|
|
|
define void @_Z3runv() nounwind uwtable {
|
|
entry:
|
|
%x = alloca i32, align 32
|
|
call void @llvm.dbg.declare(metadata i32* %x, metadata !9, metadata !DIExpression()), !dbg !12
|
|
ret void, !dbg !13
|
|
}
|
|
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) nounwind readnone
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!15}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, producer: "clang version 3.2 (trunk 155696:155697) (llvm/trunk 155696)", isOptimized: false, emissionKind: 0, file: !14, enums: !1, retainedTypes: !1, subprograms: !3, globals: !1, imports: !1)
|
|
!1 = !{}
|
|
!3 = !{!5}
|
|
!5 = distinct !DISubprogram(name: "run", linkageName: "_Z3runv", line: 1, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, scopeLine: 1, file: !14, scope: !6, type: !7, function: void ()* @_Z3runv, variables: !1)
|
|
!6 = !DIFile(filename: "test.cc", directory: "/home/samsonov/debuginfo")
|
|
!7 = !DISubroutineType(types: !8)
|
|
!8 = !{null}
|
|
!9 = !DILocalVariable(name: "x", line: 2, scope: !10, file: !6, type: !11)
|
|
!10 = distinct !DILexicalBlock(line: 1, column: 12, file: !14, scope: !5)
|
|
!11 = !DIBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!12 = !DILocation(line: 2, column: 7, scope: !10)
|
|
!13 = !DILocation(line: 3, column: 1, scope: !10)
|
|
!14 = !DIFile(filename: "test.cc", directory: "/home/samsonov/debuginfo")
|
|
!15 = !{i32 1, !"Debug Info Version", i32 3}
|