mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-26 14:33:02 +02:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
57 lines
2.7 KiB
LLVM
57 lines
2.7 KiB
LLVM
; RUN: llc < %s -O0 -mtriple x86_64-apple-darwin
|
|
; <rdar://problem/11134152>
|
|
|
|
define i32 @foo(i32* %x) nounwind uwtable ssp {
|
|
entry:
|
|
%x.addr = alloca i32*, align 8
|
|
%saved_stack = alloca i8*
|
|
%cleanup.dest.slot = alloca i32
|
|
store i32* %x, i32** %x.addr, align 8
|
|
call void @llvm.dbg.declare(metadata i32** %x.addr, metadata !14, metadata !DIExpression()), !dbg !15
|
|
%0 = load i32*, i32** %x.addr, align 8, !dbg !16
|
|
%1 = load i32, i32* %0, align 4, !dbg !16
|
|
%2 = zext i32 %1 to i64, !dbg !16
|
|
%3 = call i8* @llvm.stacksave(), !dbg !16
|
|
store i8* %3, i8** %saved_stack, !dbg !16
|
|
%vla = alloca i8, i64 %2, align 16, !dbg !16
|
|
call void @llvm.dbg.declare(metadata i8* %vla, metadata !18, metadata !DIExpression()), !dbg !23
|
|
store i32 1, i32* %cleanup.dest.slot
|
|
%4 = load i8*, i8** %saved_stack, !dbg !24
|
|
call void @llvm.stackrestore(i8* %4), !dbg !24
|
|
ret i32 0, !dbg !25
|
|
}
|
|
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) nounwind readnone
|
|
|
|
declare i8* @llvm.stacksave() nounwind
|
|
|
|
declare void @llvm.stackrestore(i8*) nounwind
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!27}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C99, producer: "clang version 3.1 (trunk 153698)", isOptimized: false, emissionKind: 0, file: !26, enums: !1, retainedTypes: !1, subprograms: !3, globals: !1)
|
|
!1 = !{}
|
|
!3 = !{!5}
|
|
!5 = distinct !DISubprogram(name: "foo", line: 6, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, file: !26, scope: !0, type: !7, function: i32 (i32*)* @foo)
|
|
!6 = !DIFile(filename: "20020104-2.c", directory: "/Volumes/Sandbox/llvm")
|
|
!7 = !DISubroutineType(types: !8)
|
|
!8 = !{!9, !10}
|
|
!9 = !DIBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!10 = !DIDerivedType(tag: DW_TAG_pointer_type, size: 64, align: 64, baseType: !11)
|
|
!11 = !DIDerivedType(tag: DW_TAG_const_type, baseType: !9)
|
|
!14 = !DILocalVariable(name: "x", line: 5, arg: 1, scope: !5, file: !6, type: !10)
|
|
!15 = !DILocation(line: 5, column: 21, scope: !5)
|
|
!16 = !DILocation(line: 7, column: 13, scope: !17)
|
|
!17 = distinct !DILexicalBlock(line: 6, column: 1, file: !26, scope: !5)
|
|
!18 = !DILocalVariable(name: "a", line: 7, scope: !17, file: !6, type: !19)
|
|
!19 = !DICompositeType(tag: DW_TAG_array_type, align: 8, baseType: !20, elements: !21)
|
|
!20 = !DIBasicType(tag: DW_TAG_base_type, name: "char", size: 8, align: 8, encoding: DW_ATE_signed_char)
|
|
!21 = !{!22}
|
|
!22 = !DISubrange(count: -1)
|
|
!23 = !DILocation(line: 7, column: 8, scope: !17)
|
|
!24 = !DILocation(line: 9, column: 1, scope: !17)
|
|
!25 = !DILocation(line: 8, column: 3, scope: !17)
|
|
!26 = !DIFile(filename: "20020104-2.c", directory: "/Volumes/Sandbox/llvm")
|
|
!27 = !{i32 1, !"Debug Info Version", i32 3}
|