mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 02:52:53 +02:00
6fce828d58
AliasSetTracker has special case handling for memset, memcpy and memmove which pre-existed argmemonly on functions and readonly and writeonly on arguments. This patch generalizes it using the AA infrastructure to any call correctly annotated. The motivation here is to cut down on confusion, not performance per se. For most instructions, there is a direct mapping to alias set. However, this is not guaranteed by the interface and was not in fact true for these three intrinsics *and only these three intrinsics*. I kept getting myself confused about this invariant, so I figured it would be good to clearly distinguish between a instructions and alias sets. Calls happened to be an easy target. The nice side effect is that custom implementations of memset/memcpy/memmove - including wrappers discovered by IPO - can now be optimized the same as builts by LICM. Note: The actual removal of the memset/memtransfer specific handling will happen in a follow on NFC patch. It was originally part of this one, but separate for ease of review and rebase. Differential Revision: https://reviews.llvm.org/D50730 llvm-svn: 341713
136 lines
5.2 KiB
LLVM
136 lines
5.2 KiB
LLVM
; RUN: opt -basicaa -print-alias-sets -S -o - < %s 2>&1 | FileCheck %s
|
|
|
|
@s = global i8 1, align 1
|
|
@d = global i8 2, align 1
|
|
|
|
; CHECK: Alias sets for function 'test_alloca_argmemonly':
|
|
; CHECK-NEXT: Alias Set Tracker: 2 alias sets for 3 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %a, 1)
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 2] may alias, Mod/Ref Pointers: (i8* %d, unknown), (i8* %s, unknown)
|
|
define void @test_alloca_argmemonly(i8* %s, i8* %d) {
|
|
entry:
|
|
%a = alloca i8, align 1
|
|
store i8 1, i8* %a, align 1
|
|
call void @my_memcpy(i8* %d, i8* %s, i64 1)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test_readonly_arg'
|
|
; CHECK-NEXT: Alias Set Tracker: 2 alias sets for 2 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %d, unknown)
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Ref Pointers: (i8* %s, unknown)
|
|
define i8 @test_readonly_arg(i8* noalias %s, i8* noalias %d) {
|
|
entry:
|
|
call void @my_memcpy(i8* %d, i8* %s, i64 1)
|
|
%ret = load i8, i8* %s
|
|
ret i8 %ret
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test_noalias_argmemonly':
|
|
; CHECK-NEXT: Alias Set Tracker: 2 alias sets for 3 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %a, 1)
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 2] may alias, Mod/Ref Pointers: (i8* %d, unknown), (i8* %s, unknown)
|
|
define void @test_noalias_argmemonly(i8* noalias %a, i8* %s, i8* %d) {
|
|
entry:
|
|
store i8 1, i8* %a, align 1
|
|
call void @my_memmove(i8* %d, i8* %s, i64 1)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test5':
|
|
; CHECK-NEXT: Alias Set Tracker: 2 alias sets for 2 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod/Ref Pointers: (i8* %a, unknown)
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %b, unknown)
|
|
define void @test5(i8* noalias %a, i8* noalias %b) {
|
|
entry:
|
|
store i8 1, i8* %a, align 1
|
|
call void @my_memcpy(i8* %b, i8* %a, i64 1)
|
|
store i8 1, i8* %b, align 1
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test_argcollapse':
|
|
; CHECK-NEXT: Alias Set Tracker: 2 alias sets for 2 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod/Ref Pointers: (i8* %a, unknown)
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod/Ref Pointers: (i8* %b, unknown)
|
|
define void @test_argcollapse(i8* noalias %a, i8* noalias %b) {
|
|
entry:
|
|
store i8 1, i8* %a, align 1
|
|
call void @my_memmove(i8* %b, i8* %a, i64 1)
|
|
store i8 1, i8* %b, align 1
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test_memcpy1':
|
|
; CHECK-NEXT: Alias Set Tracker: 2 alias sets for 2 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod/Ref Pointers: (i8* %b, unknown)
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod/Ref Pointers: (i8* %a, unknown)
|
|
define void @test_memcpy1(i8* noalias %a, i8* noalias %b) {
|
|
entry:
|
|
call void @my_memcpy(i8* %b, i8* %a, i64 1)
|
|
call void @my_memcpy(i8* %a, i8* %b, i64 1)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test_memset1':
|
|
; CHECK-NEXT: Alias Set Tracker: 1 alias sets for 1 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %a, unknown)
|
|
define void @test_memset1() {
|
|
entry:
|
|
%a = alloca i8, align 1
|
|
call void @my_memset(i8* %a, i8 0, i64 1)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test_memset2':
|
|
; CHECK-NEXT: Alias Set Tracker: 1 alias sets for 1 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %a, unknown)
|
|
define void @test_memset2(i8* %a) {
|
|
entry:
|
|
call void @my_memset(i8* %a, i8 0, i64 1)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Alias sets for function 'test_memset3':
|
|
; CHECK-NEXT: Alias Set Tracker: 1 alias sets for 2 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 2] may alias, Mod Pointers: (i8* %a, unknown), (i8* %b, unknown)
|
|
define void @test_memset3(i8* %a, i8* %b) {
|
|
entry:
|
|
call void @my_memset(i8* %a, i8 0, i64 1)
|
|
call void @my_memset(i8* %b, i8 0, i64 1)
|
|
ret void
|
|
}
|
|
|
|
;; PICKUP HERE
|
|
|
|
; CHECK: Alias sets for function 'test_memset4':
|
|
; CHECK-NEXT: Alias Set Tracker: 2 alias sets for 2 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %a, unknown)
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Mod Pointers: (i8* %b, unknown)
|
|
define void @test_memset4(i8* noalias %a, i8* noalias %b) {
|
|
entry:
|
|
call void @my_memset(i8* %a, i8 0, i64 1)
|
|
call void @my_memset(i8* %b, i8 0, i64 1)
|
|
ret void
|
|
}
|
|
|
|
declare void @my_memset(i8* nocapture writeonly, i8, i64) argmemonly
|
|
declare void @my_memcpy(i8* nocapture writeonly, i8* nocapture readonly, i64) argmemonly
|
|
declare void @my_memmove(i8* nocapture, i8* nocapture readonly, i64) argmemonly
|
|
|
|
|
|
; CHECK: Alias sets for function 'test_attribute_intersect':
|
|
; CHECK-NEXT: Alias Set Tracker: 1 alias sets for 1 pointer values.
|
|
; CHECK-NEXT: AliasSet[0x{{[0-9a-f]+}}, 1] must alias, Ref Pointers: (i8* %a, 1)
|
|
define i8 @test_attribute_intersect(i8* noalias %a) {
|
|
entry:
|
|
;; This call is effectively readnone since the argument is readonly
|
|
;; and the function is declared writeonly.
|
|
call void @attribute_intersect(i8* %a)
|
|
%val = load i8, i8* %a
|
|
ret i8 %val
|
|
}
|
|
|
|
declare void @attribute_intersect(i8* readonly) argmemonly writeonly
|
|
|