mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
1e2a9af4d5
The unnamedaddr property of a function is lost when using
`-fwhole-program-vtables` and thinlto which causes size increase under linker's
safe icf mode.
The size increase of chrome on Linux when switching from all icf to safe icf
drops from 5 MB to 3 MB after this change, and from 6 MB to 4 MB on Windows.
There is a repro:
```
# a.h
struct A {
virtual int f();
virtual int g();
};
# a.cpp
#include "a.h"
int A::f() { return 10; }
int A::g() { return 10; }
# main.cpp
#include "a.h"
int g(A* a) {
return a->f();
}
int main(int argv, char** args) {
A a;
return g(&a);
}
$ clang++ -O2 -ffunction-sections -flto=thin -fwhole-program-vtables -fsplit-lto-unit -c main.cpp -o main.o && clang++ -Wl,--icf=safe -fuse-ld=lld -flto=thin main.o -o a.out && llvm-readobj -t a.out | grep -A 1 -e _ZN1A1fEv -e _ZN1A1gEv
Name: _ZN1A1fEv (480)
Value: 0x201830
--
Name: _ZN1A1gEv (490)
Value: 0x201840
```
Differential Revision: https://reviews.llvm.org/D100498
88 lines
2.5 KiB
LLVM
88 lines
2.5 KiB
LLVM
; RUN: opt -thinlto-bc -thinlto-split-lto-unit -o %t %s
|
|
; RUN: llvm-modextract -b -n 0 -o - %t | llvm-dis | FileCheck --check-prefix=M0 %s
|
|
; RUN: llvm-modextract -b -n 1 -o - %t | llvm-dis | FileCheck --check-prefix=M1 %s
|
|
|
|
; M0: @g = external constant [10 x i8*]{{$}}
|
|
; M1: @g = constant [10 x i8*]
|
|
@g = constant [10 x i8*] [
|
|
i8* bitcast (i64 (i8*)* @ok1 to i8*),
|
|
i8* bitcast (i64 (i8*, i64)* @ok2 to i8*),
|
|
i8* bitcast (void (i8*)* @wrongtype1 to i8*),
|
|
i8* bitcast (i128 (i8*)* @wrongtype2 to i8*),
|
|
i8* bitcast (i64 ()* @wrongtype3 to i8*),
|
|
i8* bitcast (i64 (i8*, i8*)* @wrongtype4 to i8*),
|
|
i8* bitcast (i64 (i8*, i128)* @wrongtype5 to i8*),
|
|
i8* bitcast (i64 (i8*)* @usesthis to i8*),
|
|
i8* bitcast (i8 (i8*)* @reads to i8*),
|
|
i8* bitcast (i8* (i8*, i8)* @attributedFunc to i8*)
|
|
], !type !0
|
|
|
|
; M0: define i64 @ok1
|
|
; M1: define available_externally i64 @ok1
|
|
define i64 @ok1(i8* %this) {
|
|
ret i64 42
|
|
}
|
|
|
|
; M0: define i64 @ok2
|
|
; M1: define available_externally i64 @ok2
|
|
define i64 @ok2(i8* %this, i64 %arg) {
|
|
%1 = tail call { i64, i1 } @llvm.sadd.with.overflow.i64(i64 %arg, i64 %arg)
|
|
ret i64 %arg
|
|
}
|
|
|
|
; M1: declare { i64, i1 } @llvm.sadd.with.overflow.i64(i64, i64)
|
|
declare { i64, i1 } @llvm.sadd.with.overflow.i64(i64, i64)
|
|
|
|
; M0: define void @wrongtype1
|
|
; M1: declare void @wrongtype1()
|
|
define void @wrongtype1(i8*) {
|
|
ret void
|
|
}
|
|
|
|
; M0: define i128 @wrongtype2
|
|
; M1: declare void @wrongtype2()
|
|
define i128 @wrongtype2(i8*) {
|
|
ret i128 0
|
|
}
|
|
|
|
; M0: define i64 @wrongtype3
|
|
; M1: declare void @wrongtype3()
|
|
define i64 @wrongtype3() {
|
|
ret i64 0
|
|
}
|
|
|
|
; M0: define i64 @wrongtype4
|
|
; M1: declare void @wrongtype4()
|
|
define i64 @wrongtype4(i8*, i8*) {
|
|
ret i64 0
|
|
}
|
|
|
|
; M0: define i64 @wrongtype5
|
|
; M1: declare void @wrongtype5()
|
|
define i64 @wrongtype5(i8*, i128) {
|
|
ret i64 0
|
|
}
|
|
|
|
; M0: define i64 @usesthis
|
|
; M1: declare void @usesthis()
|
|
define i64 @usesthis(i8* %this) {
|
|
%i = ptrtoint i8* %this to i64
|
|
ret i64 %i
|
|
}
|
|
|
|
; M0: define i8 @reads
|
|
; M1: declare void @reads()
|
|
define i8 @reads(i8* %this) {
|
|
%l = load i8, i8* %this
|
|
ret i8 %l
|
|
}
|
|
|
|
; Check function attributes are copied over splitted module
|
|
; M0: declare dso_local noundef i8* @attributedFunc(i8* noalias, i8 zeroext) unnamed_addr #[[ATTR0:[0-9]+]]
|
|
; M1: declare dso_local void @attributedFunc() unnamed_addr #[[ATTR1:[0-9]+]]
|
|
declare dso_local noundef i8* @attributedFunc(i8* noalias, i8 zeroext) unnamed_addr alwaysinline willreturn
|
|
; M0: attributes #[[ATTR0]] = { alwaysinline willreturn }
|
|
; M1: attributes #[[ATTR1]] = { alwaysinline willreturn }
|
|
|
|
!0 = !{i32 0, !"typeid"}
|