mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 11:02:59 +02:00
2a832bbb5f
Summary: For current architect, we always require setContainingCsect to be called on every MCSymbol got used in XCOFF context. This is very hard to achieve because symbols gets created everywhere and other MCSymbol types(ELF, COFF) do not have similar rules. It's very easy to miss setting the containing csect, and we would need to add a lot of XCOFF specialized code around some common code area. This patch intendeds to do 1. Rely on getFragment().getParent() to get csect from labels. 2. Only use get/setRepresentedCsect (was get/setContainingCsect) if symbol itself represents a csect. Reviewers: DiggerLin, hubert.reinterpretcast, daltenty Differential Revision: https://reviews.llvm.org/D77080
34 lines
1.4 KiB
C++
34 lines
1.4 KiB
C++
//===- lib/MC/MCSymbolXCOFF.cpp - XCOFF Code Symbol Representation --------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/MC/MCSectionXCOFF.h"
|
|
|
|
using namespace llvm;
|
|
|
|
MCSectionXCOFF *MCSymbolXCOFF::getRepresentedCsect() const {
|
|
assert(RepresentedCsect &&
|
|
"Trying to get csect representation of this symbol but none was set.");
|
|
assert((!getName().equals(getUnqualifiedName()) ||
|
|
RepresentedCsect->getCSectType() == XCOFF::XTY_ER) &&
|
|
"Symbol does not represent a csect; MCSectionXCOFF that represents "
|
|
"the symbol should not be (but is) set.");
|
|
return RepresentedCsect;
|
|
}
|
|
|
|
void MCSymbolXCOFF::setRepresentedCsect(MCSectionXCOFF *C) {
|
|
assert(C && "Assigned csect should not be null.");
|
|
assert((!RepresentedCsect || RepresentedCsect == C) &&
|
|
"Trying to set a csect that doesn't match the one that"
|
|
"this symbol is already mapped to.");
|
|
assert((!getName().equals(getUnqualifiedName()) ||
|
|
C->getCSectType() == XCOFF::XTY_ER) &&
|
|
"Symbol does not represent a csect; can only set a MCSectionXCOFF "
|
|
"representation for a csect.");
|
|
RepresentedCsect = C;
|
|
}
|