mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 02:52:53 +02:00
d9a1aa7aba
Fixes the main issue in PR41693
When both modes are used, two functions are created:
`sancov.module_ctor`, `sancov.module_ctor.$LastUnique`, where
$LastUnique is the current LastUnique counter that may be different in
another module.
`sancov.module_ctor.$LastUnique` belongs to the comdat group of the same
name (due to the non-null third field of the ctor in llvm.global_ctors).
COMDAT group section [ 9] `.group' [sancov.module_ctor] contains 6 sections:
[Index] Name
[ 10] .text.sancov.module_ctor
[ 11] .rela.text.sancov.module_ctor
[ 12] .text.sancov.module_ctor.6
[ 13] .rela.text.sancov.module_ctor.6
[ 23] .init_array.2
[ 24] .rela.init_array.2
# 2 problems:
# 1) If sancov.module_ctor in this module is discarded, this group
# has a relocation to a discarded section. ld.bfd and gold will
# error. (Another issue: it is silently accepted by lld)
# 2) The comdat group has an unstable name that may be different in
# another translation unit. Even if the linker allows the dangling relocation
# (with --noinhibit-exec), there will be many undesired .init_array entries
COMDAT group section [ 25] `.group' [sancov.module_ctor.6] contains 2 sections:
[Index] Name
[ 26] .init_array.2
[ 27] .rela.init_array.2
By using different module ctor names, the associated comdat group names
will also be different and thus stable across modules.
Reviewed By: morehouse, phosek
Differential Revision: https://reviews.llvm.org/D61510
llvm-svn: 360107
42 lines
1.7 KiB
LLVM
42 lines
1.7 KiB
LLVM
; RUN: opt < %s -sancov -sanitizer-coverage-level=4 -sanitizer-coverage-trace-pc-guard -S | FileCheck %s --check-prefix=CHECK_TRACE_PC_GUARD
|
|
|
|
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
|
|
target triple = "x86_64-unknown-linux-gnu"
|
|
define void @foo(i32* %a) sanitize_address {
|
|
entry:
|
|
%tobool = icmp eq i32* %a, null
|
|
br i1 %tobool, label %if.end, label %if.then
|
|
|
|
if.then: ; preds = %entry
|
|
store i32 0, i32* %a, align 4
|
|
br label %if.end
|
|
|
|
if.end: ; preds = %entry, %if.then
|
|
ret void
|
|
}
|
|
|
|
%struct.StructWithVptr = type { i32 (...)** }
|
|
|
|
define void @CallViaVptr(%struct.StructWithVptr* %foo) uwtable sanitize_address {
|
|
entry:
|
|
%0 = bitcast %struct.StructWithVptr* %foo to void (%struct.StructWithVptr*)***
|
|
%vtable = load void (%struct.StructWithVptr*)**, void (%struct.StructWithVptr*)*** %0, align 8
|
|
%1 = load void (%struct.StructWithVptr*)*, void (%struct.StructWithVptr*)** %vtable, align 8
|
|
tail call void %1(%struct.StructWithVptr* %foo)
|
|
tail call void %1(%struct.StructWithVptr* %foo)
|
|
tail call void asm sideeffect "", ""()
|
|
ret void
|
|
}
|
|
|
|
; CHECK_TRACE_PC_GUARD-LABEL: define void @foo
|
|
; CHECK_TRACE_PC_GUARD: call void @__sanitizer_cov_trace_pc
|
|
; CHECK_TRACE_PC_GUARD: call void asm sideeffect "", ""()
|
|
; CHECK_TRACE_PC_GUARD: ret void
|
|
|
|
; CHECK_TRACE_PC_GUARD-LABEL: define void @CallViaVptr
|
|
; CHECK_TRACE_PC_GUARD: call void @__sanitizer_cov_trace_pc_indir
|
|
; CHECK_TRACE_PC_GUARD: call void @__sanitizer_cov_trace_pc_indir
|
|
; CHECK_TRACE_PC_GUARD: ret void
|
|
|
|
; CHECK_TRACE_PC_GUARD-LABEL: define internal void @sancov.module_ctor_trace_pc_guard() comdat
|