mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-21 20:12:56 +02:00
3c8119efc1
Summary: llvm-symbolizer would originally report symbols that belonged to an invalid object file section. Specifically the case where: `*Symbol.getSection() == ObjFile.section_end()` This patch prevents the Symbolizer from collecting symbols that belong to invalid sections. The test (from PR40591) introduces a case where two symbols have address 0, one symbol is defined, 'foo', and the other is not defined, 'bar'. This patch will cause the Symbolizer to keep 'foo' and ignore 'bar'. As a side note, the logic for adding symbols to the Symbolizer's store (`SymbolizableObjectFile::addSymbol`) replaces symbols with the same <address, size> pair. At some point that logic should be revisited as in the aforementioned case, 'bar' was overwriting 'foo' in the Symbolizer's store, and 'foo' was forgotten. This fixes PR40591 Reviewers: jhenderson, rupprecht Reviewed By: rupprecht Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D58146 llvm-svn: 354083 |
||
|---|---|---|
| .. | ||
| Inputs | ||
| pdb | ||
| adjust-vma.s | ||
| basenames.s | ||
| basic.s | ||
| coff-dwarf.test | ||
| coff-exports.test | ||
| demangle.s | ||
| dsym.test | ||
| dwo.test | ||
| fat.test | ||
| fission-ranges.test | ||
| flag-grouping.test | ||
| functions.s | ||
| ignore-undefined-symbols.s | ||
| invalid-input-address.test | ||
| padding-x86_64.ll | ||
| ppc64.test | ||
| print_context.c | ||
| space-in-path.s | ||
| split-debug.test | ||
| split-dwarf-addr-object-relocation.test | ||
| split-dwarf-dwp.test | ||
| split-dwarf-multiple-cu.test | ||
| split-dwarf.test | ||
| sym-verbose.test | ||
| sym.test | ||