mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
af578b1205
Using various methods, BasicAA tries to determine whether two GetElementPtr memory locations alias when its base pointers are known to be equal. When none of its heuristics are applicable, it falls back to PartialAlias to, according to a comment, protect TBAA making a wrong decision in case of unions and malloc. PartialAlias is not correct, because a PartialAlias result implies that some, but not all, bytes overlap which is not necessarily the case here. AAResults returns the first analysis result that is not MayAlias. BasicAA is always the first alias analysis. When it returns PartialAlias, no other analysis is queried to give a more exact result (which was the intention of returning PartialAlias instead of MayAlias). For instance, ScopedAA could return a more accurate result. The PartialAlias hack was introduced in r131781 (and re-applied in r132632 after some reverts) to fix llvm.org/PR9971 where TBAA returns a wrong NoAlias result due to a union. A test case for the malloc case mentioned in the comment was not provided and I don't think it is affected since it returns an omnipotent char anyway. Since r303851 (https://reviews.llvm.org/D33328) clang does emit specific TBAA for unions anymore (but "omnipotent char" instead). Hence, the PartialAlias workaround is not required anymore. This patch passes the test-suite and check-llvm/check-clang of a self-hoisted build on x64. Reviewed By: hfinkel Differential Revision: https://reviews.llvm.org/D34318 llvm-svn: 305938
23 lines
718 B
LLVM
23 lines
718 B
LLVM
; RUN: opt < %s -basicaa -aa-eval -print-all-alias-modref-info -disable-output 2>&1 | FileCheck %s
|
|
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
; CHECK: Function: foo
|
|
; CHECK: MayAlias: i32* %Ipointer, i32* %Jpointer
|
|
; CHECK: 9 no alias responses
|
|
; CHECK: 6 may alias responses
|
|
|
|
define void @foo(i32* noalias %p, i32* noalias %q, i32 %i, i32 %j) {
|
|
%Ipointer = getelementptr i32, i32* %p, i32 %i
|
|
%qi = getelementptr i32, i32* %q, i32 %i
|
|
%Jpointer = getelementptr i32, i32* %p, i32 %j
|
|
%qj = getelementptr i32, i32* %q, i32 %j
|
|
store i32 0, i32* %p
|
|
store i32 0, i32* %Ipointer
|
|
store i32 0, i32* %Jpointer
|
|
store i32 0, i32* %q
|
|
store i32 0, i32* %qi
|
|
store i32 0, i32* %qj
|
|
ret void
|
|
}
|