mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 03:02:36 +01:00
ef2523a622
Summary: In the test case, the machine scheduler moves a dead write to a subreg up into the middle of a segment of the overall reg's live range, where the segment had liveness only for other subregs in the reg. handleMoveUp created an invalid live range, causing an assert a bit later. This commit fixes it to handle that situation. The segment is split in two at the insertion point, and the part after the split, and any subsequent segments up to the old position, are changed to be defined by the moved def. V2: Better test. Subscribers: MatzeB, nhaehnle, llvm-commits Differential Revision: https://reviews.llvm.org/D43478 Change-Id: Ibc42445ddca84e79ad1f616401015d22bc63832e llvm-svn: 326087
428 lines
12 KiB
C++
428 lines
12 KiB
C++
#include "llvm/ADT/STLExtras.h"
|
|
#include "llvm/CodeGen/LiveIntervals.h"
|
|
#include "llvm/CodeGen/MIRParser/MIRParser.h"
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
#include "llvm/CodeGen/MachineModuleInfo.h"
|
|
#include "llvm/CodeGen/TargetRegisterInfo.h"
|
|
#include "llvm/IR/LegacyPassManager.h"
|
|
#include "llvm/Support/MemoryBuffer.h"
|
|
#include "llvm/Support/SourceMgr.h"
|
|
#include "llvm/Support/TargetRegistry.h"
|
|
#include "llvm/Support/TargetSelect.h"
|
|
#include "llvm/Target/TargetMachine.h"
|
|
#include "llvm/Target/TargetOptions.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace llvm {
|
|
void initializeTestPassPass(PassRegistry &);
|
|
}
|
|
|
|
namespace {
|
|
|
|
void initLLVM() {
|
|
InitializeAllTargets();
|
|
InitializeAllTargetMCs();
|
|
InitializeAllAsmPrinters();
|
|
InitializeAllAsmParsers();
|
|
|
|
PassRegistry *Registry = PassRegistry::getPassRegistry();
|
|
initializeCore(*Registry);
|
|
initializeCodeGen(*Registry);
|
|
}
|
|
|
|
/// Create a TargetMachine. As we lack a dedicated always available target for
|
|
/// unittests, we go for "AMDGPU" to be able to test normal and subregister
|
|
/// liveranges.
|
|
std::unique_ptr<TargetMachine> createTargetMachine() {
|
|
Triple TargetTriple("amdgcn--");
|
|
std::string Error;
|
|
const Target *T = TargetRegistry::lookupTarget("", TargetTriple, Error);
|
|
if (!T)
|
|
return nullptr;
|
|
|
|
TargetOptions Options;
|
|
return std::unique_ptr<TargetMachine>(T->createTargetMachine(
|
|
"AMDGPU", "", "", Options, None, None, CodeGenOpt::Aggressive));
|
|
}
|
|
|
|
std::unique_ptr<Module> parseMIR(LLVMContext &Context,
|
|
legacy::PassManagerBase &PM, std::unique_ptr<MIRParser> &MIR,
|
|
const TargetMachine &TM, StringRef MIRCode, const char *FuncName) {
|
|
SMDiagnostic Diagnostic;
|
|
std::unique_ptr<MemoryBuffer> MBuffer = MemoryBuffer::getMemBuffer(MIRCode);
|
|
MIR = createMIRParser(std::move(MBuffer), Context);
|
|
if (!MIR)
|
|
return nullptr;
|
|
|
|
std::unique_ptr<Module> M = MIR->parseIRModule();
|
|
if (!M)
|
|
return nullptr;
|
|
|
|
M->setDataLayout(TM.createDataLayout());
|
|
|
|
MachineModuleInfo *MMI = new MachineModuleInfo(&TM);
|
|
if (MIR->parseMachineFunctions(*M, *MMI))
|
|
return nullptr;
|
|
PM.add(MMI);
|
|
|
|
return M;
|
|
}
|
|
|
|
typedef std::function<void(MachineFunction&,LiveIntervals&)> LiveIntervalTest;
|
|
|
|
struct TestPass : public MachineFunctionPass {
|
|
static char ID;
|
|
TestPass() : MachineFunctionPass(ID) {
|
|
// We should never call this but always use PM.add(new TestPass(...))
|
|
abort();
|
|
}
|
|
TestPass(LiveIntervalTest T) : MachineFunctionPass(ID), T(T) {
|
|
initializeTestPassPass(*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override {
|
|
LiveIntervals &LIS = getAnalysis<LiveIntervals>();
|
|
T(MF, LIS);
|
|
EXPECT_TRUE(MF.verify(this));
|
|
return true;
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.setPreservesAll();
|
|
AU.addRequired<LiveIntervals>();
|
|
AU.addPreserved<LiveIntervals>();
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
private:
|
|
LiveIntervalTest T;
|
|
};
|
|
|
|
static MachineInstr &getMI(MachineFunction &MF, unsigned At,
|
|
unsigned BlockNum) {
|
|
MachineBasicBlock &MBB = *MF.getBlockNumbered(BlockNum);
|
|
|
|
unsigned I = 0;
|
|
for (MachineInstr &MI : MBB) {
|
|
if (I == At)
|
|
return MI;
|
|
++I;
|
|
}
|
|
llvm_unreachable("Instruction not found");
|
|
}
|
|
|
|
/**
|
|
* Move instruction number \p From in front of instruction number \p To and
|
|
* update affected liveness intervals with LiveIntervalAnalysis::handleMove().
|
|
*/
|
|
static void testHandleMove(MachineFunction &MF, LiveIntervals &LIS,
|
|
unsigned From, unsigned To, unsigned BlockNum = 0) {
|
|
MachineInstr &FromInstr = getMI(MF, From, BlockNum);
|
|
MachineInstr &ToInstr = getMI(MF, To, BlockNum);
|
|
|
|
MachineBasicBlock &MBB = *FromInstr.getParent();
|
|
MBB.splice(ToInstr.getIterator(), &MBB, FromInstr.getIterator());
|
|
LIS.handleMove(FromInstr, true);
|
|
}
|
|
|
|
static void liveIntervalTest(StringRef MIRFunc, LiveIntervalTest T) {
|
|
LLVMContext Context;
|
|
std::unique_ptr<TargetMachine> TM = createTargetMachine();
|
|
// This test is designed for the X86 backend; stop if it is not available.
|
|
if (!TM)
|
|
return;
|
|
|
|
legacy::PassManager PM;
|
|
|
|
SmallString<160> S;
|
|
StringRef MIRString = (Twine(R"MIR(
|
|
---
|
|
...
|
|
name: func
|
|
registers:
|
|
- { id: 0, class: sreg_64 }
|
|
body: |
|
|
bb.0:
|
|
)MIR") + Twine(MIRFunc) + Twine("...\n")).toNullTerminatedStringRef(S);
|
|
std::unique_ptr<MIRParser> MIR;
|
|
std::unique_ptr<Module> M = parseMIR(Context, PM, MIR, *TM, MIRString,
|
|
"func");
|
|
ASSERT_TRUE(M);
|
|
|
|
PM.add(new TestPass(T));
|
|
|
|
PM.run(*M);
|
|
}
|
|
|
|
} // End of anonymous namespace.
|
|
|
|
char TestPass::ID = 0;
|
|
INITIALIZE_PASS(TestPass, "testpass", "testpass", false, false)
|
|
|
|
TEST(LiveIntervalTest, MoveUpDef) {
|
|
// Value defined.
|
|
liveIntervalTest(R"MIR(
|
|
S_NOP 0
|
|
S_NOP 0
|
|
early-clobber %0 = IMPLICIT_DEF
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 2, 1);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveUpRedef) {
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
S_NOP 0
|
|
%0 = IMPLICIT_DEF implicit %0(tied-def 0)
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 2, 1);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveUpEarlyDef) {
|
|
liveIntervalTest(R"MIR(
|
|
S_NOP 0
|
|
S_NOP 0
|
|
early-clobber %0 = IMPLICIT_DEF
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 2, 1);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveUpEarlyRedef) {
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
S_NOP 0
|
|
early-clobber %0 = IMPLICIT_DEF implicit %0(tied-def 0)
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 2, 1);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveUpKill) {
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
S_NOP 0
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 2, 1);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveUpKillFollowing) {
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
S_NOP 0
|
|
S_NOP 0, implicit %0
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 2, 1);
|
|
});
|
|
}
|
|
|
|
// TODO: Construct a situation where we have intervals following a hole
|
|
// while still having connected components.
|
|
|
|
TEST(LiveIntervalTest, MoveDownDef) {
|
|
// Value defined.
|
|
liveIntervalTest(R"MIR(
|
|
S_NOP 0
|
|
early-clobber %0 = IMPLICIT_DEF
|
|
S_NOP 0
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 1, 2);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveDownRedef) {
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
%0 = IMPLICIT_DEF implicit %0(tied-def 0)
|
|
S_NOP 0
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 1, 2);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveDownEarlyDef) {
|
|
liveIntervalTest(R"MIR(
|
|
S_NOP 0
|
|
early-clobber %0 = IMPLICIT_DEF
|
|
S_NOP 0
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 1, 2);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveDownEarlyRedef) {
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
early-clobber %0 = IMPLICIT_DEF implicit %0(tied-def 0)
|
|
S_NOP 0
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 1, 2);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveDownKill) {
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
S_NOP 0, implicit %0
|
|
S_NOP 0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 1, 2);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveDownKillFollowing) {
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
S_NOP 0
|
|
S_NOP 0, implicit %0
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 1, 2);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveUndefUse) {
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
S_NOP 0, implicit undef %0
|
|
S_NOP 0, implicit %0
|
|
S_NOP 0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 1, 3);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveUpValNos) {
|
|
// handleMoveUp() had a bug where it would reuse the value number of the
|
|
// destination segment, even though we have no guarntee that this valno wasn't
|
|
// used in other segments.
|
|
liveIntervalTest(R"MIR(
|
|
successors: %bb.1, %bb.2
|
|
%0 = IMPLICIT_DEF
|
|
S_CBRANCH_VCCNZ %bb.2, implicit undef $vcc
|
|
S_BRANCH %bb.1
|
|
bb.2:
|
|
S_NOP 0, implicit %0
|
|
bb.1:
|
|
successors: %bb.2
|
|
%0 = IMPLICIT_DEF implicit %0(tied-def 0)
|
|
%0 = IMPLICIT_DEF implicit %0(tied-def 0)
|
|
%0 = IMPLICIT_DEF implicit %0(tied-def 0)
|
|
S_BRANCH %bb.2
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 2, 0, 2);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveOverUndefUse0) {
|
|
// findLastUseBefore() used by handleMoveUp() must ignore undef operands.
|
|
liveIntervalTest(R"MIR(
|
|
%0 = IMPLICIT_DEF
|
|
S_NOP 0
|
|
S_NOP 0, implicit undef %0
|
|
%0 = IMPLICIT_DEF implicit %0(tied-def 0)
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 3, 1);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, MoveOverUndefUse1) {
|
|
// findLastUseBefore() used by handleMoveUp() must ignore undef operands.
|
|
liveIntervalTest(R"MIR(
|
|
$sgpr0 = IMPLICIT_DEF
|
|
S_NOP 0
|
|
S_NOP 0, implicit undef $sgpr0
|
|
$sgpr0 = IMPLICIT_DEF implicit $sgpr0(tied-def 0)
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 3, 1);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, SubRegMoveDown) {
|
|
// Subregister ranges can have holes inside a basic block. Check for a
|
|
// movement of the form 32->150 in a liverange [16, 32) [100,200).
|
|
liveIntervalTest(R"MIR(
|
|
successors: %bb.1, %bb.2
|
|
%0 = IMPLICIT_DEF
|
|
S_CBRANCH_VCCNZ %bb.2, implicit undef $vcc
|
|
S_BRANCH %bb.1
|
|
bb.2:
|
|
successors: %bb.1
|
|
S_NOP 0, implicit %0.sub0
|
|
S_NOP 0, implicit %0.sub1
|
|
S_NOP 0
|
|
undef %0.sub0 = IMPLICIT_DEF
|
|
%0.sub1 = IMPLICIT_DEF
|
|
bb.1:
|
|
S_NOP 0, implicit %0
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
// Scheduler behaviour: Clear def,read-undef flag and move.
|
|
MachineInstr &MI = getMI(MF, 3, /*BlockNum=*/1);
|
|
MI.getOperand(0).setIsUndef(false);
|
|
testHandleMove(MF, LIS, 1, 4, /*BlockNum=*/1);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, SubRegMoveUp) {
|
|
// handleMoveUp had a bug not updating valno of segment incoming to bb.2
|
|
// after swapping subreg definitions.
|
|
liveIntervalTest(R"MIR(
|
|
successors: %bb.1, %bb.2
|
|
undef %0.sub0 = IMPLICIT_DEF
|
|
%0.sub1 = IMPLICIT_DEF
|
|
S_CBRANCH_VCCNZ %bb.2, implicit undef $vcc
|
|
S_BRANCH %bb.1
|
|
bb.1:
|
|
S_NOP 0, implicit %0.sub1
|
|
bb.2:
|
|
S_NOP 0, implicit %0.sub1
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 1, 0);
|
|
});
|
|
}
|
|
|
|
TEST(LiveIntervalTest, DeadSubRegMoveUp) {
|
|
// handleMoveUp had a bug where moving a dead subreg def into the middle of
|
|
// an earlier segment resulted in an invalid live range.
|
|
liveIntervalTest(R"MIR(
|
|
undef %125.sub0:vreg_128 = V_MOV_B32_e32 0, implicit $exec
|
|
%125.sub1:vreg_128 = COPY %125.sub0
|
|
%125.sub2:vreg_128 = COPY %125.sub0
|
|
undef %51.sub0:vreg_128 = V_MOV_B32_e32 898625526, implicit $exec
|
|
%51.sub1:vreg_128 = COPY %51.sub0
|
|
%51.sub2:vreg_128 = COPY %51.sub0
|
|
%52:vgpr_32 = V_MOV_B32_e32 986714345, implicit $exec
|
|
%54:vgpr_32 = V_MOV_B32_e32 1742342378, implicit $exec
|
|
%57:vgpr_32 = V_MOV_B32_e32 3168768712, implicit $exec
|
|
%59:vgpr_32 = V_MOV_B32_e32 1039972644, implicit $exec
|
|
%60:vgpr_32 = V_MAD_F32 0, %52, 0, undef %61:vgpr_32, 0, %59, 0, 0, implicit $exec
|
|
%63:vgpr_32 = V_ADD_F32_e32 %51.sub3, undef %64:vgpr_32, implicit $exec
|
|
dead %66:vgpr_32 = V_MAD_F32 0, %60, 0, undef %67:vgpr_32, 0, %125.sub2, 0, 0, implicit $exec
|
|
undef %124.sub1:vreg_128 = V_MAD_F32 0, %57, 0, undef %70:vgpr_32, 0, %125.sub1, 0, 0, implicit $exec
|
|
%124.sub0:vreg_128 = V_MAD_F32 0, %54, 0, undef %73:vgpr_32, 0, %125.sub0, 0, 0, implicit $exec
|
|
dead undef %125.sub3:vreg_128 = V_MAC_F32_e32 %63, undef %76:vgpr_32, %125.sub3, implicit $exec
|
|
)MIR", [](MachineFunction &MF, LiveIntervals &LIS) {
|
|
testHandleMove(MF, LIS, 15, 12);
|
|
});
|
|
}
|
|
|
|
int main(int argc, char **argv) {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
initLLVM();
|
|
return RUN_ALL_TESTS();
|
|
}
|