mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-20 03:23:01 +02:00
5f415496c7
I tried to run llvm-pdbdump on a very large (~1.5GB) PDB to try and identify show-stopping performance problems. This patch addresses the first such problem. When loading the DBI stream, before anyone has even tried to access a single record, we build an in memory map of every source file for every module. In the particular PDB I was using, this was over 85 million files. Specifically, the complexity is O(m*n) where m is the number of modules and n is the average number of source files (including headers) per module. The whole reason for doing this was so that we could have constant time access to any module and any of its source file lists. However, we can still get O(1) access to the source file list for a given module with a simple O(m) precomputation, and access to the list of modules is already O(1) anyway. So this patches reduces the O(m*n) up-front precomputation to an O(m) one, where n is ~6,500 and n*m is about 85 million in my pathological test case. Differential Revision: https://reviews.llvm.org/D32870 llvm-svn: 302205
42 lines
1.2 KiB
C++
42 lines
1.2 KiB
C++
//==- NativeEnumModules.h - Native Module Enumerator impl --------*- C++ -*-==//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_DEBUGINFO_PDB_NATIVE_NATIVEENUMMODULES_H
|
|
#define LLVM_DEBUGINFO_PDB_NATIVE_NATIVEENUMMODULES_H
|
|
|
|
#include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"
|
|
#include "llvm/DebugInfo/PDB/Native/DbiModuleDescriptor.h"
|
|
#include "llvm/DebugInfo/PDB/PDBSymbol.h"
|
|
namespace llvm {
|
|
namespace pdb {
|
|
|
|
class DbiModuleList;
|
|
class NativeSession;
|
|
|
|
class NativeEnumModules : public IPDBEnumChildren<PDBSymbol> {
|
|
public:
|
|
NativeEnumModules(NativeSession &Session, const DbiModuleList &Modules,
|
|
uint32_t Index = 0);
|
|
|
|
uint32_t getChildCount() const override;
|
|
std::unique_ptr<PDBSymbol> getChildAtIndex(uint32_t Index) const override;
|
|
std::unique_ptr<PDBSymbol> getNext() override;
|
|
void reset() override;
|
|
NativeEnumModules *clone() const override;
|
|
|
|
private:
|
|
NativeSession &Session;
|
|
const DbiModuleList &Modules;
|
|
uint32_t Index;
|
|
};
|
|
}
|
|
}
|
|
|
|
#endif
|