mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-24 05:23:45 +02:00
47833cff03
This addresses PR26055 LiveDebugValues is very slow.
Contrary to the old LiveDebugVariables pass LiveDebugValues currently
doesn't look at the lexical scopes before inserting a DBG_VALUE
intrinsic. This means that we often propagate DBG_VALUEs much further
down than necessary. This is especially noticeable in large C++
functions with many inlined method calls that all use the same
"this"-pointer.
For example, in the following code it makes no sense to propagate the
inlined variable a from the first inlined call to f() into any of the
subsequent basic blocks, because the variable will always be out of
scope:
void sink(int a);
void __attribute((always_inline)) f(int a) { sink(a); }
void foo(int i) {
f(i);
if (i)
f(i);
f(i);
}
This patch reuses the LexicalScopes infrastructure we have for
LiveDebugVariables to take this into account.
The effect on compile time and memory consumption is quite noticeable:
I tested a benchmark that is a large C++ source with an enormous
amount of inlined "this"-pointers that would previously eat >24GiB
(most of them for DBG_VALUE intrinsics) and whose compile time was
dominated by LiveDebugValues. With this patch applied the memory
consumption is 1GiB and 1.7% of the time is spent in LiveDebugValues.
https://reviews.llvm.org/D24994
Thanks to Daniel Berlin and Keith Walker for reviewing!
llvm-svn: 282611
200 lines
8.8 KiB
LLVM
200 lines
8.8 KiB
LLVM
; RUN: llc -split-dwarf=Enable -O0 %s -mtriple=x86_64-unknown-linux-gnu -filetype=obj -o %t
|
|
; RUN: llvm-dwarfdump %t | FileCheck %s
|
|
; RUN: llvm-objdump -h %t | FileCheck --check-prefix=HDR %s
|
|
|
|
; CHECK: .debug_info contents:
|
|
; CHECK: DW_TAG_compile_unit
|
|
; CHECK-NEXT: DW_AT_stmt_list
|
|
; CHECK-NEXT: DW_AT_GNU_dwo_name
|
|
; CHECK-NEXT: DW_AT_comp_dir
|
|
; CHECK-NEXT: DW_AT_GNU_dwo_id
|
|
; CHECK-NEXT: DW_AT_GNU_addr_base [DW_FORM_sec_offset] (0x00000000)
|
|
|
|
|
|
; CHECK: .debug_info.dwo contents:
|
|
; CHECK: DW_AT_location [DW_FORM_sec_offset] ([[A:0x[0-9a-z]*]])
|
|
; CHECK: DW_AT_location [DW_FORM_sec_offset] ([[E:0x[0-9a-z]*]])
|
|
; CHECK: DW_AT_location [DW_FORM_sec_offset] ([[B:0x[0-9a-z]*]])
|
|
; CHECK: DW_AT_location [DW_FORM_sec_offset] ([[D:0x[0-9a-z]*]])
|
|
; CHECK: DW_AT_ranges [DW_FORM_sec_offset] (0x00000000
|
|
; CHECK: .debug_loc contents:
|
|
; CHECK-NOT: Beginning address offset
|
|
; CHECK: .debug_loc.dwo contents:
|
|
|
|
; Don't assume these locations are entirely correct - feel free to update them
|
|
; if they've changed due to a bugfix, change in register allocation, etc.
|
|
|
|
; CHECK: [[A]]: Beginning address index: 2
|
|
; CHECK-NEXT: Length: 169
|
|
; CHECK-NEXT: Location description: 11 00
|
|
; CHECK-NEXT: {{^$}}
|
|
; CHECK-NEXT: Beginning address index: 3
|
|
; CHECK-NEXT: Length: 25
|
|
; CHECK-NEXT: Location description: 50 93 04
|
|
; CHECK: [[E]]: Beginning address index: 4
|
|
; CHECK-NEXT: Length: 19
|
|
; CHECK-NEXT: Location description: 50 93 04
|
|
; CHECK: [[B]]: Beginning address index: 5
|
|
; CHECK-NEXT: Length: 17
|
|
; CHECK-NEXT: Location description: 50 93 04
|
|
; CHECK: [[D]]: Beginning address index: 6
|
|
; CHECK-NEXT: Length: 17
|
|
; CHECK-NEXT: Location description: 50 93 04
|
|
|
|
; Make sure we don't produce any relocations in any .dwo section (though in particular, debug_info.dwo)
|
|
; HDR-NOT: .rela.{{.*}}.dwo
|
|
|
|
; Make sure we have enough stuff in the debug_addr to cover the address indexes
|
|
; (6 is the last index in debug_loc.dwo, making 7 entries of 8 bytes each, 7 * 8
|
|
; == 56 base 10 == 38 base 16)
|
|
|
|
; HDR: .debug_addr 00000038
|
|
; HDR-NOT: .rela.{{.*}}.dwo
|
|
|
|
; From the code:
|
|
|
|
; extern int c;
|
|
; static void foo (int p)
|
|
; {
|
|
; int a, b;
|
|
; unsigned int d, e;
|
|
|
|
; for (a = 0; a < 30; a++)
|
|
; for (d = 0; d < 30; d++)
|
|
; for (b = 0; b < 30; b++)
|
|
; for (e = 0; e < 30; e++)
|
|
; {
|
|
; int *w = &c;
|
|
; *w &= p;
|
|
; }
|
|
; }
|
|
|
|
; void
|
|
; bar ()
|
|
; {
|
|
; foo (1);
|
|
; }
|
|
|
|
; compiled with:
|
|
|
|
; clang -g -S -gsplit-dwarf -O1 small.c
|
|
|
|
@c = external global i32
|
|
|
|
; Function Attrs: nounwind uwtable
|
|
define void @bar() #0 !dbg !4 {
|
|
entry:
|
|
tail call fastcc void @foo(), !dbg !27
|
|
ret void, !dbg !28
|
|
}
|
|
|
|
; Function Attrs: nounwind uwtable
|
|
define internal fastcc void @foo() #0 !dbg !8 {
|
|
entry:
|
|
tail call void @llvm.dbg.value(metadata i32 1, i64 0, metadata !13, metadata !DIExpression()), !dbg !30
|
|
tail call void @llvm.dbg.value(metadata i32 0, i64 0, metadata !14, metadata !DIExpression()), !dbg !31
|
|
%c.promoted9 = load i32, i32* @c, align 4, !dbg !32, !tbaa !33
|
|
br label %for.cond1.preheader, !dbg !31
|
|
|
|
for.cond1.preheader: ; preds = %for.inc16, %entry
|
|
%and.lcssa.lcssa.lcssa10 = phi i32 [ %c.promoted9, %entry ], [ %and, %for.inc16 ]
|
|
%a.08 = phi i32 [ 0, %entry ], [ %inc17, %for.inc16 ]
|
|
br label %for.cond4.preheader, !dbg !37
|
|
|
|
for.cond4.preheader: ; preds = %for.inc13, %for.cond1.preheader
|
|
%and.lcssa.lcssa7 = phi i32 [ %and.lcssa.lcssa.lcssa10, %for.cond1.preheader ], [ %and, %for.inc13 ]
|
|
%d.06 = phi i32 [ 0, %for.cond1.preheader ], [ %inc14, %for.inc13 ]
|
|
br label %for.cond7.preheader, !dbg !38
|
|
|
|
for.cond7.preheader: ; preds = %for.inc10, %for.cond4.preheader
|
|
%and.lcssa5 = phi i32 [ %and.lcssa.lcssa7, %for.cond4.preheader ], [ %and, %for.inc10 ]
|
|
%b.03 = phi i32 [ 0, %for.cond4.preheader ], [ %inc11, %for.inc10 ]
|
|
br label %for.body9, !dbg !39
|
|
|
|
for.body9: ; preds = %for.body9, %for.cond7.preheader
|
|
%and2 = phi i32 [ %and.lcssa5, %for.cond7.preheader ], [ %and, %for.body9 ], !dbg !40
|
|
%e.01 = phi i32 [ 0, %for.cond7.preheader ], [ %inc, %for.body9 ]
|
|
tail call void @llvm.dbg.value(metadata i32* @c, i64 0, metadata !19, metadata !DIExpression()), !dbg !40
|
|
%and = and i32 %and2, 1, !dbg !32
|
|
%inc = add i32 %e.01, 1, !dbg !39
|
|
tail call void @llvm.dbg.value(metadata i32 %inc, i64 0, metadata !18, metadata !DIExpression()), !dbg !39
|
|
%exitcond = icmp eq i32 %inc, 30, !dbg !39
|
|
br i1 %exitcond, label %for.inc10, label %for.body9, !dbg !39
|
|
|
|
for.inc10: ; preds = %for.body9
|
|
%inc11 = add nsw i32 %b.03, 1, !dbg !38
|
|
tail call void @llvm.dbg.value(metadata i32 %inc11, i64 0, metadata !15, metadata !DIExpression()), !dbg !38
|
|
%exitcond11 = icmp eq i32 %inc11, 30, !dbg !38
|
|
br i1 %exitcond11, label %for.inc13, label %for.cond7.preheader, !dbg !38
|
|
|
|
for.inc13: ; preds = %for.inc10
|
|
%inc14 = add i32 %d.06, 1, !dbg !37
|
|
tail call void @llvm.dbg.value(metadata i32 %inc14, i64 0, metadata !16, metadata !DIExpression()), !dbg !37
|
|
%exitcond12 = icmp eq i32 %inc14, 30, !dbg !37
|
|
br i1 %exitcond12, label %for.inc16, label %for.cond4.preheader, !dbg !37
|
|
|
|
for.inc16: ; preds = %for.inc13
|
|
%inc17 = add nsw i32 %a.08, 1, !dbg !31
|
|
tail call void @llvm.dbg.value(metadata i32 %inc17, i64 0, metadata !14, metadata !DIExpression()), !dbg !31
|
|
%exitcond13 = icmp eq i32 %inc17, 30, !dbg !31
|
|
br i1 %exitcond13, label %for.end18, label %for.cond1.preheader, !dbg !31
|
|
|
|
for.end18: ; preds = %for.inc16
|
|
store i32 %and, i32* @c, align 4, !dbg !32, !tbaa !33
|
|
ret void, !dbg !42
|
|
}
|
|
|
|
; Function Attrs: nounwind readnone
|
|
declare void @llvm.dbg.value(metadata, i64, metadata, metadata) #1
|
|
|
|
attributes #0 = { nounwind uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
|
|
attributes #1 = { nounwind readnone }
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!26, !43}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C99, producer: "clang version 3.4 (trunk 191700) (llvm/trunk 191710)", isOptimized: true, splitDebugFilename: "small.dwo", emissionKind: FullDebug, file: !1, enums: !2, retainedTypes: !2, globals: !2, imports: !2)
|
|
!1 = !DIFile(filename: "small.c", directory: "/usr/local/google/home/echristo/tmp")
|
|
!2 = !{}
|
|
!4 = distinct !DISubprogram(name: "bar", line: 18, isLocal: false, isDefinition: true, virtualIndex: 6, isOptimized: true, unit: !0, scopeLine: 19, file: !1, scope: !5, type: !6, variables: !2)
|
|
!5 = !DIFile(filename: "small.c", directory: "/usr/local/google/home/echristo/tmp")
|
|
!6 = !DISubroutineType(types: !7)
|
|
!7 = !{null}
|
|
!8 = distinct !DISubprogram(name: "foo", line: 2, isLocal: true, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: true, unit: !0, scopeLine: 3, file: !1, scope: !5, type: !9, variables: !12)
|
|
!9 = !DISubroutineType(types: !10)
|
|
!10 = !{null, !11}
|
|
!11 = !DIBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!12 = !{!13, !14, !15, !16, !18, !19}
|
|
!13 = !DILocalVariable(name: "p", line: 2, arg: 1, scope: !8, file: !5, type: !11)
|
|
!14 = !DILocalVariable(name: "a", line: 4, scope: !8, file: !5, type: !11)
|
|
!15 = !DILocalVariable(name: "b", line: 4, scope: !8, file: !5, type: !11)
|
|
!16 = !DILocalVariable(name: "d", line: 5, scope: !8, file: !5, type: !17)
|
|
!17 = !DIBasicType(tag: DW_TAG_base_type, name: "unsigned int", size: 32, align: 32, encoding: DW_ATE_unsigned)
|
|
!18 = !DILocalVariable(name: "e", line: 5, scope: !8, file: !5, type: !17)
|
|
!19 = !DILocalVariable(name: "w", line: 12, scope: !20, file: !5, type: !25)
|
|
!20 = distinct !DILexicalBlock(line: 11, column: 0, file: !1, scope: !21)
|
|
!21 = distinct !DILexicalBlock(line: 10, column: 0, file: !1, scope: !22)
|
|
!22 = distinct !DILexicalBlock(line: 9, column: 0, file: !1, scope: !23)
|
|
!23 = distinct !DILexicalBlock(line: 8, column: 0, file: !1, scope: !24)
|
|
!24 = distinct !DILexicalBlock(line: 7, column: 0, file: !1, scope: !8)
|
|
!25 = !DIDerivedType(tag: DW_TAG_pointer_type, size: 64, align: 64, baseType: !11)
|
|
!26 = !{i32 2, !"Dwarf Version", i32 4}
|
|
!27 = !DILocation(line: 20, scope: !4)
|
|
!28 = !DILocation(line: 21, scope: !4)
|
|
!29 = !{i32 1}
|
|
!30 = !DILocation(line: 2, scope: !8)
|
|
!31 = !DILocation(line: 7, scope: !24)
|
|
!32 = !DILocation(line: 13, scope: !20)
|
|
!33 = !{!34, !34, i64 0}
|
|
!34 = !{!"int", !35, i64 0}
|
|
!35 = !{!"omnipotent char", !36, i64 0}
|
|
!36 = !{!"Simple C/C++ TBAA"}
|
|
!37 = !DILocation(line: 8, scope: !23)
|
|
!38 = !DILocation(line: 9, scope: !22)
|
|
!39 = !DILocation(line: 10, scope: !21)
|
|
!40 = !DILocation(line: 12, scope: !20)
|
|
!41 = !{i32* @c}
|
|
!42 = !DILocation(line: 15, scope: !8)
|
|
!43 = !{i32 1, !"Debug Info Version", i32 3}
|
|
!44 = !{i32 0}
|