mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-24 05:23:45 +02:00
57907269da
so we can stop using DW_OP_bit_piece with the wrong semantics. The entire back story can be found here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20161114/405934.html The gist is that in LLVM we've been misinterpreting DW_OP_bit_piece's offset field to mean the offset into the source variable rather than the offset into the location at the top the DWARF expression stack. In order to be able to fix this in a subsequent patch, this patch introduces a dedicated DW_OP_LLVM_fragment operation with the semantics that we used to apply to DW_OP_bit_piece, which is what we actually need while inside of LLVM. This patch is complete with a bitcode upgrade for expressions using the old format. It does not yet fix the DWARF backend to use DW_OP_bit_piece correctly. Implementation note: We discussed several options for implementing this, including reserving a dedicated field in DIExpression for the fragment size and offset, but using an custom operator at the end of the expression works just fine and is more efficient because we then only pay for it when we need it. Differential Revision: https://reviews.llvm.org/D27361 rdar://problem/29335809 llvm-svn: 288683
63 lines
2.7 KiB
LLVM
63 lines
2.7 KiB
LLVM
; RUN: opt %s -sroa -verify -S -o - | FileCheck %s
|
|
; ModuleID = 'test.c'
|
|
; Test that SROA updates the debug info correctly if an alloca was rewritten but
|
|
; not partitioned into multiple allocas.
|
|
;
|
|
; CHECK: call void @llvm.dbg.value(metadata float %s.coerce, i64 0, metadata ![[VAR:[0-9]+]], metadata ![[EXPR:[0-9]+]])
|
|
; CHECK: ![[VAR]] = !DILocalVariable(name: "s",{{.*}} line: 3,
|
|
; CHECK: ![[EXPR]] = !DIExpression(
|
|
; CHECK-NOT: DW_OP_LLVM_fragment
|
|
|
|
;
|
|
; struct S { float f; };
|
|
;
|
|
; float foo(struct S s) {
|
|
; return s.f;
|
|
; }
|
|
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-apple-macosx10.10.0"
|
|
|
|
%struct.S = type { float }
|
|
|
|
; Function Attrs: nounwind ssp uwtable
|
|
define float @foo(float %s.coerce) #0 !dbg !4 {
|
|
entry:
|
|
%s = alloca %struct.S, align 4
|
|
%coerce.dive = getelementptr %struct.S, %struct.S* %s, i32 0, i32 0
|
|
store float %s.coerce, float* %coerce.dive, align 1
|
|
call void @llvm.dbg.declare(metadata %struct.S* %s, metadata !16, metadata !17), !dbg !18
|
|
%f = getelementptr inbounds %struct.S, %struct.S* %s, i32 0, i32 0, !dbg !19
|
|
%0 = load float, float* %f, align 4, !dbg !19
|
|
ret float %0, !dbg !19
|
|
}
|
|
|
|
; Function Attrs: nounwind readnone
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) #1
|
|
|
|
attributes #0 = { nounwind ssp uwtable }
|
|
attributes #1 = { nounwind readnone }
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!12, !13, !14}
|
|
!llvm.ident = !{!15}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C99, producer: "clang version 3.6.0 ", isOptimized: false, emissionKind: FullDebug, file: !1, enums: !2, retainedTypes: !2, globals: !2, imports: !2)
|
|
!1 = !DIFile(filename: "test.c", directory: "/Volumes/Data/llvm/_build.ninja.debug")
|
|
!2 = !{}
|
|
!4 = distinct !DISubprogram(name: "foo", line: 3, isLocal: false, isDefinition: true, flags: DIFlagPrototyped, isOptimized: false, unit: !0, scopeLine: 3, file: !1, scope: !5, type: !6, variables: !2)
|
|
!5 = !DIFile(filename: "test.c", directory: "/Volumes/Data/llvm/_build.ninja.debug")
|
|
!6 = !DISubroutineType(types: !7)
|
|
!7 = !{!8, !9}
|
|
!8 = !DIBasicType(tag: DW_TAG_base_type, name: "float", size: 32, align: 32, encoding: DW_ATE_float)
|
|
!9 = !DICompositeType(tag: DW_TAG_structure_type, name: "S", line: 1, size: 32, align: 32, file: !1, elements: !10)
|
|
!10 = !{!11}
|
|
!11 = !DIDerivedType(tag: DW_TAG_member, name: "f", line: 1, size: 32, align: 32, file: !1, scope: !9, baseType: !8)
|
|
!12 = !{i32 2, !"Dwarf Version", i32 2}
|
|
!13 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!14 = !{i32 1, !"PIC Level", i32 2}
|
|
!15 = !{!"clang version 3.6.0 "}
|
|
!16 = !DILocalVariable(name: "s", line: 3, arg: 1, scope: !4, file: !5, type: !9)
|
|
!17 = !DIExpression()
|
|
!18 = !DILocation(line: 3, column: 20, scope: !4)
|
|
!19 = !DILocation(line: 4, column: 2, scope: !4)
|