Nico Weber eaef1427b6 [PDB] Fix hash function used to write /src/headerblock ...

lld-link used to write PDB files that DIA couldn't recover natvis
files from if:

- The global strings table was > 64kiB
- There were at least 3 natvis files

The cause was that the hash function for the /src/headerblock stream
was incorrect: It needs to be truncated to 16 bit.

If the global strings table was <= 64kiB, truncating to 16 bit is a
no-op, so this wasn't needed for small programs.

If there are only 1 or 2 natvis files, then the growth strategy in
HashTable::grow() would mean the hash table would have 2 buckets (for 1
natvis file) or 4 buckets (for 4 natvis files), and since the hash
function is used modulo number of buckets, and since 2 and 4 divide
0x10000, the missing `% 0x10000` is a no-op there too. For 3 natvis
files, the hash table grows to 6 buckets, which has a factor that's not
common with 0x10000 and the difference starts to matter.

Fixes PR41626.

Differential Revision: https://reviews.llvm.org/D61277

llvm-svn: 359515

2019-04-29 23:09:35 +00:00

..

DbiModuleDescriptor.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

DbiModuleDescriptorBuilder.cpp

[DebugInfo][PDB] Don't write empty debug streams

2019-03-18 19:13:23 +00:00

DbiModuleList.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

DbiStream.cpp

[NativePDB] Fix access to both old & new fpo data entries from dbi stream

2019-01-30 10:40:45 +00:00

DbiStreamBuilder.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

EnumTables.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

GlobalsStream.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

GSIStreamBuilder.cpp

Use llvm::stable_sort

2019-04-23 14:51:27 +00:00

Hash.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

HashTable.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

InfoStream.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

InfoStreamBuilder.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

ModuleDebugStream.cpp

[DebugInfo][PDB] Don't write empty debug streams

2019-03-18 19:13:23 +00:00

NamedStreamMap.cpp

[PDB] Fix hash function used to write /src/headerblock

2019-04-29 23:09:35 +00:00

NativeCompilandSymbol.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeEnumGlobals.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeEnumModules.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeEnumTypes.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeExeSymbol.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeRawSymbol.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeSession.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeSymbolEnumerator.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeTypeArray.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeTypeBuiltin.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeTypeEnum.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeTypeFunctionSig.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeTypePointer.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeTypeTypedef.cpp

[PDB] Add support for dumping Typedef records.

2018-10-01 17:55:38 +00:00

NativeTypeUDT.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

NativeTypeVTShape.cpp

[PDB] Add support for parsing VFTable Shape records.

2018-10-01 17:55:16 +00:00

PDBFile.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

PDBFileBuilder.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

PDBStringTable.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

PDBStringTableBuilder.cpp

[PDB] Fix hash function used to write /src/headerblock

2019-04-29 23:09:35 +00:00

PublicsStream.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

RawError.cpp

Move some classes into anonymous namespaces. NFC.

2019-02-11 15:16:21 +00:00

SymbolCache.cpp

Don't build the Tpi Hash map by default.

2018-12-03 18:32:05 +00:00

SymbolStream.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

TpiHashing.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

TpiStream.cpp

Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 08:50:56 +00:00

TpiStreamBuilder.cpp

[CodeView] Fix cycles in debug info when merging Types with global hashes

2019-02-07 15:24:18 +00:00