1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-24 19:52:54 +01:00
llvm-mirror/test
Xun Li 6b5a85d5d6 [coroutine] should disable inline before calling coro split
This is a rework of D85812, which didn't land.
When callee coroutine function is inlined into caller coroutine function before coro-split pass, llvm will emits "coroutine should have exactly one defining @llvm.coro.begin". It seems that coro-early pass can not handle this quiet well.
So we believe that unsplited coroutine function should not be inlined.
This patch fix such issue by not inlining function if it has attribute "coroutine.presplit" (it means the function has not been splited) to fix this issue
test plan: check-llvm, check-clang

In D85812, there was suggestions on moving the macros to Attributes.td to avoid circular header dependency issue.
I believe it's not worth doing just to be able to use one constant string in one place.
Today, there are already 3 possible attribute values for "coroutine.presplit": c6543cc6b8/llvm/lib/Transforms/Coroutines/CoroInternal.h (L40-L42)
If we move them into Attributes.td, we would be adding 3 new attributes to EnumAttr, just to support this, which I think is an overkill.

Instead, I think the best way to do this is to add an API in Function class that checks whether this function is a coroutine, by checking the attribute by name directly.

Differential Revision: https://reviews.llvm.org/D92706
2020-12-08 08:53:08 -08:00
..
Analysis Teach isKnownNonEqual how to recurse through invertible multiplies 2020-12-07 14:52:08 -08:00
Assembler OpaquePtr: Make byval/sret types mandatory 2020-11-20 21:23:33 -05:00
Bindings Adding PoisonValue for representing poison value explicitly in IR 2020-11-25 17:33:51 -07:00
Bitcode Adding PoisonValue for representing poison value explicitly in IR 2020-11-25 17:33:51 -07:00
BugPoint
CodeGen [PowerPC] Fix missing nop after call to weak callee. 2020-12-08 09:38:44 -06:00
DebugInfo [NFC] Chec[^k] -> Check 2020-12-08 11:54:39 +00:00
Demangle
Examples
ExecutionEngine
Feature
FileCheck
Instrumentation [MemProf] Fix a potential "permission denied" test failure on some systems. 2020-12-07 14:04:23 +01:00
Integer
JitListener
Linker Simplify append to module inline asm string in IRLinker::run() 2020-12-02 14:56:43 +01:00
LTO [ICP] Don't promote when target not defined in module 2020-12-08 07:45:36 -08:00
MachineVerifier
MC [NFC] Chec[^k] -> Check 2020-12-08 11:54:39 +00:00
Object [llvm-readelf/obj] - Lowercase the warning message reported. 2020-12-02 13:09:47 +03:00
ObjectYAML
Other [NewPM] Make pass adaptors less templatey 2020-12-04 08:30:50 -08:00
Reduce
SafepointIRVerifier
Support
SymbolRewriter
TableGen [TableGen] Eliminate the 'code' type 2020-12-03 10:19:11 -05:00
ThinLTO/X86 [ThinLTO][test] Fix X86/nossp.ll after D91816 2020-12-02 13:13:58 -08:00
tools [NFC] Chec[^k] -> Check 2020-12-08 11:54:39 +00:00
Transforms [coroutine] should disable inline before calling coro split 2020-12-08 08:53:08 -08:00
Unit
Verifier Verifier: Fix assert when verifying non-pointer byval or preallocated 2020-11-20 20:08:43 -05:00
YAMLParser
.clang-format
CMakeLists.txt
lit.cfg.py
lit.site.cfg.py.in
TestRunner.sh