Tom Stellard 28bf7f3536 [cmake] Explicitly mark libraries defined in lib/ as "Component Libraries" ... Summary: Most libraries are defined in the lib/ directory but there are also a few libraries defined in tools/ e.g. libLLVM, libLTO. I'm defining "Component Libraries" as libraries defined in lib/ that may be included in libLLVM.so. Explicitly marking the libraries in lib/ as component libraries allows us to remove some fragile checks that attempt to differentiate between lib/ libraries and tools/ libraires: 1. In tools/llvm-shlib, because llvm_map_components_to_libnames(LIB_NAMES "all") returned a list of all libraries defined in the whole project, there was custom code needed to filter out libraries defined in tools/, none of which should be included in libLLVM.so. This code assumed that any library defined as static was from lib/ and everything else should be excluded. With this change, llvm_map_components_to_libnames(LIB_NAMES, "all") only returns libraries that have been added to the LLVM_COMPONENT_LIBS global cmake property, so this custom filtering logic can be removed. Doing this also fixes the build with BUILD_SHARED_LIBS=ON and LLVM_BUILD_LLVM_DYLIB=ON. 2. There was some code in llvm_add_library that assumed that libraries defined in lib/ would not have LLVM_LINK_COMPONENTS or ARG_LINK_COMPONENTS set. This is only true because libraries defined lib lib/ use LLVMBuild.txt and don't set these values. This code has been fixed now to check if the library has been explicitly marked as a component library, which should now make it easier to remove LLVMBuild at some point in the future. I have tested this patch on Windows, MacOS and Linux with release builds and the following combinations of CMake options: - "" (No options) - -DLLVM_BUILD_LLVM_DYLIB=ON - -DLLVM_LINK_LLVM_DYLIB=ON - -DBUILD_SHARED_LIBS=ON - -DBUILD_SHARED_LIBS=ON -DLLVM_BUILD_LLVM_DYLIB=ON - -DBUILD_SHARED_LIBS=ON -DLLVM_LINK_LLVM_DYLIB=ON Reviewers: beanz, smeenai, compnerd, phosek Reviewed By: beanz Subscribers: wuzish, jholewinski, arsenm, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, mgorny, mehdi_amini, sbc100, jgravelle-google, hiraditya, aheejin, fedor.sergeev, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, steven_wu, rogfer01, MartinMosbeck, brucehoult, the_o, dexonsmith, PkmX, jocewei, jsji, dang, Jim, lenary, s.egerton, pzheng, sameer.abuasal, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D70179		2019-11-21 10:48:08 -08:00
..
Disassembler	[cmake] Explicitly mark libraries defined in lib/ as "Component Libraries"	2019-11-21 10:48:08 -08:00
MCTargetDesc	[cmake] Explicitly mark libraries defined in lib/ as "Component Libraries"	2019-11-21 10:48:08 -08:00
TargetInfo	[cmake] Explicitly mark libraries defined in lib/ as "Component Libraries"	2019-11-21 10:48:08 -08:00
ARC.h
ARC.td
ARCAsmPrinter.cpp
ARCBranchFinalize.cpp	[ARC] Add InitializePasses header to fix ARC build.	2019-11-19 15:52:01 -08:00
ARCCallingConv.td
ARCExpandPseudos.cpp
ARCFrameLowering.cpp
ARCFrameLowering.h	[Alignment][NFC] Use Align for TargetFrameLowering/Subtarget	2019-10-17 07:49:39 +00:00
ARCInstrFormats.td
ARCInstrInfo.cpp	Use MCRegister in copyPhysReg	2019-11-11 14:42:33 +05:30
ARCInstrInfo.h	Use MCRegister in copyPhysReg	2019-11-11 14:42:33 +05:30
ARCInstrInfo.td
ARCISelDAGToDAG.cpp
ARCISelLowering.cpp	Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM	2019-08-15 19:22:08 +00:00
ARCISelLowering.h
ARCMachineFunctionInfo.cpp
ARCMachineFunctionInfo.h	[Alignment][NFC] Remove unneeded llvm:: scoping on Align types	2019-09-27 12:54:21 +00:00
ARCMCInstLower.cpp
ARCMCInstLower.h
ARCOptAddrMode.cpp	[ARC] Add InitializePasses header to fix ARC build.	2019-11-19 15:52:01 -08:00
ARCRegisterInfo.cpp	[cfi] Add flag to always generate .debug_frame	2019-10-31 09:48:30 +00:00
ARCRegisterInfo.h
ARCRegisterInfo.td
ARCSubtarget.cpp
ARCSubtarget.h
ARCTargetMachine.cpp
ARCTargetMachine.h
ARCTargetStreamer.h
ARCTargetTransformInfo.h
CMakeLists.txt
LLVMBuild.txt