Michael Trent 87e8d1f12b Fix Mach-O bind and rebase validation errors in libObject ... Summary: llvm-objdump (via libObject) validates DYLD_INFO rebase and bind entries against the basic structure found in the Mach-O file before evaluating the contents of those entries. Certain malformed Mach-Os can defeat the validation check and force llvm-objdump (libObject) to crash. The previous logic verified a rebase or bind started in a valid Mach-O section, but did not verify that the section wholely contained the fixup. It also generally allows rebases or binds to start immediately after a valid section even if that range is not itself part of a valid section. Finally, bind and rebase opcodes that indicate more than one fixup (apply N times...) are not completely validated: only the first and final fixups are checked. The previous logic also rejected certain binaries as false positives. Some bind and rebase opcodes can modify the state machine such that the next bind or rebase will fail. libObject will reject these opcodes as invalid in order to be helpful and print an error message associated with the instruction that caused the problem, even though the binary is not actually illegal until it consumes the invalid state in the state machine. In other words, libObject may reject a Mach-O binary that Apple's dynamic linker may consider legal. The original version of macho-rebase-add-addr-uleb-too-big is an example of such a binary. I have replaced the existing checkSegAndOffset and checkCountAndSkip functions with a single function, checkSegAndOffsets, which validates all of the fixups realized by a DYLD_INFO opcode. checkSegAndOffsets verifies that a Mach-O section fully contains each fixup. Every fixup realized by an opcode is validated, and some (but not all!) inconsistencies in the state machine are allowed until a fixup is realized. This means that libObject may fail on an opcode that realizes a fixup, not on the opcode that introduced the arithmetic error. Existing test cases have been modified to reflect the changes in error messages returned by libObject. What's more, the test case for macho-rebase-add-addr-uleb-too-big has been modified so that it actually triggers the error condition; the new code in libObject considers the original test binary "legal". rdar://47797757 Reviewers: lhames, pete, ab Reviewed By: pete Subscribers: rupprecht, jdoerfert, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D59574 llvm-svn: 356629		2019-03-20 23:21:16 +00:00
..
Archive.cpp	[libObject][NFC] Include filename in error message	2019-02-06 20:51:04 +00:00
ArchiveWriter.cpp	[libObject][NFC] Use sys::path::convert_to_slash.	2019-02-19 18:14:44 +00:00
Binary.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
CMakeLists.txt	Bitcode: Write the irsymtab to disk.	2017-06-27 23:50:11 +00:00
COFFImportFile.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
COFFModuleDefinition.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
COFFObjectFile.cpp	[COFF] Add new relocation types.	2019-01-27 19:53:36 +00:00
Decompressor.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
ELF.cpp	[ELF] Fix GCC8 warnings about "fall through", NFCI	2019-03-13 10:38:17 +00:00
ELFObjectFile.cpp	Improve "llvm-nm -f sysv" output for Elf files	2019-03-08 22:00:50 +00:00
Error.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
IRObjectFile.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
IRSymtab.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
LLVMBuild.txt	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
MachOObjectFile.cpp	Fix Mach-O bind and rebase validation errors in libObject	2019-03-20 23:21:16 +00:00
MachOUniversal.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
ModuleSymbolTable.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
Object.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
ObjectFile.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
RecordStreamer.cpp	[AsmPrinter] Remove hidden flag -print-schedule.	2019-02-04 12:51:26 +00:00
RecordStreamer.h	[AsmPrinter] Remove hidden flag -print-schedule.	2019-02-04 12:51:26 +00:00
SymbolicFile.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
SymbolSize.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00
WasmObjectFile.cpp	[WebAssembly] Target features section	2019-03-20 20:26:45 +00:00
WindowsResource.cpp	Update the file headers across all of the LLVM projects in the monorepo	2019-01-19 08:50:56 +00:00