mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 04:32:44 +01:00
a7cf9dd738
See pr46990(https://bugs.llvm.org/show_bug.cgi?id=46990). LICM should not sink store instructions to loop exit blocks which cross coro.suspend intrinsics. This breaks semantic of coro.suspend intrinsic which return to caller directly. Also this leads to use-after-free if the coroutine is freed before control returns to the caller in multithread environment. This patch disable promotion by check whether loop contains coro.suspend intrinsics. This is a resubmit of D86190. Disabling LICM for loops with coroutine suspension is a better option not only for correctness purpose but also for performance purpose. In most cases LICM sinks memory operations. In the case of coroutine, sinking memory operation out of the loop does not improve performance since coroutien needs to get data from the frame anyway. In fact LICM would hurt coroutine performance since it adds more entries to the frame. Differential Revision: https://reviews.llvm.org/D96928
53 lines
1.5 KiB
LLVM
53 lines
1.5 KiB
LLVM
; Verifies that LICM is disabled for loops that contains coro.suspend.
|
|
; RUN: opt -S < %s -passes=licm | FileCheck %s
|
|
|
|
define i64 @licm(i64 %n) #0 {
|
|
; CHECK-LABEL: @licm(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[P:%.*]] = alloca i64, align 8
|
|
; CHECK-NEXT: br label [[BB0:%.*]]
|
|
; CHECK: bb0:
|
|
; CHECK-NEXT: br label [[LOOP:%.*]]
|
|
; CHECK: loop:
|
|
; CHECK-NEXT: [[I:%.*]] = phi i64 [ 0, [[BB0]] ], [ [[T5:%.*]], [[AWAIT_READY:%.*]] ]
|
|
; CHECK-NEXT: [[T5]] = add i64 [[I]], 1
|
|
; CHECK-NEXT: [[SUSPEND:%.*]] = call i8 @llvm.coro.suspend(token none, i1 false)
|
|
; CHECK-NEXT: switch i8 [[SUSPEND]], label [[BB2:%.*]] [
|
|
; CHECK-NEXT: i8 0, label [[AWAIT_READY]]
|
|
; CHECK-NEXT: ]
|
|
; CHECK: await.ready:
|
|
; CHECK-NEXT: store i64 1, i64* [[P]], align 4
|
|
; CHECK-NEXT: [[T6:%.*]] = icmp ult i64 [[T5]], [[N:%.*]]
|
|
; CHECK-NEXT: br i1 [[T6]], label [[LOOP]], label [[BB2]]
|
|
; CHECK: bb2:
|
|
; CHECK-NEXT: [[RES:%.*]] = call i1 @llvm.coro.end(i8* null, i1 false)
|
|
; CHECK-NEXT: ret i64 0
|
|
;
|
|
entry:
|
|
%p = alloca i64
|
|
br label %bb0
|
|
|
|
bb0:
|
|
br label %loop
|
|
|
|
loop:
|
|
%i = phi i64 [ 0, %bb0 ], [ %t5, %await.ready ]
|
|
%t5 = add i64 %i, 1
|
|
%suspend = call i8 @llvm.coro.suspend(token none, i1 false)
|
|
switch i8 %suspend, label %bb2 [
|
|
i8 0, label %await.ready
|
|
]
|
|
|
|
await.ready:
|
|
store i64 1, i64* %p
|
|
%t6 = icmp ult i64 %t5, %n
|
|
br i1 %t6, label %loop, label %bb2
|
|
|
|
bb2:
|
|
%res = call i1 @llvm.coro.end(i8* null, i1 false)
|
|
ret i64 0
|
|
}
|
|
|
|
declare i8 @llvm.coro.suspend(token, i1)
|
|
declare i1 @llvm.coro.end(i8*, i1)
|