mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 02:52:53 +02:00
4450b91ba1
Summary:
The following example gives the error message "expected value of type
'bits<32>', got 'bit'" on the assignment.
class Instruction { bits<32> encoding; }
def foo: Instruction { let encoding{10} = !eq(0, 1); }
But there's nothing wrong with this code: 'bit' is a perfectly good
type for the RHS of an assignment to a //single bit// of an
instruction encoding.
The problem is that `ParseBodyItem` is accidentally type-checking the
RHS against the full type of the `encoding` field, without adjusting
it in the case where we're only assigning to a subset of the bits. The
fix is trivial.
Reviewers: nhaehnle, hfinkel
Reviewed By: hfinkel
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74220
91 lines
2.6 KiB
TableGen
91 lines
2.6 KiB
TableGen
|
|
// RUN: not llvm-tblgen %s 2>&1 > %t
|
|
// RUN: FileCheck %s < %t
|
|
|
|
def a {
|
|
bits<2> opc = { 0, 1 };
|
|
bits<2> opc2 = { 1, 0 };
|
|
bits<1> opc3 = { 1 };
|
|
bits<2> a = { opc, opc2 }; // error!
|
|
bits<2> b = { opc{0}, opc2{0} };
|
|
bits<2> c = { opc{1}, opc2{1} };
|
|
bits<2> c = { opc3{0}, opc3 };
|
|
}
|
|
|
|
// CHECK: def a {
|
|
// CHECK: bits<2> opc = { 0, 1 };
|
|
// CHECK: bits<2> opc2 = { 1, 0 };
|
|
// CHECK: bits<1> opc3 = { 1 };
|
|
// CHECK: bits<2> a;
|
|
// CHECK: bits<2> b = { 1, 0 };
|
|
// CHECK: bits<2> c = { 1, 1 };
|
|
// CHECK: }
|
|
|
|
def {
|
|
bits<2> B1 = 0b011; // bitfield is too small, reject
|
|
bits<3> B2 = 0b011; // ok
|
|
|
|
bits<2> C1 = 0b111; // bitfield is too small, reject
|
|
bits<3> C2 = 0b111; // ok
|
|
|
|
bits<2> D1 = { 0, 0 }; // ok
|
|
bits<2> D2 = { 0b00 }; // ok
|
|
bits<3> D3 = { 0, 0 }; // type mismatch. RHS doesn't have enough bits
|
|
bits<3> D4 = { 0b00 }; // type mismatch. RHS doesn't have enough bits
|
|
bits<1> D5 = { 0 }; // ok
|
|
bits<1> D6 = { 1 }; // ok
|
|
bits<1> D7 = { 3 }; // type mismatch. LHS doesn't have enough bits
|
|
bits<2> D8 = { 0 }; // type mismatch. RHS doesn't have enough bits
|
|
|
|
bits<8> E;
|
|
let E{7-0} = {0,0,1,?,?,?,?,?};
|
|
let E{3-0} = 0b0010;
|
|
|
|
bits<8> F1 = { 0, 1, 0b1001, 0, 0b0 }; // ok
|
|
bits<7> F2 = { 0, 1, 0b1001, 0, 0b0 }; // LHS doesn't have enough bits
|
|
bits<9> F3 = { 0, 1, 0b1001, 0, 0b0 }; // RHS doesn't have enough bits
|
|
|
|
bits<8> G1 = { 0, { 1, 0b1001, 0 }, 0b0 }; // ok
|
|
bits<8> G2 = { 0, { 1, 0b1001 }, 0, 0b0 }; // ok
|
|
bits<8> G3 = { 0, 1, { 0b1001 }, 0, 0b0 }; // ok
|
|
|
|
bits<16> H;
|
|
let H{15-0} = { { 0b11001100 }, 0b00110011 };
|
|
bits<16> I = { G1, G2 };
|
|
|
|
// Make sure we can initialise ints with bits<> values.
|
|
int J = H;
|
|
int K = { 0, 1 };
|
|
|
|
bits<2> L;
|
|
let L{0} = 1;
|
|
let L{1} = !eq(L{0}, 0);
|
|
}
|
|
|
|
// CHECK: def {{.*}} {
|
|
// CHECK: bits<2> B1;
|
|
// CHECK: bits<3> B2 = { 0, 1, 1 };
|
|
// CHECK: bits<2> C1;
|
|
// CHECK: bits<3> C2 = { 1, 1, 1 };
|
|
// CHECK: bits<2> D1 = { 0, 0 };
|
|
// CHECK: bits<2> D2 = { 0, 0 };
|
|
// CHECK: bits<3> D3;
|
|
// CHECK: bits<3> D4;
|
|
// CHECK: bits<1> D5 = { 0 };
|
|
// CHECK: bits<1> D6 = { 1 };
|
|
// CHECK: bits<1> D7 = { !cast<bit>(3) };
|
|
// CHECK: bits<2> D8;
|
|
// CHECK: bits<8> E = { 0, 0, 1, ?, 0, 0, 1, 0 };
|
|
// CHECK: bits<8> F1 = { 0, 1, 1, 0, 0, 1, 0, 0 };
|
|
// CHECK: bits<7> F2;
|
|
// CHECK: bits<9> F3;
|
|
// CHECK: bits<8> G1 = { 0, 1, 1, 0, 0, 1, 0, 0 };
|
|
// CHECK: bits<8> G2 = { 0, 1, 1, 0, 0, 1, 0, 0 };
|
|
// CHECK: bits<8> G3 = { 0, 1, 1, 0, 0, 1, 0, 0 };
|
|
// CHECK: bits<16> H = { 1, 1, 0, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 0, 1, 1 };
|
|
// CHECK: bits<16> I = { 0, 1, 1, 0, 0, 1, 0, 0, 0, 1, 1, 0, 0, 1, 0, 0 };
|
|
// CHECK: int J = 52275;
|
|
// CHECK: int K = 1;
|
|
// CHECK: bits<2> L = { 0, 1 };
|
|
// CHECK: }
|