mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-30 23:42:52 +01:00
ad27c13a64
Per original comment, the intention of this loop is to go ahead and break the critical edge (in order to sink this instruction) if there's reason to believe doing so might "unblock" the sinking of additional instructions that define registers used by this one. The idea is that if we have a few instructions to sink "together" breaking the edge might be worthwhile. This commit makes a few small changes to help better realize this goal: First, modify the loop to ignore registers defined by this instruction. We don't sink definitions of physical registers, and sinking an SSA definition isn't going to unblock an upstream instruction. Second, ignore uses of physical registers. Instructions that define physical registers are rejected for sinking, and so moving this one won't enable moving any defining instructions. As an added bonus, while virtual register use-def chains are generally small due to SSA goodness, iteration over the uses and definitions (used by hasOneNonDBGUse) for physical registers like EFLAGS can be rather expensive in practice. (This is the original reason for looking at this) Finally, to keep things simple continue to only consider this trick for registers that have a single use (via hasOneNonDBGUse), but to avoid spuriously breaking critical edges only do so if the definition resides in the same MBB and therefore this one directly blocks it from being sunk as well. If sinking them together is meant to be, let the iterative nature of this pass sink the definition into this block first. Update tests to accomodate this change, add new testcase where sinking avoids pipeline stalls. llvm-svn: 192608
34 lines
884 B
LLVM
34 lines
884 B
LLVM
; RUN: llc < %s -mtriple=thumbv7-apple-darwin -mcpu=cortex-a8 | FileCheck %s
|
|
|
|
; Overly aggressive LICM simply adds copies of constants
|
|
; rdar://9266679
|
|
|
|
define zeroext i1 @t(i32* nocapture %A, i32 %size, i32 %value) nounwind readonly ssp {
|
|
; CHECK-LABEL: t:
|
|
entry:
|
|
br label %for.cond
|
|
|
|
for.cond:
|
|
%0 = phi i32 [ 0, %entry ], [ %inc, %for.inc ]
|
|
%cmp = icmp ult i32 %0, %size
|
|
br i1 %cmp, label %for.body, label %return
|
|
|
|
for.body:
|
|
; CHECK: %for.
|
|
; CHECK: mov{{.*}} r{{[0-9]+}}, #{{[01]}}
|
|
; CHECK: mov{{.*}} r{{[0-9]+}}, #{{[01]}}
|
|
; CHECK-NOT: mov r{{[0-9]+}}, #{{[01]}}
|
|
%arrayidx = getelementptr i32* %A, i32 %0
|
|
%tmp4 = load i32* %arrayidx, align 4
|
|
%cmp6 = icmp eq i32 %tmp4, %value
|
|
br i1 %cmp6, label %return, label %for.inc
|
|
|
|
for.inc:
|
|
%inc = add i32 %0, 1
|
|
br label %for.cond
|
|
|
|
return:
|
|
%retval.0 = phi i1 [ true, %for.body ], [ false, %for.cond ]
|
|
ret i1 %retval.0
|
|
}
|