mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 03:02:36 +01:00
d7003090ac
with the new pass manager, and no longer relying on analysis groups. This builds essentially a ground-up new AA infrastructure stack for LLVM. The core ideas are the same that are used throughout the new pass manager: type erased polymorphism and direct composition. The design is as follows: - FunctionAAResults is a type-erasing alias analysis results aggregation interface to walk a single query across a range of results from different alias analyses. Currently this is function-specific as we always assume that aliasing queries are *within* a function. - AAResultBase is a CRTP utility providing stub implementations of various parts of the alias analysis result concept, notably in several cases in terms of other more general parts of the interface. This can be used to implement only a narrow part of the interface rather than the entire interface. This isn't really ideal, this logic should be hoisted into FunctionAAResults as currently it will cause a significant amount of redundant work, but it faithfully models the behavior of the prior infrastructure. - All the alias analysis passes are ported to be wrapper passes for the legacy PM and new-style analysis passes for the new PM with a shared result object. In some cases (most notably CFL), this is an extremely naive approach that we should revisit when we can specialize for the new pass manager. - BasicAA has been restructured to reflect that it is much more fundamentally a function analysis because it uses dominator trees and loop info that need to be constructed for each function. All of the references to getting alias analysis results have been updated to use the new aggregation interface. All the preservation and other pass management code has been updated accordingly. The way the FunctionAAResultsWrapperPass works is to detect the available alias analyses when run, and add them to the results object. This means that we should be able to continue to respect when various passes are added to the pipeline, for example adding CFL or adding TBAA passes should just cause their results to be available and to get folded into this. The exception to this rule is BasicAA which really needs to be a function pass due to using dominator trees and loop info. As a consequence, the FunctionAAResultsWrapperPass directly depends on BasicAA and always includes it in the aggregation. This has significant implications for preserving analyses. Generally, most passes shouldn't bother preserving FunctionAAResultsWrapperPass because rebuilding the results just updates the set of known AA passes. The exception to this rule are LoopPass instances which need to preserve all the function analyses that the loop pass manager will end up needing. This means preserving both BasicAAWrapperPass and the aggregating FunctionAAResultsWrapperPass. Now, when preserving an alias analysis, you do so by directly preserving that analysis. This is only necessary for non-immutable-pass-provided alias analyses though, and there are only three of interest: BasicAA, GlobalsAA (formerly GlobalsModRef), and SCEVAA. Usually BasicAA is preserved when needed because it (like DominatorTree and LoopInfo) is marked as a CFG-only pass. I've expanded GlobalsAA into the preserved set everywhere we previously were preserving all of AliasAnalysis, and I've added SCEVAA in the intersection of that with where we preserve SCEV itself. One significant challenge to all of this is that the CGSCC passes were actually using the alias analysis implementations by taking advantage of a pretty amazing set of loop holes in the old pass manager's analysis management code which allowed analysis groups to slide through in many cases. Moving away from analysis groups makes this problem much more obvious. To fix it, I've leveraged the flexibility the design of the new PM components provides to just directly construct the relevant alias analyses for the relevant functions in the IPO passes that need them. This is a bit hacky, but should go away with the new pass manager, and is already in many ways cleaner than the prior state. Another significant challenge is that various facilities of the old alias analysis infrastructure just don't fit any more. The most significant of these is the alias analysis 'counter' pass. That pass relied on the ability to snoop on AA queries at different points in the analysis group chain. Instead, I'm planning to build printing functionality directly into the aggregation layer. I've not included that in this patch merely to keep it smaller. Note that all of this needs a nearly complete rewrite of the AA documentation. I'm planning to do that, but I'd like to make sure the new design settles, and to flesh out a bit more of what it looks like in the new pass manager first. Differential Revision: http://reviews.llvm.org/D12080 llvm-svn: 247167
38 lines
886 B
LLVM
38 lines
886 B
LLVM
; RUN: opt < %s -globals-aa -gvn -S | FileCheck %s
|
|
|
|
@X = internal global i32 4
|
|
|
|
define i32 @test_cmpxchg(i32* %P) {
|
|
; CHECK-LABEL: @test_cmpxchg
|
|
; CHECK-NEXT: store i32 12, i32* @X
|
|
; CHECK-NEXT: call void @modrefX_cmpxchg()
|
|
; CHECK-NEXT: %V = load i32, i32* @X
|
|
; CHECK-NEXT: ret i32 %V
|
|
store i32 12, i32* @X
|
|
call void @modrefX_cmpxchg()
|
|
%V = load i32, i32* @X
|
|
ret i32 %V
|
|
}
|
|
|
|
define void @modrefX_cmpxchg() {
|
|
%1 = cmpxchg i32* @X, i32 0, i32 -1 monotonic monotonic
|
|
ret void
|
|
}
|
|
|
|
define i32 @test_atomicrmw(i32* %P) {
|
|
; CHECK-LABEL: @test_atomicrmw
|
|
; CHECK-NEXT: store i32 12, i32* @X
|
|
; CHECK-NEXT: call void @modrefXatomicrmw()
|
|
; CHECK-NEXT: %V = load i32, i32* @X
|
|
; CHECK-NEXT: ret i32 %V
|
|
store i32 12, i32* @X
|
|
call void @modrefXatomicrmw()
|
|
%V = load i32, i32* @X
|
|
ret i32 %V
|
|
}
|
|
|
|
define void @modrefXatomicrmw() {
|
|
%1 = atomicrmw add i32* @X, i32 1 acquire
|
|
ret void
|
|
}
|