mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 11:13:28 +01:00
9c5542c040
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
36 lines
1.2 KiB
LLVM
36 lines
1.2 KiB
LLVM
; RUN: llvm-dis < %s.bc | FileCheck %s
|
|
|
|
; Check that function-local metadata is dropped correctly when it's not a
|
|
; direct argument to a call instruction.
|
|
;
|
|
; Bitcode assembled by llvm-as v3.5.0.
|
|
|
|
define void @foo(i32 %v) {
|
|
; CHECK: entry:
|
|
entry:
|
|
; CHECK-NEXT: call void @llvm.bar(metadata i32 %v)
|
|
call void @llvm.bar(metadata !{i32 %v})
|
|
|
|
; Note: these supposedly legal instructions fired an assertion in llvm-as:
|
|
;
|
|
; Assertion failed: (I != ValueMap.end() && "Value not in slotcalculator!"), function getValueID, file lib/Bitcode/Writer/ValueEnumerator.cpp, line 138.
|
|
;
|
|
; So, I didn't test them; it looks like bitcode compatability is irrelevant.
|
|
; call void @llvm.bar(metadata !{i32 0, i32 %v})
|
|
; call void @llvm.bar(metadata !{i32 %v, i32 0})
|
|
; call void @llvm.bar(metadata !{metadata !{}, i32 %v})
|
|
; call void @llvm.bar(metadata !{i32 %v, metadata !{}})
|
|
|
|
; CHECK-NEXT: call void @llvm.bar(metadata !0)
|
|
; CHECK-NEXT: call void @llvm.bar(metadata !0)
|
|
call void @llvm.bar(metadata !{i32 %v, i32 %v})
|
|
call void @llvm.bar(metadata !{metadata !{i32 %v}})
|
|
|
|
; CHECK-NEXT: ret void{{$}}
|
|
ret void, !baz !{i32 %v}
|
|
}
|
|
|
|
declare void @llvm.bar(metadata)
|
|
|
|
; CHECK: !0 = !{}
|