mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 12:43:36 +01:00
ee9e4fc042
PHI that has at least one unrelocated input cannot cause any issues by itself, though its uses should be carefully verified. With this patch PHIs are allowed to have any inputs but when all inputs are unrelocated the PHI is marked as unrelocated and if not all inputs are unrelocated then the PHI is marked as poisoned. Poisoned pointers can be used only in three ways: to derive new pointers, in PHIs or in comparisons against constants that are exclusively derived from null. Patch by Daniil Suchkov! Differential Revision: https://reviews.llvm.org/D41006 llvm-svn: 321438
173 lines
7.4 KiB
LLVM
173 lines
7.4 KiB
LLVM
; RUN: opt -safepoint-ir-verifier-print-only -verify-safepoint-ir -S %s 2>&1 | FileCheck %s
|
|
|
|
define i8 addrspace(1)* @test.not.ok.0(i8 addrspace(1)* %arg) gc "statepoint-example" {
|
|
; CHECK-LABEL: Verifying gc pointers in function: test.not.ok.0
|
|
bci_0:
|
|
br i1 undef, label %left, label %right
|
|
|
|
left:
|
|
%safepoint_token = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 5, i32 0, i32 -1, i32 0, i32 0, i32 0)
|
|
br label %merge
|
|
|
|
right:
|
|
br label %merge
|
|
|
|
merge:
|
|
; CHECK: Illegal use of unrelocated value found!
|
|
; CHECK-NEXT: Def: %val = phi i8 addrspace(1)* [ %arg, %left ], [ %arg, %right ]
|
|
; CHECK-NEXT: Use: ret i8 addrspace(1)* %val
|
|
%val = phi i8 addrspace(1)* [ %arg, %left ], [ %arg, %right ]
|
|
ret i8 addrspace(1)* %val
|
|
}
|
|
|
|
define i8 addrspace(1)* @test.not.ok.1(i8 addrspace(1)* %arg) gc "statepoint-example" {
|
|
; CHECK-LABEL: Verifying gc pointers in function: test.not.ok.1
|
|
bci_0:
|
|
br i1 undef, label %left, label %right
|
|
|
|
left:
|
|
%safepoint_token = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 5, i32 0, i32 -1, i32 0, i32 0, i32 0)
|
|
br label %merge
|
|
|
|
right:
|
|
br label %merge
|
|
|
|
merge:
|
|
; CHECK: Illegal use of unrelocated value found!
|
|
; CHECK-NEXT: Def: %val = phi i8 addrspace(1)* [ %arg, %left ], [ null, %right ]
|
|
; CHECK-NEXT: Use: ret i8 addrspace(1)* %val
|
|
%val = phi i8 addrspace(1)* [ %arg, %left ], [ null, %right ]
|
|
ret i8 addrspace(1)* %val
|
|
}
|
|
|
|
define i8 addrspace(1)* @test.ok.0(i8 addrspace(1)* %arg) gc "statepoint-example" {
|
|
; CHECK: No illegal uses found by SafepointIRVerifier in: test.ok.0
|
|
bci_0:
|
|
br i1 undef, label %left, label %right
|
|
|
|
left:
|
|
%safepoint_token = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 5, i32 0, i32 -1, i32 0, i32 0, i32 0)
|
|
br label %merge
|
|
|
|
right:
|
|
br label %merge
|
|
|
|
merge:
|
|
%val = phi i8 addrspace(1)* [ null, %left ], [ null, %right]
|
|
ret i8 addrspace(1)* %val
|
|
}
|
|
|
|
define i8 addrspace(1)* @test.ok.1(i8 addrspace(1)* %arg) gc "statepoint-example" {
|
|
; CHECK: No illegal uses found by SafepointIRVerifier in: test.ok.1
|
|
bci_0:
|
|
br i1 undef, label %left, label %right
|
|
|
|
left:
|
|
call void @not_statepoint()
|
|
br label %merge
|
|
|
|
right:
|
|
br label %merge
|
|
|
|
merge:
|
|
%val = phi i8 addrspace(1)* [ %arg, %left ], [ %arg, %right]
|
|
ret i8 addrspace(1)* %val
|
|
}
|
|
|
|
; It should be allowed to compare poisoned ptr with null.
|
|
define void @test.poisoned.cmp.ok(i8 addrspace(1)* %arg) gc "statepoint-example" {
|
|
; CHECK-LABEL: Verifying gc pointers in function: test.poisoned.cmp.ok
|
|
bci_0:
|
|
br i1 undef, label %left, label %right
|
|
|
|
left:
|
|
%safepoint_token = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 0, i8 addrspace(1)* %arg , i32 -1, i32 0, i32 0, i32 0)
|
|
%arg.relocated = call i8 addrspace(1)* @llvm.experimental.gc.relocate.p1i8(token %safepoint_token, i32 7, i32 7) ; arg, arg
|
|
br label %merge
|
|
|
|
right:
|
|
%safepoint_token2 = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 0, i8 addrspace(1)* %arg , i32 -1, i32 0, i32 0, i32 0)
|
|
br label %merge
|
|
|
|
merge:
|
|
; CHECK: No illegal uses found by SafepointIRVerifier in: test.poisoned.cmp.ok
|
|
%val.poisoned = phi i8 addrspace(1)* [ %arg.relocated, %left ], [ %arg, %right ]
|
|
%c = icmp eq i8 addrspace(1)* %val.poisoned, null
|
|
ret void
|
|
}
|
|
|
|
; It is illegal to compare poisoned ptr and relocated.
|
|
define void @test.poisoned.cmp.fail.0(i8 addrspace(1)* %arg) gc "statepoint-example" {
|
|
; CHECK-LABEL: Verifying gc pointers in function: test.poisoned.cmp.fail.0
|
|
bci_0:
|
|
br i1 undef, label %left, label %right
|
|
|
|
left:
|
|
%safepoint_token = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 0, i8 addrspace(1)* %arg , i32 -1, i32 0, i32 0, i32 0)
|
|
%arg.relocated = call i8 addrspace(1)* @llvm.experimental.gc.relocate.p1i8(token %safepoint_token, i32 7, i32 7) ; arg, arg
|
|
br label %merge
|
|
|
|
right:
|
|
%safepoint_token2 = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 0, i8 addrspace(1)* %arg , i32 -1, i32 0, i32 0, i32 0)
|
|
%arg.relocated2 = call i8 addrspace(1)* @llvm.experimental.gc.relocate.p1i8(token %safepoint_token2, i32 7, i32 7) ; arg, arg
|
|
br label %merge
|
|
|
|
merge:
|
|
; CHECK: Illegal use of unrelocated value found!
|
|
; CHECK-NEXT: Def: %val.poisoned = phi i8 addrspace(1)* [ %arg.relocated, %left ], [ %arg, %right ]
|
|
; CHECK-NEXT: Use: %c = icmp eq i8 addrspace(1)* %val.poisoned, %val
|
|
%val.poisoned = phi i8 addrspace(1)* [ %arg.relocated, %left ], [ %arg, %right ]
|
|
%val = phi i8 addrspace(1)* [ %arg.relocated, %left ], [ %arg.relocated2, %right ]
|
|
%c = icmp eq i8 addrspace(1)* %val.poisoned, %val
|
|
ret void
|
|
}
|
|
|
|
; It is illegal to compare poisoned ptr and unrelocated.
|
|
define void @test.poisoned.cmp.fail.1(i8 addrspace(1)* %arg) gc "statepoint-example" {
|
|
; CHECK-LABEL: Verifying gc pointers in function: test.poisoned.cmp.fail.1
|
|
bci_0:
|
|
br i1 undef, label %left, label %right
|
|
|
|
left:
|
|
%safepoint_token = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 0, i8 addrspace(1)* %arg , i32 -1, i32 0, i32 0, i32 0)
|
|
%arg.relocated = call i8 addrspace(1)* @llvm.experimental.gc.relocate.p1i8(token %safepoint_token, i32 7, i32 7) ; arg, arg
|
|
br label %merge
|
|
|
|
right:
|
|
%safepoint_token2 = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 0, i8 addrspace(1)* %arg , i32 -1, i32 0, i32 0, i32 0)
|
|
%arg.relocated2 = call i8 addrspace(1)* @llvm.experimental.gc.relocate.p1i8(token %safepoint_token2, i32 7, i32 7) ; arg, arg
|
|
br label %merge
|
|
|
|
merge:
|
|
; CHECK: Illegal use of unrelocated value found!
|
|
; CHECK-NEXT: Def: %val.poisoned = phi i8 addrspace(1)* [ %arg.relocated, %left ], [ %arg, %right ]
|
|
; CHECK-NEXT: Use: %c = icmp eq i8 addrspace(1)* %val.poisoned, %arg
|
|
%val.poisoned = phi i8 addrspace(1)* [ %arg.relocated, %left ], [ %arg, %right ]
|
|
%c = icmp eq i8 addrspace(1)* %val.poisoned, %arg
|
|
ret void
|
|
}
|
|
|
|
; It should be allowed to compare unrelocated phi with unrelocated value.
|
|
define void @test.unrelocated-phi.cmp.ok(i8 addrspace(1)* %arg) gc "statepoint-example" {
|
|
; CHECK-LABEL: Verifying gc pointers in function: test.unrelocated-phi.cmp.ok
|
|
bci_0:
|
|
br i1 undef, label %left, label %right
|
|
|
|
left:
|
|
%safepoint_token = call token (i64, i32, void ()*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* undef, i32 0, i32 0, i32 0, i32 5, i32 0, i32 -1, i32 0, i32 0, i32 0)
|
|
br label %merge
|
|
|
|
right:
|
|
br label %merge
|
|
|
|
merge:
|
|
; CHECK: No illegal uses found by SafepointIRVerifier in: test.unrelocated-phi.cmp.ok
|
|
%val.unrelocated = phi i8 addrspace(1)* [ %arg, %left ], [ null, %right ]
|
|
%c = icmp eq i8 addrspace(1)* %val.unrelocated, %arg
|
|
ret void
|
|
}
|
|
|
|
declare token @llvm.experimental.gc.statepoint.p0f_isVoidf(i64, i32, void ()*, i32, i32, ...)
|
|
declare i8 addrspace(1)* @llvm.experimental.gc.relocate.p1i8(token, i32, i32)
|
|
declare void @not_statepoint()
|