mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 04:02:41 +01:00
ea4f7bb1a3
This matches what MS rc.exe allows in practice. I'm not aware of any legal syntax case that are broken by allowing dashes as part of what the tokenizer considers an Identifier - but I'm not very well versed in the RC syntax either, can @amccarth think of any case that would be broken by this? This fixes downstream bug https://github.com/msys2/MINGW-packages/issues/9180. Additionally, rc.exe allows such resource name strings to be surrounded by quotes, ending up with e.g. Resource name (string): "QUOTEDNAME" (i.e., the quotes end up as part of the string), which llvm-rc doesn't support yet either. (I'm not aware of such cases in the wild though, but resource string names with dashes do exist.) This also allows including files with unquoted paths, with filenames containing dashes (which fixes https://github.com/msys2/MINGW-packages/issues/9130, which has been worked around differently so far). Differential Revision: https://reviews.llvm.org/D106598 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| llvm-rc.cpp | ||
| Opts.td | ||
| ResourceFileWriter.cpp | ||
| ResourceFileWriter.h | ||
| ResourceScriptCppFilter.cpp | ||
| ResourceScriptCppFilter.h | ||
| ResourceScriptParser.cpp | ||
| ResourceScriptParser.h | ||
| ResourceScriptStmt.cpp | ||
| ResourceScriptStmt.h | ||
| ResourceScriptToken.cpp | ||
| ResourceScriptToken.h | ||
| ResourceScriptTokenList.def | ||
| ResourceVisitor.h | ||
| WindresOpts.td | ||