mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 19:12:56 +02:00
6d0ecb4cce
This came out of a recent discussion on llvm-dev (https://reviews.llvm.org/D38042). Currently the Verifier will strip the debug info metadata from a module if it finds the dbeug info to be malformed. This feature is very valuable since it allows us to improve the Verifier by making it stricter without breaking bcompatibility, but arguable the Verifier pass should not be modifying the IR. This patch moves the stripping of broken debug info into AutoUpgrade (UpgradeDebugInfo to be precise), which is a much better location for this since the stripping of malformed (i.e., produced by older, buggy versions of Clang) is a (harsh) form of AutoUpgrade. This change is mostly NFC in nature, the one big difference is the behavior when LLVM module passes are introducing malformed debug info. Prior to this patch, a NoAsserts build would have printed a warning and stripped the debug info, after this patch the Verifier will report a fatal error. I believe this behavior is actually more desirable anyway. Differential Revision: https://reviews.llvm.org/D38184 llvm-svn: 314699
23 lines
1.1 KiB
LLVM
23 lines
1.1 KiB
LLVM
; Make sure we reject GVs without a type.
|
|
; Currently the verifier when traversing the graph induced by the debug info
|
|
; metadata can reach the GV both from a DICompileUnit and a DIGlobalVariable
|
|
; expression, so we emit a diagnostic twice. This is, not ideal, but the
|
|
; alternative is that of keeping a map of visited GVs, which has non trivial
|
|
; memory usage consequences on large testcases, or when LTO is the mode of
|
|
; operation.
|
|
; RUN: llvm-as -disable-output %s -o - 2>&1 | FileCheck %s
|
|
; CHECK: missing global variable type
|
|
; CHECK: missing global variable type
|
|
; CHECK-NOT: missing global variable type
|
|
; CHECK: warning: ignoring invalid debug info
|
|
|
|
!llvm.dbg.cu = !{!2}
|
|
!llvm.module.flags = !{!63, !64}
|
|
!1 = distinct !DIGlobalVariable(name: "pat", scope: !2, file: !3, line: 27, isLocal: true, isDefinition: true)
|
|
!2 = distinct !DICompileUnit(language: DW_LANG_C99, file: !3, producer: "", emissionKind: FullDebug, globals: !5)
|
|
!3 = !DIFile(filename: "patatino.c", directory: "/")
|
|
!5 = !{!6}
|
|
!6 = !DIGlobalVariableExpression(var: !1, expr: !DIExpression())
|
|
!63 = !{i32 2, !"Dwarf Version", i32 4}
|
|
!64 = !{i32 2, !"Debug Info Version", i32 3}
|