1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-18 18:42:46 +02:00
llvm-mirror/tools/llvm-objcopy/ELF
Jordan Rupprecht b34be145e0 [llvm-objcopy] Fix SHT_GROUP ordering.
Summary:
When llvm-objcopy sorts sections during finalization, it only sorts based on the offset, which can cause the group section to come after the sections it contains. This causes link failures when using gold to link objects created by llvm-objcopy.

Fix this for now by copying GNU objcopy's behavior of placing SHT_GROUP sections first. In the future, we may want to remove this sorting entirely to more closely preserve the input file layout.

This fixes https://bugs.llvm.org/show_bug.cgi?id=42052.

Reviewers: jakehehrlich, jhenderson, MaskRay, espindola, alexshap

Reviewed By: MaskRay

Subscribers: phuongtrang148993, emaste, arichardson, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D62620

llvm-svn: 362973
2019-06-10 18:35:01 +00:00
..
ELFObjcopy.cpp Fix -Wunused-lambda-capture warning. NFCI. 2019-06-07 18:20:09 +00:00
ELFObjcopy.h [llvm-objcopy][NFC] More error propagation 2019-01-30 14:36:53 +00:00
Object.cpp [llvm-objcopy] Fix SHT_GROUP ordering. 2019-06-10 18:35:01 +00:00
Object.h Unbreak 32-bit build. 2019-06-07 18:57:32 +00:00