mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 19:52:54 +01:00
d33177a252
Summary: The accelerator tables use the debug_str section to store their strings. However, they do not support the indirect method of access that is available for the debug_info section (DW_FORM_strx et al.). Currently our code is assuming that all strings can/will be referenced indirectly, and puts all of them into the debug_str_offsets section. This is generally true for regular (unsplit) dwarf, but in the DWO case, most of the strings in the debug_str section will only be used from the accelerator tables. Therefore the contents of the debug_str_offsets section will be largely unused and bloating the main executable. This patch rectifies this by teaching the DwarfStringPool to differentiate between strings accessed directly and indirectly. When a user inserts a string into the pool it has to declare whether that string will be referenced directly or not. If at least one user requsts indirect access, that string will be assigned an index ID and put into debug_str_offsets table. Otherwise, the offset table is skipped. This approach reduces the overall binary size (when compiled with -gdwarf-5 -gsplit-dwarf) in my tests by about 2% (debug_str_offsets is shrunk by 99%). Reviewers: probinson, dblaikie, JDevlieghere Subscribers: aprantl, mgrang, llvm-commits Differential Revision: https://reviews.llvm.org/D49493 llvm-svn: 339122
53 lines
1.6 KiB
C++
53 lines
1.6 KiB
C++
//===- NonRelocatableStringpool.cpp - A simple stringpool ----------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "NonRelocatableStringpool.h"
|
|
|
|
namespace llvm {
|
|
namespace dsymutil {
|
|
|
|
DwarfStringPoolEntryRef NonRelocatableStringpool::getEntry(StringRef S) {
|
|
if (S.empty() && !Strings.empty())
|
|
return EmptyString;
|
|
|
|
auto I = Strings.insert({S, DwarfStringPoolEntry()});
|
|
auto &Entry = I.first->second;
|
|
if (I.second || !Entry.isIndexed()) {
|
|
Entry.Index = NumEntries++;
|
|
Entry.Offset = CurrentEndOffset;
|
|
Entry.Symbol = nullptr;
|
|
CurrentEndOffset += S.size() + 1;
|
|
}
|
|
return DwarfStringPoolEntryRef(*I.first, true);
|
|
}
|
|
|
|
StringRef NonRelocatableStringpool::internString(StringRef S) {
|
|
DwarfStringPoolEntry Entry{nullptr, 0, DwarfStringPoolEntry::NotIndexed};
|
|
auto InsertResult = Strings.insert({S, Entry});
|
|
return InsertResult.first->getKey();
|
|
}
|
|
|
|
std::vector<DwarfStringPoolEntryRef>
|
|
NonRelocatableStringpool::getEntriesForEmission() const {
|
|
std::vector<DwarfStringPoolEntryRef> Result;
|
|
Result.reserve(Strings.size());
|
|
for (const auto &E : Strings)
|
|
if (E.getValue().isIndexed())
|
|
Result.emplace_back(E, true);
|
|
llvm::sort(
|
|
Result.begin(), Result.end(),
|
|
[](const DwarfStringPoolEntryRef A, const DwarfStringPoolEntryRef B) {
|
|
return A.getIndex() < B.getIndex();
|
|
});
|
|
return Result;
|
|
}
|
|
|
|
} // namespace dsymutil
|
|
} // namespace llvm
|