mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
eb66b33867
I did this a long time ago with a janky python script, but now clang-format has built-in support for this. I fed clang-format every line with a #include and let it re-sort things according to the precise LLVM rules for include ordering baked into clang-format these days. I've reverted a number of files where the results of sorting includes isn't healthy. Either places where we have legacy code relying on particular include ordering (where possible, I'll fix these separately) or where we have particular formatting around #include lines that I didn't want to disturb in this patch. This patch is *entirely* mechanical. If you get merge conflicts or anything, just ignore the changes in this patch and run clang-format over your #include lines in the files. Sorry for any noise here, but it is important to keep these things stable. I was seeing an increasing number of patches with irrelevant re-ordering of #include lines because clang-format was used. This patch at least isolates that churn, makes it easy to skip when resolving conflicts, and gets us to a clean baseline (again). llvm-svn: 304787
181 lines
6.4 KiB
C++
181 lines
6.4 KiB
C++
//===- GlobalSplit.cpp - global variable splitter -------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This pass uses inrange annotations on GEP indices to split globals where
|
|
// beneficial. Clang currently attaches these annotations to references to
|
|
// virtual table globals under the Itanium ABI for the benefit of the
|
|
// whole-program virtual call optimization and control flow integrity passes.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/Transforms/IPO/GlobalSplit.h"
|
|
#include "llvm/ADT/StringExtras.h"
|
|
#include "llvm/IR/Constants.h"
|
|
#include "llvm/IR/GlobalVariable.h"
|
|
#include "llvm/IR/Intrinsics.h"
|
|
#include "llvm/IR/Module.h"
|
|
#include "llvm/IR/Operator.h"
|
|
#include "llvm/Pass.h"
|
|
#include "llvm/Transforms/IPO.h"
|
|
|
|
#include <set>
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
bool splitGlobal(GlobalVariable &GV) {
|
|
// If the address of the global is taken outside of the module, we cannot
|
|
// apply this transformation.
|
|
if (!GV.hasLocalLinkage())
|
|
return false;
|
|
|
|
// We currently only know how to split ConstantStructs.
|
|
auto *Init = dyn_cast_or_null<ConstantStruct>(GV.getInitializer());
|
|
if (!Init)
|
|
return false;
|
|
|
|
// Verify that each user of the global is an inrange getelementptr constant.
|
|
// From this it follows that any loads from or stores to that global must use
|
|
// a pointer derived from an inrange getelementptr constant, which is
|
|
// sufficient to allow us to apply the splitting transform.
|
|
for (User *U : GV.users()) {
|
|
if (!isa<Constant>(U))
|
|
return false;
|
|
|
|
auto *GEP = dyn_cast<GEPOperator>(U);
|
|
if (!GEP || !GEP->getInRangeIndex() || *GEP->getInRangeIndex() != 1 ||
|
|
!isa<ConstantInt>(GEP->getOperand(1)) ||
|
|
!cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
|
|
!isa<ConstantInt>(GEP->getOperand(2)))
|
|
return false;
|
|
}
|
|
|
|
SmallVector<MDNode *, 2> Types;
|
|
GV.getMetadata(LLVMContext::MD_type, Types);
|
|
|
|
const DataLayout &DL = GV.getParent()->getDataLayout();
|
|
const StructLayout *SL = DL.getStructLayout(Init->getType());
|
|
|
|
IntegerType *Int32Ty = Type::getInt32Ty(GV.getContext());
|
|
|
|
std::vector<GlobalVariable *> SplitGlobals(Init->getNumOperands());
|
|
for (unsigned I = 0; I != Init->getNumOperands(); ++I) {
|
|
// Build a global representing this split piece.
|
|
auto *SplitGV =
|
|
new GlobalVariable(*GV.getParent(), Init->getOperand(I)->getType(),
|
|
GV.isConstant(), GlobalValue::PrivateLinkage,
|
|
Init->getOperand(I), GV.getName() + "." + utostr(I));
|
|
SplitGlobals[I] = SplitGV;
|
|
|
|
unsigned SplitBegin = SL->getElementOffset(I);
|
|
unsigned SplitEnd = (I == Init->getNumOperands() - 1)
|
|
? SL->getSizeInBytes()
|
|
: SL->getElementOffset(I + 1);
|
|
|
|
// Rebuild type metadata, adjusting by the split offset.
|
|
// FIXME: See if we can use DW_OP_piece to preserve debug metadata here.
|
|
for (MDNode *Type : Types) {
|
|
uint64_t ByteOffset = cast<ConstantInt>(
|
|
cast<ConstantAsMetadata>(Type->getOperand(0))->getValue())
|
|
->getZExtValue();
|
|
// Type metadata may be attached one byte after the end of the vtable, for
|
|
// classes without virtual methods in Itanium ABI. AFAIK, it is never
|
|
// attached to the first byte of a vtable. Subtract one to get the right
|
|
// slice.
|
|
// This is making an assumption that vtable groups are the only kinds of
|
|
// global variables that !type metadata can be attached to, and that they
|
|
// are either Itanium ABI vtable groups or contain a single vtable (i.e.
|
|
// Microsoft ABI vtables).
|
|
uint64_t AttachedTo = (ByteOffset == 0) ? ByteOffset : ByteOffset - 1;
|
|
if (AttachedTo < SplitBegin || AttachedTo >= SplitEnd)
|
|
continue;
|
|
SplitGV->addMetadata(
|
|
LLVMContext::MD_type,
|
|
*MDNode::get(GV.getContext(),
|
|
{ConstantAsMetadata::get(
|
|
ConstantInt::get(Int32Ty, ByteOffset - SplitBegin)),
|
|
Type->getOperand(1)}));
|
|
}
|
|
}
|
|
|
|
for (User *U : GV.users()) {
|
|
auto *GEP = cast<GEPOperator>(U);
|
|
unsigned I = cast<ConstantInt>(GEP->getOperand(2))->getZExtValue();
|
|
if (I >= SplitGlobals.size())
|
|
continue;
|
|
|
|
SmallVector<Value *, 4> Ops;
|
|
Ops.push_back(ConstantInt::get(Int32Ty, 0));
|
|
for (unsigned I = 3; I != GEP->getNumOperands(); ++I)
|
|
Ops.push_back(GEP->getOperand(I));
|
|
|
|
auto *NewGEP = ConstantExpr::getGetElementPtr(
|
|
SplitGlobals[I]->getInitializer()->getType(), SplitGlobals[I], Ops,
|
|
GEP->isInBounds());
|
|
GEP->replaceAllUsesWith(NewGEP);
|
|
}
|
|
|
|
// Finally, remove the original global. Any remaining uses refer to invalid
|
|
// elements of the global, so replace with undef.
|
|
if (!GV.use_empty())
|
|
GV.replaceAllUsesWith(UndefValue::get(GV.getType()));
|
|
GV.eraseFromParent();
|
|
return true;
|
|
}
|
|
|
|
bool splitGlobals(Module &M) {
|
|
// First, see if the module uses either of the llvm.type.test or
|
|
// llvm.type.checked.load intrinsics, which indicates that splitting globals
|
|
// may be beneficial.
|
|
Function *TypeTestFunc =
|
|
M.getFunction(Intrinsic::getName(Intrinsic::type_test));
|
|
Function *TypeCheckedLoadFunc =
|
|
M.getFunction(Intrinsic::getName(Intrinsic::type_checked_load));
|
|
if ((!TypeTestFunc || TypeTestFunc->use_empty()) &&
|
|
(!TypeCheckedLoadFunc || TypeCheckedLoadFunc->use_empty()))
|
|
return false;
|
|
|
|
bool Changed = false;
|
|
for (auto I = M.global_begin(); I != M.global_end();) {
|
|
GlobalVariable &GV = *I;
|
|
++I;
|
|
Changed |= splitGlobal(GV);
|
|
}
|
|
return Changed;
|
|
}
|
|
|
|
struct GlobalSplit : public ModulePass {
|
|
static char ID;
|
|
GlobalSplit() : ModulePass(ID) {
|
|
initializeGlobalSplitPass(*PassRegistry::getPassRegistry());
|
|
}
|
|
bool runOnModule(Module &M) {
|
|
if (skipModule(M))
|
|
return false;
|
|
|
|
return splitGlobals(M);
|
|
}
|
|
};
|
|
|
|
}
|
|
|
|
INITIALIZE_PASS(GlobalSplit, "globalsplit", "Global splitter", false, false)
|
|
char GlobalSplit::ID = 0;
|
|
|
|
ModulePass *llvm::createGlobalSplitPass() {
|
|
return new GlobalSplit;
|
|
}
|
|
|
|
PreservedAnalyses GlobalSplitPass::run(Module &M, ModuleAnalysisManager &AM) {
|
|
if (!splitGlobals(M))
|
|
return PreservedAnalyses::all();
|
|
return PreservedAnalyses::none();
|
|
}
|