mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-21 20:12:56 +02:00
5cb3a1fa72
Summary: This reverts commit r251965. Restore "Move metadata linking after lazy global materialization/linking." This restores commit r251926, with fixes for the LTO bootstrapping bot failure. The bot failure was caused by references from debug metadata to otherwise unreferenced globals. Previously, this caused the lazy linking to link in their defs, which is unnecessary. With this patch, because lazy linking is complete when we encounter the metadata reference, the materializer created a declaration. For definitions such as aliases and comdats, it is illegal to have a declaration. Furthermore, metadata linking should not change code generation. Therefore, when linking of global value bodies is complete, the materializer will simply return nullptr as the new reference for the linked metadata. This change required fixing a different test to ensure there was a real reference to a linkonce global that was only being reference from metadata. Note that the new changes to the only-needed-named-metadata.ll test illustrate an issue with llvm-link -only-needed handling of comdat groups, whereby it may result in an incomplete comdat group. I note this in the test comments, but the issue is orthogonal to this patch (it can be reproduced without any metadata at head). Reviewers: dexonsmith, rafael, tra Subscribers: tobiasvk, joker.eph, llvm-commits Differential Revision: http://reviews.llvm.org/D14447 llvm-svn: 252320
76 lines
2.3 KiB
LLVM
76 lines
2.3 KiB
LLVM
; RUN: llvm-as %S/only-needed-named-metadata.ll -o %t.bc
|
|
; RUN: llvm-as %S/Inputs/only-needed-named-metadata.ll -o %t2.bc
|
|
|
|
; Without -only-needed we should lazy link linkonce globals, and the
|
|
; metadata reference should not cause them to be linked.
|
|
; RUN: llvm-link -S %t2.bc %t.bc | FileCheck %s
|
|
; CHECK-NOT:@U_linkonce
|
|
; CHECK-NOT:@unused_linkonce()
|
|
|
|
; With -only-needed the metadata references should not cause any of the
|
|
; otherwise unreferenced globals to be linked. This also ensures that the
|
|
; metadata references don't provoke the module linker to create declarations,
|
|
; which are illegal for aliases and globals in comdats.
|
|
; Note that doing -only-needed with the comdat shown below leads to a only
|
|
; part of the comdat group being linked, which is not technically correct.
|
|
; RUN: llvm-link -S -only-needed %t2.bc %t.bc | FileCheck %s -check-prefix=ONLYNEEDED
|
|
; RUN: llvm-link -S -internalize -only-needed %t2.bc %t.bc | FileCheck %s -check-prefix=ONLYNEEDED
|
|
; ONLYNEEDED-NOT:@U
|
|
; ONLYNEEDED-NOT:@U_linkonce
|
|
; ONLYNEEDED-NOT:@unused()
|
|
; ONLYNEEDED-NOT:@unused_linkonce()
|
|
; ONLYNEEDED-NOT:@linkoncealias
|
|
; ONLYNEEDED-NOT:@linkoncefunc2()
|
|
; ONLYNEEDED-NOT:@weakalias
|
|
; ONLYNEEDED-NOT:@globalfunc1()
|
|
; ONLYNEEDED-NOT:@analias
|
|
; ONLYNEEDED-NOT:@globalfunc2()
|
|
; ONLYNEEDED-NOT:@c1_c
|
|
; ONLYNEEDED-NOT:@c1()
|
|
|
|
$c1 = comdat any
|
|
@c1_c = global i32 0, comdat($c1)
|
|
define void @c1() comdat {
|
|
ret void
|
|
}
|
|
define void @c1_a() comdat($c1) {
|
|
ret void
|
|
}
|
|
|
|
@X = global i32 5
|
|
@U = global i32 6
|
|
@U_linkonce = linkonce_odr hidden global i32 6
|
|
define i32 @foo() { ret i32 7 }
|
|
define i32 @unused() { ret i32 8 }
|
|
define linkonce_odr hidden i32 @unused_linkonce() { ret i32 8 }
|
|
@linkoncealias = alias void (...), bitcast (void ()* @linkoncefunc2 to void (...)*)
|
|
|
|
@weakalias = weak alias void (...), bitcast (void ()* @globalfunc1 to void (...)*)
|
|
@analias = alias void (...), bitcast (void ()* @globalfunc2 to void (...)*)
|
|
|
|
define void @globalfunc1() #0 {
|
|
entry:
|
|
ret void
|
|
}
|
|
|
|
define void @globalfunc2() #0 {
|
|
entry:
|
|
ret void
|
|
}
|
|
|
|
$linkoncefunc2 = comdat any
|
|
define linkonce_odr void @linkoncefunc2() #0 comdat {
|
|
entry:
|
|
ret void
|
|
}
|
|
|
|
!llvm.named = !{!0, !1, !2, !3, !4, !5, !6, !7}
|
|
!0 = !{i32 ()* @unused}
|
|
!1 = !{i32* @U}
|
|
!2 = !{i32 ()* @unused_linkonce}
|
|
!3 = !{i32* @U_linkonce}
|
|
!4 = !{void (...)* @weakalias}
|
|
!5 = !{void (...)* @analias}
|
|
!6 = !{void (...)* @linkoncealias}
|
|
!7 = !{void ()* @c1}
|