mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 19:23:23 +01:00
f8a414589e
Summary: This clang-tidy check is looking for unsigned integer variables whose initializer starts with an implicit cast from llvm::Register and changes the type of the variable to llvm::Register (dropping the llvm:: where possible). Partial reverts in: X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned& MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register PPCFastISel.cpp - No Register::operator-=() PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned& MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor Manual fixups in: ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned& HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register. PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned& Depends on D65919 Reviewers: arsenm, bogner, craig.topper, RKSimon Reviewed By: arsenm Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D65962 llvm-svn: 369041
211 lines
7.5 KiB
C++
211 lines
7.5 KiB
C++
//===-- UnreachableBlockElim.cpp - Remove unreachable blocks for codegen --===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This pass is an extremely simple version of the SimplifyCFG pass. Its sole
|
|
// job is to delete LLVM basic blocks that are not reachable from the entry
|
|
// node. To do this, it performs a simple depth first traversal of the CFG,
|
|
// then deletes any unvisited nodes.
|
|
//
|
|
// Note that this pass is really a hack. In particular, the instruction
|
|
// selectors for various targets should just not generate code for unreachable
|
|
// blocks. Until LLVM has a more systematic way of defining instruction
|
|
// selectors, however, we cannot really expect them to handle additional
|
|
// complexity.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/CodeGen/UnreachableBlockElim.h"
|
|
#include "llvm/ADT/DepthFirstIterator.h"
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
|
#include "llvm/CodeGen/MachineDominators.h"
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
|
#include "llvm/CodeGen/MachineLoopInfo.h"
|
|
#include "llvm/CodeGen/MachineModuleInfo.h"
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
#include "llvm/CodeGen/Passes.h"
|
|
#include "llvm/CodeGen/TargetInstrInfo.h"
|
|
#include "llvm/IR/CFG.h"
|
|
#include "llvm/IR/Constant.h"
|
|
#include "llvm/IR/Dominators.h"
|
|
#include "llvm/IR/Function.h"
|
|
#include "llvm/IR/Instructions.h"
|
|
#include "llvm/IR/Type.h"
|
|
#include "llvm/Pass.h"
|
|
#include "llvm/Transforms/Utils/BasicBlockUtils.h"
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
class UnreachableBlockElimLegacyPass : public FunctionPass {
|
|
bool runOnFunction(Function &F) override {
|
|
return llvm::EliminateUnreachableBlocks(F);
|
|
}
|
|
|
|
public:
|
|
static char ID; // Pass identification, replacement for typeid
|
|
UnreachableBlockElimLegacyPass() : FunctionPass(ID) {
|
|
initializeUnreachableBlockElimLegacyPassPass(
|
|
*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.addPreserved<DominatorTreeWrapperPass>();
|
|
}
|
|
};
|
|
}
|
|
char UnreachableBlockElimLegacyPass::ID = 0;
|
|
INITIALIZE_PASS(UnreachableBlockElimLegacyPass, "unreachableblockelim",
|
|
"Remove unreachable blocks from the CFG", false, false)
|
|
|
|
FunctionPass *llvm::createUnreachableBlockEliminationPass() {
|
|
return new UnreachableBlockElimLegacyPass();
|
|
}
|
|
|
|
PreservedAnalyses UnreachableBlockElimPass::run(Function &F,
|
|
FunctionAnalysisManager &AM) {
|
|
bool Changed = llvm::EliminateUnreachableBlocks(F);
|
|
if (!Changed)
|
|
return PreservedAnalyses::all();
|
|
PreservedAnalyses PA;
|
|
PA.preserve<DominatorTreeAnalysis>();
|
|
return PA;
|
|
}
|
|
|
|
namespace {
|
|
class UnreachableMachineBlockElim : public MachineFunctionPass {
|
|
bool runOnMachineFunction(MachineFunction &F) override;
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override;
|
|
MachineModuleInfo *MMI;
|
|
public:
|
|
static char ID; // Pass identification, replacement for typeid
|
|
UnreachableMachineBlockElim() : MachineFunctionPass(ID) {}
|
|
};
|
|
}
|
|
char UnreachableMachineBlockElim::ID = 0;
|
|
|
|
INITIALIZE_PASS(UnreachableMachineBlockElim, "unreachable-mbb-elimination",
|
|
"Remove unreachable machine basic blocks", false, false)
|
|
|
|
char &llvm::UnreachableMachineBlockElimID = UnreachableMachineBlockElim::ID;
|
|
|
|
void UnreachableMachineBlockElim::getAnalysisUsage(AnalysisUsage &AU) const {
|
|
AU.addPreserved<MachineLoopInfo>();
|
|
AU.addPreserved<MachineDominatorTree>();
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
bool UnreachableMachineBlockElim::runOnMachineFunction(MachineFunction &F) {
|
|
df_iterator_default_set<MachineBasicBlock*> Reachable;
|
|
bool ModifiedPHI = false;
|
|
|
|
MMI = getAnalysisIfAvailable<MachineModuleInfo>();
|
|
MachineDominatorTree *MDT = getAnalysisIfAvailable<MachineDominatorTree>();
|
|
MachineLoopInfo *MLI = getAnalysisIfAvailable<MachineLoopInfo>();
|
|
|
|
// Mark all reachable blocks.
|
|
for (MachineBasicBlock *BB : depth_first_ext(&F, Reachable))
|
|
(void)BB/* Mark all reachable blocks */;
|
|
|
|
// Loop over all dead blocks, remembering them and deleting all instructions
|
|
// in them.
|
|
std::vector<MachineBasicBlock*> DeadBlocks;
|
|
for (MachineFunction::iterator I = F.begin(), E = F.end(); I != E; ++I) {
|
|
MachineBasicBlock *BB = &*I;
|
|
|
|
// Test for deadness.
|
|
if (!Reachable.count(BB)) {
|
|
DeadBlocks.push_back(BB);
|
|
|
|
// Update dominator and loop info.
|
|
if (MLI) MLI->removeBlock(BB);
|
|
if (MDT && MDT->getNode(BB)) MDT->eraseNode(BB);
|
|
|
|
while (BB->succ_begin() != BB->succ_end()) {
|
|
MachineBasicBlock* succ = *BB->succ_begin();
|
|
|
|
MachineBasicBlock::iterator start = succ->begin();
|
|
while (start != succ->end() && start->isPHI()) {
|
|
for (unsigned i = start->getNumOperands() - 1; i >= 2; i-=2)
|
|
if (start->getOperand(i).isMBB() &&
|
|
start->getOperand(i).getMBB() == BB) {
|
|
start->RemoveOperand(i);
|
|
start->RemoveOperand(i-1);
|
|
}
|
|
|
|
start++;
|
|
}
|
|
|
|
BB->removeSuccessor(BB->succ_begin());
|
|
}
|
|
}
|
|
}
|
|
|
|
// Actually remove the blocks now.
|
|
for (unsigned i = 0, e = DeadBlocks.size(); i != e; ++i) {
|
|
// Remove any call site information for calls in the block.
|
|
for (auto &I : DeadBlocks[i]->instrs())
|
|
if (I.isCall(MachineInstr::IgnoreBundle))
|
|
DeadBlocks[i]->getParent()->updateCallSiteInfo(&I);
|
|
|
|
DeadBlocks[i]->eraseFromParent();
|
|
}
|
|
|
|
// Cleanup PHI nodes.
|
|
for (MachineFunction::iterator I = F.begin(), E = F.end(); I != E; ++I) {
|
|
MachineBasicBlock *BB = &*I;
|
|
// Prune unneeded PHI entries.
|
|
SmallPtrSet<MachineBasicBlock*, 8> preds(BB->pred_begin(),
|
|
BB->pred_end());
|
|
MachineBasicBlock::iterator phi = BB->begin();
|
|
while (phi != BB->end() && phi->isPHI()) {
|
|
for (unsigned i = phi->getNumOperands() - 1; i >= 2; i-=2)
|
|
if (!preds.count(phi->getOperand(i).getMBB())) {
|
|
phi->RemoveOperand(i);
|
|
phi->RemoveOperand(i-1);
|
|
ModifiedPHI = true;
|
|
}
|
|
|
|
if (phi->getNumOperands() == 3) {
|
|
const MachineOperand &Input = phi->getOperand(1);
|
|
const MachineOperand &Output = phi->getOperand(0);
|
|
Register InputReg = Input.getReg();
|
|
Register OutputReg = Output.getReg();
|
|
assert(Output.getSubReg() == 0 && "Cannot have output subregister");
|
|
ModifiedPHI = true;
|
|
|
|
if (InputReg != OutputReg) {
|
|
MachineRegisterInfo &MRI = F.getRegInfo();
|
|
unsigned InputSub = Input.getSubReg();
|
|
if (InputSub == 0 &&
|
|
MRI.constrainRegClass(InputReg, MRI.getRegClass(OutputReg)) &&
|
|
!Input.isUndef()) {
|
|
MRI.replaceRegWith(OutputReg, InputReg);
|
|
} else {
|
|
// The input register to the PHI has a subregister or it can't be
|
|
// constrained to the proper register class or it is undef:
|
|
// insert a COPY instead of simply replacing the output
|
|
// with the input.
|
|
const TargetInstrInfo *TII = F.getSubtarget().getInstrInfo();
|
|
BuildMI(*BB, BB->getFirstNonPHI(), phi->getDebugLoc(),
|
|
TII->get(TargetOpcode::COPY), OutputReg)
|
|
.addReg(InputReg, getRegState(Input), InputSub);
|
|
}
|
|
phi++->eraseFromParent();
|
|
}
|
|
continue;
|
|
}
|
|
|
|
++phi;
|
|
}
|
|
}
|
|
|
|
F.RenumberBlocks();
|
|
|
|
return (!DeadBlocks.empty() || ModifiedPHI);
|
|
}
|