mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 02:52:53 +02:00
c0b486e8f3
Fixes assert in: https://bugs.llvm.org/show_bug.cgi?id=49036
getWasmSection creates sections if they don't exist, but doesn't add them to the Symbols table. This may cause problems in subsequent calls to getOrCreateSymbol which checks this table, the calls createSymbol assuming it doesn't exist, which then checks UsedNames and finds out it does exist, causing an assert on trying to rename a non-temp symbol.
I tried also fixing the somewhat unintuitive forced suffixing (adding `0`), but it turns out that WasmObjectWriter currently assumes these section symbols are unique, so that may have to be a separate fix: https://bugs.llvm.org/show_bug.cgi?id=49252
Also worth noting is that getWasmSection calling createSymbol may not be correct to start with, given that createSymbol seems to assume it is creating non-section symbols. But again, for a future fix.
Related: where some of this was introduced:
|
||
|---|---|---|
| .. | ||
| MCDisassembler | ||
| MCParser | ||
| CMakeLists.txt | ||
| ConstantPools.cpp | ||
| ELFObjectWriter.cpp | ||
| MachObjectWriter.cpp | ||
| MCAsmBackend.cpp | ||
| MCAsmInfo.cpp | ||
| MCAsmInfoCOFF.cpp | ||
| MCAsmInfoDarwin.cpp | ||
| MCAsmInfoELF.cpp | ||
| MCAsmInfoWasm.cpp | ||
| MCAsmInfoXCOFF.cpp | ||
| MCAsmMacro.cpp | ||
| MCAsmStreamer.cpp | ||
| MCAssembler.cpp | ||
| MCCodeEmitter.cpp | ||
| MCCodeView.cpp | ||
| MCContext.cpp | ||
| MCDwarf.cpp | ||
| MCELFObjectTargetWriter.cpp | ||
| MCELFStreamer.cpp | ||
| MCExpr.cpp | ||
| MCFragment.cpp | ||
| MCInst.cpp | ||
| MCInstPrinter.cpp | ||
| MCInstrAnalysis.cpp | ||
| MCInstrDesc.cpp | ||
| MCInstrInfo.cpp | ||
| MCLabel.cpp | ||
| MCLinkerOptimizationHint.cpp | ||
| MCMachObjectTargetWriter.cpp | ||
| MCMachOStreamer.cpp | ||
| MCNullStreamer.cpp | ||
| MCObjectFileInfo.cpp | ||
| MCObjectStreamer.cpp | ||
| MCObjectWriter.cpp | ||
| MCPseudoProbe.cpp | ||
| MCRegisterInfo.cpp | ||
| MCSchedule.cpp | ||
| MCSection.cpp | ||
| MCSectionCOFF.cpp | ||
| MCSectionELF.cpp | ||
| MCSectionMachO.cpp | ||
| MCSectionWasm.cpp | ||
| MCSectionXCOFF.cpp | ||
| MCStreamer.cpp | ||
| MCSubtargetInfo.cpp | ||
| MCSymbol.cpp | ||
| MCSymbolELF.cpp | ||
| MCSymbolXCOFF.cpp | ||
| MCTargetOptions.cpp | ||
| MCTargetOptionsCommandFlags.cpp | ||
| MCValue.cpp | ||
| MCWasmObjectTargetWriter.cpp | ||
| MCWasmStreamer.cpp | ||
| MCWin64EH.cpp | ||
| MCWinCOFFStreamer.cpp | ||
| MCWinEH.cpp | ||
| MCXCOFFObjectTargetWriter.cpp | ||
| MCXCOFFStreamer.cpp | ||
| StringTableBuilder.cpp | ||
| SubtargetFeature.cpp | ||
| WasmObjectWriter.cpp | ||
| WinCOFFObjectWriter.cpp | ||
| XCOFFObjectWriter.cpp | ||