mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 11:02:59 +02:00
9b64cc7de2
This was a real restriction in the original version of SinkIfThenCodeToEnd. Now it's been rewritten, the restriction can be lifted.
As part of this, we handle a very common and useful case where one of the incoming branches is actually conditional. Consider:
if (a)
x(1);
else if (b)
x(2);
This produces the following CFG:
[if]
/ \
[x(1)] [if]
| | \
| | \
| [x(2)] |
\ | /
[ end ]
[end] has two unconditional predecessor arcs and one conditional. The conditional refers to the implicit empty 'else' arc. This same pattern can also be caused by an empty default block in a switch.
We can't sink the call to x() down to end because no call to x() happens on the third incoming arc (assume that x() has sideeffects for the sake of argument; if something is safe to speculate we could indeed sink nevertheless but this cannot happen in the general case and causes many extra selects).
We are now able to detect this case and split off the unconditional arcs to a common successor:
[if]
/ \
[x(1)] [if]
| | \
| | \
| [x(2)] |
\ / |
[sink.split] |
\ /
[ end ]
Now we can sink the call to x() into %sink.split. This can cause significant code simplification in many testcases.
llvm-svn: 280364
255 lines
10 KiB
LLVM
255 lines
10 KiB
LLVM
; RUN: llc < %s -mtriple=aarch64-linux-gnuabi -O2 | FileCheck %s
|
|
|
|
; The following cases are for i16
|
|
|
|
%struct.s_signed_i16 = type { i16, i16, i16 }
|
|
%struct.s_unsigned_i16 = type { i16, i16, i16 }
|
|
|
|
@cost_s_i8_i16 = common global %struct.s_signed_i16 zeroinitializer, align 2
|
|
@cost_u_i16 = common global %struct.s_unsigned_i16 zeroinitializer, align 2
|
|
|
|
define void @test_i16_2cmp_signed_1() {
|
|
; CHECK-LABEL: test_i16_2cmp_signed_1
|
|
; CHECK: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK-NEXT: b.lt
|
|
; CHECK-NOT: cmp
|
|
; CHECK: ret
|
|
entry:
|
|
%0 = load i16, i16* getelementptr inbounds (%struct.s_signed_i16, %struct.s_signed_i16* @cost_s_i8_i16, i64 0, i32 1), align 2
|
|
%1 = load i16, i16* getelementptr inbounds (%struct.s_signed_i16, %struct.s_signed_i16* @cost_s_i8_i16, i64 0, i32 2), align 2
|
|
%cmp = icmp sgt i16 %0, %1
|
|
br i1 %cmp, label %if.then, label %if.else
|
|
|
|
if.then: ; preds = %entry
|
|
store i16 %0, i16* getelementptr inbounds (%struct.s_signed_i16, %struct.s_signed_i16* @cost_s_i8_i16, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.else: ; preds = %entry
|
|
%cmp5 = icmp eq i16 %0, %1
|
|
br i1 %cmp5, label %if.then7, label %if.end8
|
|
|
|
if.then7: ; preds = %if.else
|
|
store i16 %0, i16* getelementptr inbounds (%struct.s_signed_i16, %struct.s_signed_i16* @cost_s_i8_i16, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.end8: ; preds = %if.else, %if.then7, %if.then
|
|
ret void
|
|
}
|
|
|
|
define void @test_i16_2cmp_signed_2() {
|
|
; CHECK-LABEL: test_i16_2cmp_signed_2
|
|
; CHECK: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK-NEXT: b.gt
|
|
; CHECK-NOT: cmp
|
|
; CHECK: b.ge
|
|
entry:
|
|
%0 = load i16, i16* getelementptr inbounds (%struct.s_signed_i16, %struct.s_signed_i16* @cost_s_i8_i16, i64 0, i32 1), align 2
|
|
%1 = load i16, i16* getelementptr inbounds (%struct.s_signed_i16, %struct.s_signed_i16* @cost_s_i8_i16, i64 0, i32 2), align 2
|
|
%cmp = icmp sgt i16 %0, %1
|
|
br i1 %cmp, label %if.then, label %if.else
|
|
|
|
if.then: ; preds = %entry
|
|
store i16 %0, i16* getelementptr inbounds (%struct.s_signed_i16, %struct.s_signed_i16* @cost_s_i8_i16, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.else: ; preds = %entry
|
|
%cmp5 = icmp slt i16 %0, %1
|
|
br i1 %cmp5, label %if.then7, label %if.end8
|
|
|
|
if.then7: ; preds = %if.else
|
|
store i16 %1, i16* getelementptr inbounds (%struct.s_signed_i16, %struct.s_signed_i16* @cost_s_i8_i16, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.end8: ; preds = %if.else, %if.then7, %if.then
|
|
ret void
|
|
}
|
|
|
|
define void @test_i16_2cmp_unsigned_1() {
|
|
; CHECK-LABEL: test_i16_2cmp_unsigned_1
|
|
; CHECK: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK-NEXT: b.lo
|
|
; CHECK-NOT: cmp
|
|
; CHECK: ret
|
|
entry:
|
|
%0 = load i16, i16* getelementptr inbounds (%struct.s_unsigned_i16, %struct.s_unsigned_i16* @cost_u_i16, i64 0, i32 1), align 2
|
|
%1 = load i16, i16* getelementptr inbounds (%struct.s_unsigned_i16, %struct.s_unsigned_i16* @cost_u_i16, i64 0, i32 2), align 2
|
|
%cmp = icmp ugt i16 %0, %1
|
|
br i1 %cmp, label %if.then, label %if.else
|
|
|
|
if.then: ; preds = %entry
|
|
store i16 %0, i16* getelementptr inbounds (%struct.s_unsigned_i16, %struct.s_unsigned_i16* @cost_u_i16, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.else: ; preds = %entry
|
|
%cmp5 = icmp eq i16 %0, %1
|
|
br i1 %cmp5, label %if.then7, label %if.end8
|
|
|
|
if.then7: ; preds = %if.else
|
|
store i16 %0, i16* getelementptr inbounds (%struct.s_unsigned_i16, %struct.s_unsigned_i16* @cost_u_i16, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.end8: ; preds = %if.else, %if.then7, %if.then
|
|
ret void
|
|
}
|
|
|
|
define void @test_i16_2cmp_unsigned_2() {
|
|
; CHECK-LABEL: test_i16_2cmp_unsigned_2
|
|
; CHECK: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK-NEXT: b.hi
|
|
; CHECK-NOT: cmp
|
|
; CHECK: b.hs
|
|
entry:
|
|
%0 = load i16, i16* getelementptr inbounds (%struct.s_unsigned_i16, %struct.s_unsigned_i16* @cost_u_i16, i64 0, i32 1), align 2
|
|
%1 = load i16, i16* getelementptr inbounds (%struct.s_unsigned_i16, %struct.s_unsigned_i16* @cost_u_i16, i64 0, i32 2), align 2
|
|
%cmp = icmp ugt i16 %0, %1
|
|
br i1 %cmp, label %if.then, label %if.else
|
|
|
|
if.then: ; preds = %entry
|
|
store i16 %0, i16* getelementptr inbounds (%struct.s_unsigned_i16, %struct.s_unsigned_i16* @cost_u_i16, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.else: ; preds = %entry
|
|
%cmp5 = icmp ult i16 %0, %1
|
|
br i1 %cmp5, label %if.then7, label %if.end8
|
|
|
|
if.then7: ; preds = %if.else
|
|
store i16 %1, i16* getelementptr inbounds (%struct.s_unsigned_i16, %struct.s_unsigned_i16* @cost_u_i16, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.end8: ; preds = %if.else, %if.then7, %if.then
|
|
ret void
|
|
}
|
|
|
|
; The following cases are for i8
|
|
|
|
%struct.s_signed_i8 = type { i8, i8, i8 }
|
|
%struct.s_unsigned_i8 = type { i8, i8, i8 }
|
|
|
|
@cost_s = common global %struct.s_signed_i8 zeroinitializer, align 2
|
|
@cost_u_i8 = common global %struct.s_unsigned_i8 zeroinitializer, align 2
|
|
|
|
|
|
define void @test_i8_2cmp_signed_1() {
|
|
; CHECK-LABEL: test_i8_2cmp_signed_1
|
|
; CHECK: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK-NEXT: b.lt
|
|
; CHECK-NOT: cmp
|
|
; CHECK: ret
|
|
entry:
|
|
%0 = load i8, i8* getelementptr inbounds (%struct.s_signed_i8, %struct.s_signed_i8* @cost_s, i64 0, i32 1), align 2
|
|
%1 = load i8, i8* getelementptr inbounds (%struct.s_signed_i8, %struct.s_signed_i8* @cost_s, i64 0, i32 2), align 2
|
|
%cmp = icmp sgt i8 %0, %1
|
|
br i1 %cmp, label %if.then, label %if.else
|
|
|
|
if.then: ; preds = %entry
|
|
store i8 %0, i8* getelementptr inbounds (%struct.s_signed_i8, %struct.s_signed_i8* @cost_s, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.else: ; preds = %entry
|
|
%cmp5 = icmp eq i8 %0, %1
|
|
br i1 %cmp5, label %if.then7, label %if.end8
|
|
|
|
if.then7: ; preds = %if.else
|
|
store i8 %0, i8* getelementptr inbounds (%struct.s_signed_i8, %struct.s_signed_i8* @cost_s, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.end8: ; preds = %if.else, %if.then7, %if.then
|
|
ret void
|
|
}
|
|
|
|
define void @test_i8_2cmp_signed_2() {
|
|
; CHECK-LABEL: test_i8_2cmp_signed_2
|
|
; CHECK: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK-NEXT: b.gt
|
|
; CHECK-NOT: cmp
|
|
; CHECK: b.ge
|
|
entry:
|
|
%0 = load i8, i8* getelementptr inbounds (%struct.s_signed_i8, %struct.s_signed_i8* @cost_s, i64 0, i32 1), align 2
|
|
%1 = load i8, i8* getelementptr inbounds (%struct.s_signed_i8, %struct.s_signed_i8* @cost_s, i64 0, i32 2), align 2
|
|
%cmp = icmp sgt i8 %0, %1
|
|
br i1 %cmp, label %if.then, label %if.else
|
|
|
|
if.then: ; preds = %entry
|
|
store i8 %0, i8* getelementptr inbounds (%struct.s_signed_i8, %struct.s_signed_i8* @cost_s, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.else: ; preds = %entry
|
|
%cmp5 = icmp slt i8 %0, %1
|
|
br i1 %cmp5, label %if.then7, label %if.end8
|
|
|
|
if.then7: ; preds = %if.else
|
|
store i8 %1, i8* getelementptr inbounds (%struct.s_signed_i8, %struct.s_signed_i8* @cost_s, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.end8: ; preds = %if.else, %if.then7, %if.then
|
|
ret void
|
|
}
|
|
|
|
define void @test_i8_2cmp_unsigned_1() {
|
|
; CHECK-LABEL: test_i8_2cmp_unsigned_1
|
|
; CHECK: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK-NEXT: b.lo
|
|
; CHECK-NOT: cmp
|
|
; CHECK: ret
|
|
entry:
|
|
%0 = load i8, i8* getelementptr inbounds (%struct.s_unsigned_i8, %struct.s_unsigned_i8* @cost_u_i8, i64 0, i32 1), align 2
|
|
%1 = load i8, i8* getelementptr inbounds (%struct.s_unsigned_i8, %struct.s_unsigned_i8* @cost_u_i8, i64 0, i32 2), align 2
|
|
%cmp = icmp ugt i8 %0, %1
|
|
br i1 %cmp, label %if.then, label %if.else
|
|
|
|
if.then: ; preds = %entry
|
|
store i8 %0, i8* getelementptr inbounds (%struct.s_unsigned_i8, %struct.s_unsigned_i8* @cost_u_i8, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.else: ; preds = %entry
|
|
%cmp5 = icmp eq i8 %0, %1
|
|
br i1 %cmp5, label %if.then7, label %if.end8
|
|
|
|
if.then7: ; preds = %if.else
|
|
store i8 %0, i8* getelementptr inbounds (%struct.s_unsigned_i8, %struct.s_unsigned_i8* @cost_u_i8, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.end8: ; preds = %if.else, %if.then7, %if.then
|
|
ret void
|
|
}
|
|
|
|
define void @test_i8_2cmp_unsigned_2() {
|
|
; CHECK-LABEL: test_i8_2cmp_unsigned_2
|
|
; CHECK: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK-NEXT: b.hi
|
|
; CHECK-NOT: cmp
|
|
; CHECK: b.hs
|
|
entry:
|
|
%0 = load i8, i8* getelementptr inbounds (%struct.s_unsigned_i8, %struct.s_unsigned_i8* @cost_u_i8, i64 0, i32 1), align 2
|
|
%1 = load i8, i8* getelementptr inbounds (%struct.s_unsigned_i8, %struct.s_unsigned_i8* @cost_u_i8, i64 0, i32 2), align 2
|
|
%cmp = icmp ugt i8 %0, %1
|
|
br i1 %cmp, label %if.then, label %if.else
|
|
|
|
if.then: ; preds = %entry
|
|
store i8 %0, i8* getelementptr inbounds (%struct.s_unsigned_i8, %struct.s_unsigned_i8* @cost_u_i8, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.else: ; preds = %entry
|
|
%cmp5 = icmp ult i8 %0, %1
|
|
br i1 %cmp5, label %if.then7, label %if.end8
|
|
|
|
if.then7: ; preds = %if.else
|
|
store i8 %1, i8* getelementptr inbounds (%struct.s_unsigned_i8, %struct.s_unsigned_i8* @cost_u_i8, i64 0, i32 0), align 2
|
|
br label %if.end8
|
|
|
|
if.end8: ; preds = %if.else, %if.then7, %if.then
|
|
ret void
|
|
}
|
|
|
|
; Make sure the case below won't crash.
|
|
|
|
; The optimization of ZERO_EXTEND and SIGN_EXTEND in type legalization stage can't assert
|
|
; the operand of a set_cc is always a TRUNCATE.
|
|
|
|
define i1 @foo(float %inl, float %inr) {
|
|
%lval = fptosi float %inl to i8
|
|
%rval = fptosi float %inr to i8
|
|
%sum = icmp eq i8 %lval, %rval
|
|
ret i1 %sum
|
|
}
|