mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 11:13:28 +01:00
185ad9b7c5
MemorySSA currently creates MemoryAccesses for lifetime intrinsics, and sometimes treats them as clobbers. This may/may not be the best way forward, but while we're doing it, we should consider MayAlias/PartialAlias to be clobbers. The ideal fix here is probably to remove all of this reasoning about lifetimes from MemorySSA + put it into the passes that need to care. But that's a wayyy broader fix that needs some consensus, and we have miscompiles + a release branch today, and this should solve the miscompiles just as well. differential revision is D43269. Landing without an explicit LGTM (and without using the special please-autoclose-this syntax) so we can still use that revision as a place to decide what the right fix here is. llvm-svn: 339411
151 lines
4.1 KiB
LLVM
151 lines
4.1 KiB
LLVM
; RUN: opt < %s -S -early-cse | FileCheck %s --check-prefix=CHECK-NOMEMSSA
|
|
; RUN: opt < %s -S -basicaa -early-cse-memssa | FileCheck %s
|
|
; RUN: opt < %s -S -passes='early-cse' | FileCheck %s --check-prefix=CHECK-NOMEMSSA
|
|
; RUN: opt < %s -S -aa-pipeline=basic-aa -passes='early-cse-memssa' | FileCheck %s
|
|
|
|
@G1 = global i32 zeroinitializer
|
|
@G2 = global i32 zeroinitializer
|
|
@G3 = global i32 zeroinitializer
|
|
|
|
;; Simple load value numbering across non-clobbering store.
|
|
; CHECK-LABEL: @test1(
|
|
; CHECK-NOMEMSSA-LABEL: @test1(
|
|
define i32 @test1() {
|
|
%V1 = load i32, i32* @G1
|
|
store i32 0, i32* @G2
|
|
%V2 = load i32, i32* @G1
|
|
; CHECK-NOMEMSSA: sub i32 %V1, %V2
|
|
%Diff = sub i32 %V1, %V2
|
|
ret i32 %Diff
|
|
; CHECK: ret i32 0
|
|
}
|
|
|
|
;; Simple dead store elimination across non-clobbering store.
|
|
; CHECK-LABEL: @test2(
|
|
; CHECK-NOMEMSSA-LABEL: @test2(
|
|
define void @test2() {
|
|
entry:
|
|
%V1 = load i32, i32* @G1
|
|
; CHECK: store i32 0, i32* @G2
|
|
store i32 0, i32* @G2
|
|
; CHECK-NOT: store
|
|
; CHECK-NOMEMSSA: store i32 %V1, i32* @G1
|
|
store i32 %V1, i32* @G1
|
|
ret void
|
|
}
|
|
|
|
;; Check that memoryphi optimization happens during EarlyCSE, enabling
|
|
;; more load CSE opportunities.
|
|
; CHECK-LABEL: @test_memphiopt(
|
|
; CHECK-NOMEMSSA-LABEL: @test_memphiopt(
|
|
define void @test_memphiopt(i1 %c, i32* %p) {
|
|
; CHECK-LABEL: entry:
|
|
; CHECK-NOMEMSSA-LABEL: entry:
|
|
entry:
|
|
; CHECK: load
|
|
; CHECK-NOMEMSSA: load
|
|
%v1 = load i32, i32* @G1
|
|
br i1 %c, label %then, label %end
|
|
|
|
; CHECK-LABEL: then:
|
|
; CHECK-NOMEMSSA-LABEL: then:
|
|
then:
|
|
; CHECK: load
|
|
; CHECK-NOMEMSSA: load
|
|
%pv = load i32, i32* %p
|
|
; CHECK-NOT: store
|
|
; CHECK-NOMEMSSA-NOT: store
|
|
store i32 %pv, i32* %p
|
|
br label %end
|
|
|
|
; CHECK-LABEL: end:
|
|
; CHECK-NOMEMSSA-LABEL: end:
|
|
end:
|
|
; CHECK-NOT: load
|
|
; CHECK-NOMEMSSA: load
|
|
%v2 = load i32, i32* @G1
|
|
%sum = add i32 %v1, %v2
|
|
store i32 %sum, i32* @G2
|
|
ret void
|
|
}
|
|
|
|
|
|
;; Check that MemoryPhi optimization and MemoryUse re-optimization
|
|
;; happens during EarlyCSE, enabling more load CSE opportunities.
|
|
; CHECK-LABEL: @test_memphiopt2(
|
|
; CHECK-NOMEMSSA-LABEL: @test_memphiopt2(
|
|
define void @test_memphiopt2(i1 %c, i32* %p) {
|
|
; CHECK-LABEL: entry:
|
|
; CHECK-NOMEMSSA-LABEL: entry:
|
|
entry:
|
|
; CHECK: load
|
|
; CHECK-NOMEMSSA: load
|
|
%v1 = load i32, i32* @G1
|
|
; CHECK: store
|
|
; CHECK-NOMEMSSA: store
|
|
store i32 %v1, i32* @G2
|
|
br i1 %c, label %then, label %end
|
|
|
|
; CHECK-LABEL: then:
|
|
; CHECK-NOMEMSSA-LABEL: then:
|
|
then:
|
|
; CHECK: load
|
|
; CHECK-NOMEMSSA: load
|
|
%pv = load i32, i32* %p
|
|
; CHECK-NOT: store
|
|
; CHECK-NOMEMSSA-NOT: store
|
|
store i32 %pv, i32* %p
|
|
br label %end
|
|
|
|
; CHECK-LABEL: end:
|
|
; CHECK-NOMEMSSA-LABEL: end:
|
|
end:
|
|
; CHECK-NOT: load
|
|
; CHECK-NOMEMSSA: load
|
|
%v2 = load i32, i32* @G1
|
|
store i32 %v2, i32* @G3
|
|
ret void
|
|
}
|
|
|
|
;; Check that we respect lifetime.start/lifetime.end intrinsics when deleting
|
|
;; stores that, without the lifetime calls, would be writebacks.
|
|
; CHECK-LABEL: @test_writeback_lifetimes(
|
|
; CHECK-NOMEMSSA-LABEL: @test_writeback_lifetimes(
|
|
define void @test_writeback_lifetimes(i32* %p) {
|
|
entry:
|
|
%q = getelementptr i32, i32* %p, i64 1
|
|
%pv = load i32, i32* %p
|
|
%qv = load i32, i32* %q
|
|
call void @llvm.lifetime.end.p0i8(i64 8, i32* %p)
|
|
call void @llvm.lifetime.start.p0i8(i64 8, i32* %p)
|
|
; CHECK: store i32 %pv
|
|
; CHECK-NOMEMSSA-LABEL: store i32 %pv
|
|
store i32 %pv, i32* %p
|
|
; CHECK: store i32 %qv, i32* %q
|
|
; CHECK-NOMEMSSA-LABEL: store i32 %qv, i32* %q
|
|
store i32 %qv, i32* %q
|
|
ret void
|
|
}
|
|
|
|
;; Check that we respect lifetime.start/lifetime.end intrinsics when deleting
|
|
;; stores that, without the lifetime calls, would be writebacks.
|
|
; CHECK-LABEL: @test_writeback_lifetimes_multi_arg(
|
|
; CHECK-NOMEMSSA-LABEL: @test_writeback_lifetimes_multi_arg(
|
|
define void @test_writeback_lifetimes_multi_arg(i32* %p, i32* %q) {
|
|
entry:
|
|
%pv = load i32, i32* %p
|
|
%qv = load i32, i32* %q
|
|
call void @llvm.lifetime.end.p0i8(i64 8, i32* %p)
|
|
call void @llvm.lifetime.start.p0i8(i64 8, i32* %p)
|
|
; CHECK: store i32 %pv
|
|
; CHECK-NOMEMSSA-LABEL: store i32 %pv
|
|
store i32 %pv, i32* %p
|
|
; CHECK: store i32 %qv, i32* %q
|
|
; CHECK-NOMEMSSA-LABEL: store i32 %qv, i32* %q
|
|
store i32 %qv, i32* %q
|
|
ret void
|
|
}
|
|
|
|
declare void @llvm.lifetime.end.p0i8(i64, i32*)
|
|
declare void @llvm.lifetime.start.p0i8(i64, i32*)
|