mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 03:33:20 +01:00
a86792ba95
If there is a dag node with a variable number of operands that has at least N operands (for some non-negative N), and multiple patterns with that node with different number of operands, we would drop the number of operands check in patterns with N operands, presumably because it's guaranteed in such case that none of the per-operand checks will access the operand list out-of-bounds. Except semantically the check is about having exactly N operands, not at least N operands, and a backend might rely on it to disambiguate different patterns. In this patch we change the condition on emitting the number of operands check from "the instruction is not guaranteed to have at least as many operands as are checked by the pattern being matched" to "the instruction is not guaranteed to have a specific number of operands". We're relying (still) on the rest of the CodeGenPatterns mechanics to validate that the pattern itself doesn't try to access more operands than there is in the instruction in cases when the instruction does have fixed number of operands, and on the machine verifier to validate at runtime that particular MIs like that satisfy the constraint as well. Reviewers: dsanders, qcolombet Reviewed By: qcolombet Subscribers: arsenm, rovka, Petar.Avramovic, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D69653 |
||
|---|---|---|
| .. | ||
| benchmark | ||
| bugpoint | ||
| count | ||
| crosstool | ||
| docker | ||
| emacs | ||
| FileCheck | ||
| fpcmp | ||
| gdb-scripts | ||
| git-svn | ||
| gn | ||
| jedit | ||
| kate | ||
| KillTheDoctor | ||
| lint | ||
| lit | ||
| llvm-build | ||
| llvm-lit | ||
| llvm-locstats | ||
| LLVMVisualizers | ||
| Misc | ||
| not | ||
| PerfectShuffle | ||
| release | ||
| Reviewing | ||
| sanitizers | ||
| TableGen | ||
| Target/ARM | ||
| testgen | ||
| textmate | ||
| unittest | ||
| UpdateTestChecks | ||
| valgrind | ||
| vim | ||
| vscode | ||
| yaml-bench | ||
| abtest.py | ||
| add_argument_names.py | ||
| bisect | ||
| bisect-skip-count | ||
| bugpoint_gisel_reducer.py | ||
| check-each-file | ||
| chunk-print-before-all.py | ||
| clang-parse-diagnostics-file | ||
| codegen-diff | ||
| collect_and_build_with_pgo.py | ||
| countloc.sh | ||
| create_ladder_graph.py | ||
| demangle_tree.py | ||
| DSAclean.py | ||
| DSAextract.py | ||
| extract_symbols.py | ||
| extract_vplan.py | ||
| findmisopt | ||
| findoptdiff | ||
| findsym.pl | ||
| GenLibDeps.pl | ||
| GetRepositoryPath | ||
| GetSourceVersion | ||
| getsrcs.sh | ||
| indirect_calls.py | ||
| lldbDataFormatters.py | ||
| llvm-compilers-check | ||
| llvm-gisel-cov.py | ||
| llvm-native-gxx | ||
| llvm.grm | ||
| LLVMBuild.txt | ||
| llvmdo | ||
| llvmgrep | ||
| prepare-code-coverage-artifact.py | ||
| schedcover.py | ||
| shuffle_fuzz.py | ||
| shuffle_select_fuzz_tester.py | ||
| sort_includes.py | ||
| unicode-case-fold.py | ||
| update_analyze_test_checks.py | ||
| update_cc_test_checks.py | ||
| update_llc_test_checks.py | ||
| update_mca_test_checks.py | ||
| update_mir_test_checks.py | ||
| update_test_checks.py | ||
| UpdateCMakeLists.pl | ||
| wciia.py | ||