mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 10:42:39 +01:00
d531bf5b5c
See http://lists.llvm.org/pipermail/llvm-dev/2017-June/113975.html for a related previous discussion. Many tools install signal handlers to print stack traces and optionally symbolize the addresses with an external program 'llvm-symbolizer' (when searching for 'llvm-symbolizer', the directory containg the executable is preferred over PATH). 'llvm-symbolizer' can be slow if the executable is large and/or if llvm-symbolizer' itself is under-optimized. For example, my 'llvm-lto2' from a -DCMAKE_BUILD_TYPE=Debug build is 443MiB. The 'llvm-symbolizer' from the same build takes ~2s to symbolize it. (An optimized 'llvm-symbolizer' takes 0.34s). A crashed clang may take more than 5s to symbolize a stack trace. If a test file has several `not --crash` RUN lines. It can be very slow in a Debug build. This patch makes `not --crash` set an environment variable to suppress symbolization. This is similar to D33804 which uses a command line option. I pick 'symbolization' instead of 'symbolication' because the former is used much more commonly and its stem matches 'llvm-symbolizer'. Also set LLVM_DISABLE_CRASH_REPORT=1, which is currently only applicable on `__APPLE__`. Reviewed By: dblaikie, aganea Differential Revision: https://reviews.llvm.org/D86170
82 lines
2.2 KiB
C++
82 lines
2.2 KiB
C++
//===- not.cpp - The 'not' testing tool -----------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
// Usage:
|
|
// not cmd
|
|
// Will return true if cmd doesn't crash and returns false.
|
|
// not --crash cmd
|
|
// Will return true if cmd crashes (e.g. for testing crash reporting).
|
|
|
|
#include "llvm/Support/Program.h"
|
|
#include "llvm/Support/WithColor.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
#ifdef _WIN32
|
|
#include <windows.h>
|
|
#endif
|
|
|
|
using namespace llvm;
|
|
|
|
int main(int argc, const char **argv) {
|
|
bool ExpectCrash = false;
|
|
|
|
++argv;
|
|
--argc;
|
|
|
|
if (argc > 0 && StringRef(argv[0]) == "--crash") {
|
|
++argv;
|
|
--argc;
|
|
ExpectCrash = true;
|
|
|
|
// Crash is expected, so disable crash report and symbolization to reduce
|
|
// output and avoid potentially slow symbolization.
|
|
#ifdef _WIN32
|
|
SetEnvironmentVariableA("LLVM_DISABLE_CRASH_REPORT", "1");
|
|
SetEnvironmentVariableA("LLVM_DISABLE_SYMBOLIZATION", "1");
|
|
#else
|
|
setenv("LLVM_DISABLE_CRASH_REPORT", "1", 0);
|
|
setenv("LLVM_DISABLE_SYMBOLIZATION", "1", 0);
|
|
#endif
|
|
}
|
|
|
|
if (argc == 0)
|
|
return 1;
|
|
|
|
auto Program = sys::findProgramByName(argv[0]);
|
|
if (!Program) {
|
|
WithColor::error() << "unable to find `" << argv[0]
|
|
<< "' in PATH: " << Program.getError().message() << "\n";
|
|
return 1;
|
|
}
|
|
|
|
std::vector<StringRef> Argv;
|
|
Argv.reserve(argc);
|
|
for (int i = 0; i < argc; ++i)
|
|
Argv.push_back(argv[i]);
|
|
std::string ErrMsg;
|
|
int Result = sys::ExecuteAndWait(*Program, Argv, None, {}, 0, 0, &ErrMsg);
|
|
#ifdef _WIN32
|
|
// Handle abort() in msvcrt -- It has exit code as 3. abort(), aka
|
|
// unreachable, should be recognized as a crash. However, some binaries use
|
|
// exit code 3 on non-crash failure paths, so only do this if we expect a
|
|
// crash.
|
|
if (ExpectCrash && Result == 3)
|
|
Result = -3;
|
|
#endif
|
|
if (Result < 0) {
|
|
WithColor::error() << ErrMsg << "\n";
|
|
if (ExpectCrash)
|
|
return 0;
|
|
return 1;
|
|
}
|
|
|
|
if (ExpectCrash)
|
|
return 1;
|
|
|
|
return Result == 0;
|
|
}
|