mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-29 23:12:55 +01:00
3bb84c9bcc
The C and C++ semantics for compare_exchange require it to return a bool
indicating success. This gets mapped to LLVM IR which follows each cmpxchg with
an icmp of the value loaded against the desired value.
When lowered to ldxr/stxr loops, this extra comparison is redundant: its
results are implicit in the control-flow of the function.
This commit makes two changes: it replaces that icmp with appropriate PHI
nodes, and then makes sure earlyCSE is called after expansion to actually make
use of the opportunities revealed.
I've also added -{arm,aarch64}-enable-atomic-tidy options, so that
existing fragile tests aren't perturbed too much by the change. Many
of them either rely on undef/unreachable too pervasively to be
restored to something well-defined (particularly while making sure
they test the same obscure assert from many years ago), or depend on a
particular CFG shape, which is disrupted by SimplifyCFG.
rdar://problem/16227836
llvm-svn: 209883
35 lines
666 B
LLVM
35 lines
666 B
LLVM
; rdar://8465407
|
|
; RUN: llc < %s -mtriple=thumbv7-apple-ios -arm-atomic-cfg-tidy=0 | FileCheck %s
|
|
|
|
%struct.buf = type opaque
|
|
|
|
declare void @bar() nounwind optsize
|
|
|
|
define void @foo() nounwind optsize {
|
|
; CHECK-LABEL: foo:
|
|
; CHECK: push
|
|
; CHECK: mov r7, sp
|
|
; CHECK: sub sp, #4
|
|
entry:
|
|
%m.i = alloca %struct.buf*, align 4
|
|
br label %bb
|
|
|
|
bb:
|
|
br i1 undef, label %bb3, label %bb2
|
|
|
|
bb2:
|
|
call void @bar() nounwind optsize
|
|
br i1 undef, label %bb, label %bb3
|
|
|
|
bb3:
|
|
br i1 undef, label %return, label %bb
|
|
|
|
return:
|
|
; CHECK: %return
|
|
; 'mov sp, r7' would have left sp in an invalid state
|
|
; CHECK-NOT: mov sp, r7
|
|
; CHECK-NOT: sub, sp, #4
|
|
; CHECK: add sp, #4
|
|
ret void
|
|
}
|