mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-02-01 05:01:59 +01:00
4e23f235e0
Summary:
This fixes PR31105.
There is code trying to delete dead code that does so by e.g. checking if
the single predecessor of a block is the block itself.
That check fails on a block like this
bb:
br i1 undef, label %bb, label %bb
since that has two (identical) predecessors.
However, after the check for dead blocks there is a call to
ConstantFoldTerminator on the basic block, and that call simplifies the
block to
bb:
br label %bb
Therefore we now do the call to ConstantFoldTerminator before the check if
the block is dead, so it can realize that it really is.
The original behavior lead to the block not being removed, but it was
simplified as above, and then we did a call to
Dest->replaceAllUsesWith(&*I);
with old and new being equal, and an assertion triggered.
Reviewers: chandlerc, fhahn
Reviewed By: fhahn
Subscribers: eraman, llvm-commits
Differential Revision: https://reviews.llvm.org/D51280
llvm-svn: 340820
33 lines
782 B
LLVM
33 lines
782 B
LLVM
; RUN: opt -S -o - %s -inline | FileCheck %s
|
|
|
|
define void @f1() {
|
|
bb.0:
|
|
br i1 false, label %bb.2, label %bb.1
|
|
|
|
bb.1: ; preds = %bb.0
|
|
br label %bb.2
|
|
|
|
bb.2: ; preds = %bb.0, %bb.1
|
|
%tmp0 = phi i1 [ true, %bb.1 ], [ false, %bb.0 ]
|
|
br i1 %tmp0, label %bb.4, label %bb.3
|
|
|
|
bb.3: ; preds = %bb.3, %bb.3
|
|
br i1 undef, label %bb.3, label %bb.3
|
|
|
|
bb.4: ; preds = %bb.2
|
|
ret void
|
|
}
|
|
|
|
define void @f2() {
|
|
bb.0:
|
|
call void @f1()
|
|
ret void
|
|
}
|
|
|
|
; f1 should be inlined into f2 and simplified/collapsed to nothing.
|
|
|
|
; CHECK-LABEL: define void @f2() {
|
|
; CHECK-NEXT: bb.0:
|
|
; CHECK-NEXT: ret void
|
|
; CHECK-NEXT: }
|