mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-01-31 20:51:52 +01:00
adcb0c2b69
Summary: This patch fixes a bug that originated from passing a virtual exit block (nullptr) to `MachinePostDominatorTee::findNearestCommonDominator` and resulted in assertion failures inside its callee. It also applies a small cleanup to the class. The patch introduces a new function in PDT that given a list of `MachineBasicBlock`s finds their NCD. The new overload of `findNearestCommonDominator` handles virtual root correctly. Note that similar handling of virtual root nodes is not necessary in (forward) `DominatorTree`s, as right now they don't use virtual roots. Reviewers: tstellar, tpr, nhaehnle, arsenm, NutshellySima, grosser, hliao Reviewed By: hliao Subscribers: hliao, kzhuravl, jvesely, wdng, yaxunl, dstuttard, t-tye, hiraditya, llvm-commits Tags: #amdgpu, #llvm Differential Revision: https://reviews.llvm.org/D67974 llvm-svn: 372874
70 lines
2.1 KiB
C++
70 lines
2.1 KiB
C++
//===- MachinePostDominators.cpp -Machine Post Dominator Calculation ------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements simple dominator construction algorithms for finding
|
|
// post dominators on machine functions.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/CodeGen/MachinePostDominators.h"
|
|
|
|
#include "llvm/ADT/STLExtras.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace llvm {
|
|
template class DominatorTreeBase<MachineBasicBlock, true>; // PostDomTreeBase
|
|
}
|
|
|
|
char MachinePostDominatorTree::ID = 0;
|
|
|
|
//declare initializeMachinePostDominatorTreePass
|
|
INITIALIZE_PASS(MachinePostDominatorTree, "machinepostdomtree",
|
|
"MachinePostDominator Tree Construction", true, true)
|
|
|
|
MachinePostDominatorTree::MachinePostDominatorTree()
|
|
: MachineFunctionPass(ID), PDT(nullptr) {
|
|
initializeMachinePostDominatorTreePass(*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
FunctionPass *MachinePostDominatorTree::createMachinePostDominatorTreePass() {
|
|
return new MachinePostDominatorTree();
|
|
}
|
|
|
|
bool MachinePostDominatorTree::runOnMachineFunction(MachineFunction &F) {
|
|
PDT = std::make_unique<PostDomTreeT>();
|
|
PDT->recalculate(F);
|
|
return false;
|
|
}
|
|
|
|
void MachinePostDominatorTree::getAnalysisUsage(AnalysisUsage &AU) const {
|
|
AU.setPreservesAll();
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
MachineBasicBlock *MachinePostDominatorTree::findNearestCommonDominator(
|
|
ArrayRef<MachineBasicBlock *> Blocks) const {
|
|
assert(!Blocks.empty());
|
|
|
|
MachineBasicBlock *NCD = Blocks.front();
|
|
for (MachineBasicBlock *BB : Blocks.drop_front()) {
|
|
NCD = PDT->findNearestCommonDominator(NCD, BB);
|
|
|
|
// Stop when the root is reached.
|
|
if (PDT->isVirtualRoot(PDT->getNode(NCD)))
|
|
return nullptr;
|
|
}
|
|
|
|
return NCD;
|
|
}
|
|
|
|
void MachinePostDominatorTree::print(llvm::raw_ostream &OS,
|
|
const Module *M) const {
|
|
PDT->print(OS);
|
|
}
|