mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-24 03:33:20 +01:00
f9f5076648
A subtle bug was found where attempting to copy a non-const function_ref lvalue would actually invoke the generic forwarding constructor (as it was a closer match - being T& rather than the const T& of the implicit copy constructor). In the particular case this lead to a dangling function_ref member (since it had referenced the function_ref passed by value to its ctor, rather than the outer function_ref that was still alive) SFINAE the converting constructor to not be considered if the copy constructor is available and demonstrate that this causes the copy to refer to the original functor, not to the function_ref it was copied from. (without the code change, the test would fail as Y would be referencing X and Y() would see the result of the mutation to X, ie: 2) llvm-svn: 221753
29 lines
745 B
C++
29 lines
745 B
C++
//===- llvm/unittest/ADT/MakeUniqueTest.cpp - make_unique unit tests ------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/ADT/STLExtras.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
// Ensure that copies of a function_ref copy the underlying state rather than
|
|
// causing one function_ref to chain to the next.
|
|
TEST(FunctionRefTest, Copy) {
|
|
auto A = [] { return 1; };
|
|
auto B = [] { return 2; };
|
|
function_ref<int()> X = A;
|
|
function_ref<int()> Y = X;
|
|
X = B;
|
|
EXPECT_EQ(1, Y());
|
|
}
|
|
|
|
}
|