mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-21 03:53:04 +02:00
0c1aee0b16
As a follow-up to r246098, require `DISubprogram` definitions
(`isDefinition: true`) to be 'distinct'. Specifically, add an assembler
check, a verifier check, and bitcode upgrading logic to combat testcase
bitrot after the `DIBuilder` change.
While working on the testcases, I realized that
test/Linker/subprogram-linkonce-weak-odr.ll isn't relevant anymore. Its
purpose was to check for a corner case in PR22792 where two subprogram
definitions match exactly and share the same metadata node. The new
verifier check, requiring that subprogram definitions are 'distinct',
precludes that possibility.
I updated almost all the IR with the following script:
git grep -l -E -e '= !DISubprogram\(.* isDefinition: true' |
grep -v test/Bitcode |
xargs sed -i '' -e 's/= \(!DISubprogram(.*, isDefinition: true\)/= distinct \1/'
Likely some variant of would work for out-of-tree testcases.
llvm-svn: 246327
42 lines
1.1 KiB
LLVM
42 lines
1.1 KiB
LLVM
; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | FileCheck %s
|
|
; RUN: verify-uselistorder %s
|
|
|
|
; CHECK-LABEL: @test
|
|
; CHECK: ret void, !bar !1, !foo !0
|
|
define void @test() {
|
|
add i32 2, 1, !bar !0
|
|
add i32 1, 2, !foo !1
|
|
call void @llvm.dbg.func.start(metadata !"foo")
|
|
extractvalue {{i32, i32}, i32} undef, 0, 1, !foo !0
|
|
ret void, !foo !0, !bar !1
|
|
}
|
|
|
|
; CHECK-LABEL: define void @test2() !foo !2 !baz !3
|
|
define void @test2() !foo !2 !baz !3 {
|
|
unreachable
|
|
}
|
|
|
|
; CHECK-LABEL: define void @test3() !bar !3
|
|
; CHECK: unreachable, !bar !4
|
|
define void @test3() !bar !3 {
|
|
unreachable, !bar !4
|
|
}
|
|
|
|
; CHECK-LABEL: define void @test_attachment_name() {
|
|
; CHECK: unreachable, !\342abc !4
|
|
define void @test_attachment_name() {
|
|
;; Escape the first character when printing text IR, since it's a digit
|
|
unreachable, !\34\32abc !4
|
|
}
|
|
|
|
!0 = !DILocation(line: 662302, column: 26, scope: !1)
|
|
!1 = distinct !DISubprogram(name: "foo")
|
|
!2 = distinct !{}
|
|
!3 = distinct !{}
|
|
!4 = distinct !{}
|
|
|
|
declare void @llvm.dbg.func.start(metadata) nounwind readnone
|
|
|
|
!foo = !{ !0 }
|
|
!bar = !{ !1 }
|