mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-23 11:13:28 +01:00
a2835fc0fd
While gaining practical experience hand-updating CHECK lines (for moving
the new debug info hierarchy into place), I learnt a few things about
CHECK-ability of the specialized node assembly output.
- The first part of a `CHECK:` is to identify the "right" node (this
is especially true if you intend to use the new `CHECK-SAME`
feature, since the first CHECK needs to identify the node correctly
before you can split the line).
- If there's a `tag:`, it should go first.
- If there's a `name:`, it should go next (followed by the
`linkageName:`, if any).
- If there's a `scope:`, it should follow after that.
- When a node type supports multiple DW_TAGs, but one is implied by
its name and is overwhelmingly more common, the `tag:` field is
terribly uninteresting unless it's different.
- `MDBasicType` is almost always `DW_TAG_base_type`.
- `MDTemplateValueParameter` is almost always
`DW_TAG_template_value_parameter`.
- Printing `name: ""` doesn't improve CHECK-ability, and there are far
more nodes than I realized that are commonly nameless.
- There are a few other fields that similarly aren't very interesting
when they're empty.
This commit updates the `AsmWriter` as suggested above (and makes
necessary changes in `LLParser` for round-tripping).
llvm-svn: 230877
23 lines
895 B
LLVM
23 lines
895 B
LLVM
; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | FileCheck %s
|
|
; RUN: verify-uselistorder %s
|
|
|
|
@foo = global i32 0
|
|
|
|
; CHECK: !named = !{!0, !1, !2, !3, !4, !5, !6}
|
|
!named = !{!0, !1, !2, !3, !4, !5, !6}
|
|
|
|
!0 = distinct !{}
|
|
!1 = distinct !{}
|
|
!2 = !MDFile(filename: "path/to/file", directory: "/path/to/dir")
|
|
!3 = distinct !{}
|
|
!4 = distinct !{}
|
|
|
|
; CHECK: !5 = !MDGlobalVariable(name: "foo", linkageName: "foo", scope: !0, file: !2, line: 7, type: !3, isLocal: true, isDefinition: false, variable: i32* @foo, declaration: !4)
|
|
!5 = !MDGlobalVariable(name: "foo", linkageName: "foo", scope: !0,
|
|
file: !2, line: 7, type: !3, isLocal: true,
|
|
isDefinition: false, variable: i32* @foo,
|
|
declaration: !4)
|
|
|
|
; CHECK: !6 = !MDGlobalVariable(name: "bar", scope: null, isLocal: false, isDefinition: true)
|
|
!6 = !MDGlobalVariable(name: "bar")
|