llvm-mirror

mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-01 05:01:59 +01:00

History

Jordan Rupprecht b34be145e0 [llvm-objcopy] Fix SHT_GROUP ordering.

Summary:
When llvm-objcopy sorts sections during finalization, it only sorts based on the offset, which can cause the group section to come after the sections it contains. This causes link failures when using gold to link objects created by llvm-objcopy.

Fix this for now by copying GNU objcopy's behavior of placing SHT_GROUP sections first. In the future, we may want to remove this sorting entirely to more closely preserve the input file layout.

This fixes https://bugs.llvm.org/show_bug.cgi?id=42052.

Reviewers: jakehehrlich, jhenderson, MaskRay, espindola, alexshap

Reviewed By: MaskRay

Subscribers: phuongtrang148993, emaste, arichardson, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D62620

llvm-svn: 362973

2019-06-10 18:35:01 +00:00

COFF

[llvm-objcopy] Tidy up error messages

2019-05-22 13:23:26 +00:00

ELF

[llvm-objcopy] Fix SHT_GROUP ordering.

2019-06-10 18:35:01 +00:00

MachO

Fix MSVC "32-bit shift implicitly converted to 64 bits" warning. NFCI.

2019-06-10 10:13:32 +00:00

Buffer.cpp

[llvm-objcopy][NFC] Remove unnecessary llvm-objcopy.h #includes