mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-23 04:52:54 +02:00
20a3d2184f
Summary: Local values are constants, global addresses, and stack addresses that can't be folded into the instruction that uses them. For example, when storing the address of a global variable into memory, we need to materialize that address into a register. FastISel doesn't want to materialize any given local value more than once, so it generates all local value materialization code at EmitStartPt, which always dominates the current insertion point. This allows it to maintain a map of local value registers, and it knows that the local value area will always dominate the current insertion point. The downside is that local value instructions are always emitted without a source location. This is done to prevent jumpy line tables, but it means that the local value area will be considered part of the previous statement. Consider this C code: call1(); // line 1 ++global; // line 2 ++global; // line 3 call2(&global, &local); // line 4 Today we end up with assembly and line tables like this: .loc 1 1 callq call1 leaq global(%rip), %rdi leaq local(%rsp), %rsi .loc 1 2 addq $1, global(%rip) .loc 1 3 addq $1, global(%rip) .loc 1 4 callq call2 The LEA instructions in the local value area have no source location and are treated as being on line 1. Stepping through the code in a debugger and correlating it with the assembly won't make much sense, because these materializations are only required for line 4. This is actually problematic for the VS debugger "set next statement" feature, which effectively assumes that there are no registers live across statement boundaries. By sinking the local value code into the statement and fixing up the source location, we can make that feature work. This was filed as https://bugs.llvm.org/show_bug.cgi?id=35975 and https://crbug.com/793819. This change is obviously not enough to make this feature work reliably in all cases, but I felt that it was worth doing anyway because it usually generates smaller, more comprehensible -O0 code. I measured a 0.12% regression in code generation time with LLC on the sqlite3 amalgamation, so I think this is worth doing. There are some special cases worth calling out in the commit message: 1. local values materialized for phis 2. local values used by no-op casts 3. dead local value code Local values can be materialized for phis, and this does not show up as a vreg use in MachineRegisterInfo. In this case, if there are no other uses, this patch sinks the value to the first terminator, EH label, or the end of the BB if nothing else exists. Local values may also be used by no-op casts, which adds the register to the RegFixups table. Without reversing the RegFixups map direction, we don't have enough information to sink these instructions. Lastly, if the local value register has no other uses, we can delete it. This comes up when fastisel tries two instruction selection approaches and the first materializes the value but fails and the second succeeds without using the local value. Reviewers: aprantl, dblaikie, qcolombet, MatzeB, vsk, echristo Subscribers: dotdash, chandlerc, hans, sdardis, amccarth, javed.absar, zturner, llvm-commits, hiraditya Differential Revision: https://reviews.llvm.org/D43093 llvm-svn: 327581
38 lines
1.3 KiB
LLVM
38 lines
1.3 KiB
LLVM
; RUN: llc -O0 -fast-isel -fast-isel-abort=1 -verify-machineinstrs -mtriple=arm64-apple-darwin < %s | FileCheck %s
|
|
|
|
; Test load/store of global value from global offset table.
|
|
@seed = common global i64 0, align 8
|
|
|
|
define void @Initrand() nounwind {
|
|
entry:
|
|
; CHECK: @Initrand
|
|
; CHECK: adrp [[REG:x[0-9]+]], _seed@GOTPAGE
|
|
; CHECK: ldr [[REG2:x[0-9]+]], {{\[}}[[REG]], _seed@GOTPAGEOFF{{\]}}
|
|
; CHECK: str {{x[0-9]+}}, {{\[}}[[REG2]]{{\]}}
|
|
store i64 74755, i64* @seed, align 8
|
|
ret void
|
|
}
|
|
|
|
define i32 @Rand() nounwind {
|
|
entry:
|
|
; CHECK: @Rand
|
|
; CHECK: adrp [[REG1:x[0-9]+]], _seed@GOTPAGE
|
|
; CHECK: ldr [[REG2:x[0-9]+]], {{\[}}[[REG1]], _seed@GOTPAGEOFF{{\]}}
|
|
; CHECK: ldr [[REG5:x[0-9]+]], {{\[}}[[REG2]]{{\]}}
|
|
; CHECK: mov [[REG4:x[0-9]+]], #1309
|
|
; CHECK: mul [[REG6:x[0-9]+]], [[REG5]], [[REG4]]
|
|
; CHECK: mov [[REG3:x[0-9]+]], #13849
|
|
; CHECK: add [[REG7:x[0-9]+]], [[REG6]], [[REG3]]
|
|
; CHECK: and [[REG8:x[0-9]+]], [[REG7]], #0xffff
|
|
; CHECK: str [[REG8]], {{\[}}[[REG1]]{{\]}}
|
|
; CHECK: ldr {{x[0-9]+}}, {{\[}}[[REG1]]{{\]}}
|
|
%0 = load i64, i64* @seed, align 8
|
|
%mul = mul nsw i64 %0, 1309
|
|
%add = add nsw i64 %mul, 13849
|
|
%and = and i64 %add, 65535
|
|
store i64 %and, i64* @seed, align 8
|
|
%1 = load i64, i64* @seed, align 8
|
|
%conv = trunc i64 %1 to i32
|
|
ret i32 %conv
|
|
}
|