mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
b4b16598f6
Problem: `FILECHECK_OPTS` was implemented so that a test runner, such as a bot, can specify FileCheck debugging options, such as `-dump-input=fail`. However, some existing test suites have FileCheck calls that already specify `-dump-input=fail` or `-dump-input=always`. Without this patch, such tests fail under such a test runner because FileCheck doesn't accept multiple occurrences of `-dump-input`. Solution: This patch permits multiple occurrences of `-dump-input` by assigning precedence to its values in the following descending order: `help`, `always`, `fail`, and `never`. That is, any occurrence of `help` always obtains help, and otherwise the behavior is similar to `-v` vs. `-vv` in that the option specifying the greatest verbosity has precedence. Rationale: My justification for the new behavior is as follows. I have not experienced use cases where, either as a test runner or as a test author, I want to **limit** the permitted debugging verbosity (except as a test author in FileCheck's or lit's test suites where the FileCheck debugging output itself is under test, but the solution there is `env FILECHECK_OPTS=`, and I imagine we should use the same solution anywhere else this need might occur). Of course, as either a test runner or test author, it is useful to **increase** debugging verbosity. Reviewed By: probinson Differential Revision: https://reviews.llvm.org/D70784 |
||
|---|---|---|
| .. | ||
| check-a-b-has-b.txt | ||
| check-b-a-has-b.txt | ||
| check-count.txt | ||
| check-dag-multi-prefix-2.txt | ||
| check-dag-multi-prefix.txt | ||
| check-dag-not-dag.txt | ||
| check-dag-overlap-torture.txt | ||
| check-dag-overlap.txt | ||
| check-dag-substring-prefix.txt | ||
| check-dag-xfails.txt | ||
| check-dag.txt | ||
| check-empty2.txt | ||
| check-empty-tag.txt | ||
| check-empty.txt | ||
| check-ignore-case.txt | ||
| check-label-dag-capture.txt | ||
| check-label-dag.txt | ||
| check-label.txt | ||
| check-multi-prefix-label.txt | ||
| check-multiple-prefixes-mixed.txt | ||
| check-multiple-prefixes-nomatch-2.txt | ||
| check-multiple-prefixes-nomatch.txt | ||
| check-multiple-prefixes-substr.txt | ||
| check-not-diaginfo.txt | ||
| check-prefixes.txt | ||
| check-substring-multi-prefix-2.txt | ||
| check-substring-multi-prefix.txt | ||
| dos-style-eol.txt | ||
| dump-input-annotations.txt | ||
| dump-input-enable.txt | ||
| empty-regex-match-at-start.txt | ||
| envvar-opts.txt | ||
| first-character-match.txt | ||
| implicit-check-not.txt | ||
| line-count-2.txt | ||
| line-count.txt | ||
| lit.local.cfg | ||
| match-full-lines.txt | ||
| multiple-missing-prefixes.txt | ||
| next-no-match.txt | ||
| no-check-file.txt | ||
| no-multi-suffixes.txt | ||
| numeric-defines-diagnostics.txt | ||
| numeric-defines.txt | ||
| numeric-expression.txt | ||
| opt-color.txt | ||
| regex-brackets.txt | ||
| regex-no-match.txt | ||
| same.txt | ||
| separate-multi-prefix.txt | ||
| simple-var-capture.txt | ||
| string-defines-diagnostics.txt | ||
| string-defines.txt | ||
| two-checks-for-same-match.txt | ||
| validate-check-prefix.txt | ||
| var-ref-same-line.txt | ||
| var-scope.txt | ||
| verbose.txt | ||